[GitHub] [iceberg] szehon-ho commented on pull request #6797: Spark 3.3: Return partition stats for AddFiles procedure

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on PR #6797:
URL: https://github.com/apache/iceberg/pull/6797#issuecomment-1426446813

   Hi @dramaticlly , looking briefly through this code.  It seems we get added-files via snapshot summary so it seems ok to get it this way for changed-partitions.
   
   I'm a bit confused though, it seems it only sets if changed partitions <= write.summary.partition-limit, whose default is 0.  Does it usually set in your case?  Ref: https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/SnapshotSummary.java#L194 
   
   I havent walked through the code though, so I could be wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org