You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Matt Jones (JIRA)" <ji...@apache.org> on 2009/10/30 23:37:59 UTC

[jira] Created: (THRIFT-615) TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue

TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue
------------------------------------------------------------------------------------

                 Key: THRIFT-615
                 URL: https://issues.apache.org/jira/browse/THRIFT-615
             Project: Thrift
          Issue Type: Bug
          Components: Library (Python)
            Reporter: Matt Jones
            Priority: Minor
         Attachments: thrift-task-done.diff

Exactly as the title says. The effect of the bug is that you can't join the clients queue, since no client has ever signalled itself as done. The fix is trivial (patch attached).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (THRIFT-615) TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772141#action_12772141 ] 

David Reiss commented on THRIFT-615:
------------------------------------

Why is this a bug?  No one is trying to join the queue.  If you are just trying to add a new capability, can you edit this issue to make it an "improvement" or a "new feature"?

> TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue
> ------------------------------------------------------------------------------------
>
>                 Key: THRIFT-615
>                 URL: https://issues.apache.org/jira/browse/THRIFT-615
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>            Reporter: Matt Jones
>            Priority: Minor
>         Attachments: thrift-task-done-2.diff, thrift-task-done.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Exactly as the title says. The effect of the bug is that you can't join the clients queue, since no client has ever signalled itself as done. The fix is trivial (patch attached).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (THRIFT-615) TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue

Posted by "Matt Jones (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Jones updated THRIFT-615:
------------------------------

    Attachment: thrift-task-done-2.diff

Here's the file with the queue get and the process separated into different try's

> TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue
> ------------------------------------------------------------------------------------
>
>                 Key: THRIFT-615
>                 URL: https://issues.apache.org/jira/browse/THRIFT-615
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>            Reporter: Matt Jones
>            Priority: Minor
>         Attachments: thrift-task-done-2.diff, thrift-task-done.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Exactly as the title says. The effect of the bug is that you can't join the clients queue, since no client has ever signalled itself as done. The fix is trivial (patch attached).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (THRIFT-615) TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue

Posted by "Matt Jones (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Jones updated THRIFT-615:
------------------------------

    Attachment: thrift-task-done.diff

Call task_done after every task is completed. it might be worth breaking apart the the get() and the process actions so an error in clients.get() won't still result in task_done being called.

> TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue
> ------------------------------------------------------------------------------------
>
>                 Key: THRIFT-615
>                 URL: https://issues.apache.org/jira/browse/THRIFT-615
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>            Reporter: Matt Jones
>            Priority: Minor
>         Attachments: thrift-task-done.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Exactly as the title says. The effect of the bug is that you can't join the clients queue, since no client has ever signalled itself as done. The fix is trivial (patch attached).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.