[GitHub] [hive] zmatyus commented on a change in pull request #1916: HIVE-24691: Ban commons-logging (again)

[GitBox <gi...@apache.org>]

zmatyus commented on a change in pull request #1916:
URL: https://github.com/apache/hive/pull/1916#discussion_r565348608



##########
File path: pom.xml
##########
@@ -1360,6 +1360,13 @@
                   </bannedImports>
                   <includeTestCode>true</includeTestCode>
                 </restrictImports>
+                <restrictImports implementation="de.skuzzle.enforcer.restrictimports.RestrictImports">
+                  <reason>Do not use commons-logging; use slf4j</reason>
+                  <bannedImports>
+                    <bannedImport>org.apache.commons.logging.**</bannedImport>

Review comment:
       I'm not sure. We have 4 imports altogether; but these were present in HIVE-20019 too.
   
   ```
   accumulo-handler/src/java/.../accumulo/mr/HiveAccumuloTableInputFormat.java:import org.apache.log4j.Level;
   accumulo-handler/src/test/.../accumulo/TestHiveAccumuloHelper.java:import org.apache.log4j.Logger;
   llap-server/src/java/.../llap/daemon/impl/ContainerRunnerImpl.java:import org.apache.log4j.NDC;
   llap-server/src/java/.../llap/daemon/impl/TaskRunnerCallable.java:import org.apache.log4j.NDC;
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org