You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/11/28 13:57:17 UTC
Review Request 54124: ambari-server.pid might not be created on slow
harware
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997
Repository: ambari
Description
-------
ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
Diffs
-----
ambari-server/src/main/python/ambari_server/utils.py f505444
ambari-server/src/main/python/ambari_server_main.py b35cfc9
ambari-server/src/test/python/TestUtils.py db94d92
Diff: https://reviews.apache.org/r/54124/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On \u041d\u043e\u044f. 29, 2016, 4:02 \u043f.\u043f., Sumit Mohanty wrote:
> > ambari-server/src/main/python/ambari_server_main.py, line 107
> > <https://reviews.apache.org/r/54124/diff/2/?file=1572061#file1572061line107>
> >
> > Nit - remove #seconds
Fixed
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/#review157263
-----------------------------------------------------------
On \u041d\u043e\u044f. 29, 2016, 4:53 \u043f.\u043f., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54124/
> -----------------------------------------------------------
>
> (Updated \u041d\u043e\u044f. 29, 2016, 4:53 \u043f.\u043f.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-18997
> https://issues.apache.org/jira/browse/AMBARI-18997
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/utils.py 5188a48
> ambari-server/src/main/python/ambari_server_main.py 62f8980
> ambari-server/src/test/python/TestAmbariServer.py 76857cd
> ambari-server/src/test/python/TestUtils.py bedd75c
>
> Diff: https://reviews.apache.org/r/54124/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/#review157263
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server_main.py (line 105)
<https://reviews.apache.org/r/54124/#comment227788>
Nit - remove #seconds
- Sumit Mohanty
On Nov. 29, 2016, 3:54 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54124/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 3:54 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-18997
> https://issues.apache.org/jira/browse/AMBARI-18997
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/utils.py 5188a48
> ambari-server/src/main/python/ambari_server_main.py 62f8980
> ambari-server/src/test/python/TestAmbariServer.py 76857cd
> ambari-server/src/test/python/TestUtils.py bedd75c
>
> Diff: https://reviews.apache.org/r/54124/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/#review157283
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Nov. 29, 2016, 5:04 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54124/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 5:04 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-18997
> https://issues.apache.org/jira/browse/AMBARI-18997
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/utils.py 5188a48
> ambari-server/src/main/python/ambari_server_main.py 62f8980
> ambari-server/src/test/python/TestAmbariServer.py 76857cd
> ambari-server/src/test/python/TestUtils.py bedd75c
>
> Diff: https://reviews.apache.org/r/54124/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [3.655s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
> [INFO] Ambari Views ...................................... SUCCESS [1.987s]
> [INFO] utility ........................................... SUCCESS [0.402s]
> [INFO] ambari-metrics .................................... SUCCESS [0.324s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.735s]
> [INFO] Ambari Server ..................................... SUCCESS [1:02.776s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
-----------------------------------------------------------
(Updated \u041d\u043e\u044f. 30, 2016, 11:49 \u0434.\u043f.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997
Repository: ambari
Description
-------
ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
Diffs (updated)
-----
ambari-server/src/main/python/ambari_server/utils.py 5188a48
ambari-server/src/main/python/ambari_server_main.py 62f8980
ambari-server/src/test/python/TestAmbariServer.py 76857cd
ambari-server/src/test/python/TestUtils.py bedd75c
Diff: https://reviews.apache.org/r/54124/diff/
Testing
-------
Unit tests passed
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [3.655s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
[INFO] Ambari Views ...................................... SUCCESS [1.987s]
[INFO] utility ........................................... SUCCESS [0.402s]
[INFO] ambari-metrics .................................... SUCCESS [0.324s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.735s]
[INFO] Ambari Server ..................................... SUCCESS [1:02.776s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
-----------------------------------------------------------
(Updated \u041d\u043e\u044f. 29, 2016, 6:14 \u043f.\u043f.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997
Repository: ambari
Description
-------
ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
Diffs (updated)
-----
ambari-server/src/main/python/ambari_server/utils.py 5188a48
ambari-server/src/main/python/ambari_server_main.py 62f8980
ambari-server/src/test/python/TestAmbariServer.py 76857cd
ambari-server/src/test/python/TestUtils.py bedd75c
Diff: https://reviews.apache.org/r/54124/diff/
Testing
-------
Unit tests passed
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [3.655s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
[INFO] Ambari Views ...................................... SUCCESS [1.987s]
[INFO] utility ........................................... SUCCESS [0.402s]
[INFO] ambari-metrics .................................... SUCCESS [0.324s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.735s]
[INFO] Ambari Server ..................................... SUCCESS [1:02.776s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Sid Wagle <sw...@hortonworks.com>.
> On Nov. 29, 2016, 5:26 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/python/ambari_server/utils.py, lines 168-170
> > <https://reviews.apache.org/r/54124/diff/4/?file=1572109#file1572109line168>
> >
> > Removing initialization of `tstart` would cause `local variable 'tstart' referenced before assignment` if `wait_for_pid` was ever called. But the function becomes unused with this change. Removing the whole function now might prevent some surprises down the road.
+1 Removing unused calls.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/#review157278
-----------------------------------------------------------
On Nov. 29, 2016, 5:04 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54124/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 5:04 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-18997
> https://issues.apache.org/jira/browse/AMBARI-18997
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/utils.py 5188a48
> ambari-server/src/main/python/ambari_server_main.py 62f8980
> ambari-server/src/test/python/TestAmbariServer.py 76857cd
> ambari-server/src/test/python/TestUtils.py bedd75c
>
> Diff: https://reviews.apache.org/r/54124/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [3.655s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
> [INFO] Ambari Views ...................................... SUCCESS [1.987s]
> [INFO] utility ........................................... SUCCESS [0.402s]
> [INFO] ambari-metrics .................................... SUCCESS [0.324s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.735s]
> [INFO] Ambari Server ..................................... SUCCESS [1:02.776s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On \u041d\u043e\u044f. 29, 2016, 5:26 \u043f.\u043f., Attila Doroszlai wrote:
> > ambari-server/src/main/python/ambari_server/utils.py, lines 168-170
> > <https://reviews.apache.org/r/54124/diff/4/?file=1572109#file1572109line168>
> >
> > Removing initialization of `tstart` would cause `local variable 'tstart' referenced before assignment` if `wait_for_pid` was ever called. But the function becomes unused with this change. Removing the whole function now might prevent some surprises down the road.
>
> Sid Wagle wrote:
> +1 Removing unused calls.
Thanks for pointing on this
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/#review157278
-----------------------------------------------------------
On \u041d\u043e\u044f. 29, 2016, 6:14 \u043f.\u043f., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54124/
> -----------------------------------------------------------
>
> (Updated \u041d\u043e\u044f. 29, 2016, 6:14 \u043f.\u043f.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-18997
> https://issues.apache.org/jira/browse/AMBARI-18997
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/utils.py 5188a48
> ambari-server/src/main/python/ambari_server_main.py 62f8980
> ambari-server/src/test/python/TestAmbariServer.py 76857cd
> ambari-server/src/test/python/TestUtils.py bedd75c
>
> Diff: https://reviews.apache.org/r/54124/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [3.655s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
> [INFO] Ambari Views ...................................... SUCCESS [1.987s]
> [INFO] utility ........................................... SUCCESS [0.402s]
> [INFO] ambari-metrics .................................... SUCCESS [0.324s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.735s]
> [INFO] Ambari Server ..................................... SUCCESS [1:02.776s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/#review157278
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server/utils.py (line 163)
<https://reviews.apache.org/r/54124/#comment227802>
Removing initialization of `tstart` would cause `local variable 'tstart' referenced before assignment` if `wait_for_pid` was ever called. But the function becomes unused with this change. Removing the whole function now might prevent some surprises down the road.
- Attila Doroszlai
On Nov. 29, 2016, 6:04 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54124/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 6:04 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-18997
> https://issues.apache.org/jira/browse/AMBARI-18997
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/utils.py 5188a48
> ambari-server/src/main/python/ambari_server_main.py 62f8980
> ambari-server/src/test/python/TestAmbariServer.py 76857cd
> ambari-server/src/test/python/TestUtils.py bedd75c
>
> Diff: https://reviews.apache.org/r/54124/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [3.655s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
> [INFO] Ambari Views ...................................... SUCCESS [1.987s]
> [INFO] utility ........................................... SUCCESS [0.402s]
> [INFO] ambari-metrics .................................... SUCCESS [0.324s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.735s]
> [INFO] Ambari Server ..................................... SUCCESS [1:02.776s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
-----------------------------------------------------------
(Updated \u041d\u043e\u044f. 29, 2016, 5:04 \u043f.\u043f.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997
Repository: ambari
Description
-------
ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
Diffs (updated)
-----
ambari-server/src/main/python/ambari_server/utils.py 5188a48
ambari-server/src/main/python/ambari_server_main.py 62f8980
ambari-server/src/test/python/TestAmbariServer.py 76857cd
ambari-server/src/test/python/TestUtils.py bedd75c
Diff: https://reviews.apache.org/r/54124/diff/
Testing
-------
Unit tests passed
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [3.655s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
[INFO] Ambari Views ...................................... SUCCESS [1.987s]
[INFO] utility ........................................... SUCCESS [0.402s]
[INFO] ambari-metrics .................................... SUCCESS [0.324s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.735s]
[INFO] Ambari Server ..................................... SUCCESS [1:02.776s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
-----------------------------------------------------------
(Updated \u041d\u043e\u044f. 29, 2016, 5:04 \u043f.\u043f.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997
Repository: ambari
Description
-------
ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
Diffs
-----
ambari-server/src/main/python/ambari_server/utils.py 5188a48
ambari-server/src/main/python/ambari_server_main.py 62f8980
ambari-server/src/test/python/TestAmbariServer.py 76857cd
ambari-server/src/test/python/TestUtils.py bedd75c
Diff: https://reviews.apache.org/r/54124/diff/
Testing (updated)
-------
Unit tests passed
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [3.655s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.005s]
[INFO] Ambari Views ...................................... SUCCESS [1.987s]
[INFO] utility ........................................... SUCCESS [0.402s]
[INFO] ambari-metrics .................................... SUCCESS [0.324s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.735s]
[INFO] Ambari Server ..................................... SUCCESS [1:02.776s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
-----------------------------------------------------------
(Updated \u041d\u043e\u044f. 29, 2016, 4:53 \u043f.\u043f.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997
Repository: ambari
Description
-------
ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
Diffs (updated)
-----
ambari-server/src/main/python/ambari_server/utils.py 5188a48
ambari-server/src/main/python/ambari_server_main.py 62f8980
ambari-server/src/test/python/TestAmbariServer.py 76857cd
ambari-server/src/test/python/TestUtils.py bedd75c
Diff: https://reviews.apache.org/r/54124/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
-----------------------------------------------------------
(Updated \u041d\u043e\u044f. 29, 2016, 3:54 \u043f.\u043f.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997
Repository: ambari
Description
-------
ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
Diffs (updated)
-----
ambari-server/src/main/python/ambari_server/utils.py 5188a48
ambari-server/src/main/python/ambari_server_main.py 62f8980
ambari-server/src/test/python/TestAmbariServer.py 76857cd
ambari-server/src/test/python/TestUtils.py bedd75c
Diff: https://reviews.apache.org/r/54124/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 54124: ambari-server.pid might not be created on
slow hardware
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
-----------------------------------------------------------
(Updated \u041d\u043e\u044f. 28, 2016, 1:57 \u043f.\u043f.)
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Summary (updated)
-----------------
ambari-server.pid might not be created on slow hardware
Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997
Repository: ambari
Description
-------
ambari-server.pid file might not be created on slow hardware, but "ambari-server start" exits with 0
Diffs
-----
ambari-server/src/main/python/ambari_server/utils.py f505444
ambari-server/src/main/python/ambari_server_main.py b35cfc9
ambari-server/src/test/python/TestUtils.py db94d92
Diff: https://reviews.apache.org/r/54124/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen