You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/22 23:36:55 UTC
Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/discarded`
To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.
Diffs
-----
src/csi/client.hpp 5d846740f72125efb3654e14d763bd24634367b9
src/csi/client.cpp 559e8057eccce5bf758918c24e5ca8c561af6592
src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
Diff: https://reviews.apache.org/r/67255/diff/1/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/#review204137
-----------------------------------------------------------
Fix it, then Ship it!
src/csi/client.hpp
Lines 68 (patched)
<https://reviews.apache.org/r/67255/#comment286533>
nits: I'd just make this consistent with others :)
```
template <>
process::Future<DeleteVolumeResponse>
Client::call<DELETE_VOLUME>(
const DeleteVolumeRequest& request);
```
Ditto below.
src/resource_provider/storage/provider.cpp
Lines 1776 (patched)
<https://reviews.apache.org/r/67255/#comment286534>
Does this work? Can you make it more verbose if that's your intention to log here.
- Jie Yu
On May 30, 2018, 3:01 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67255/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 3:01 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8943
> https://issues.apache.org/jira/browse/MESOS-8943
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
> metrics for SLRP:
> `csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
> `csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
> `csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
> `csi_plugin/rpcs/csi.v0.Identity.Probe/cancelled`
>
> To add these per-CSI-call metrics, each method in `csi::v0::Client`,
> e.g., `csi::v0::Client::Probe`, is changed to
> `csi::v0::Client::call<PROBE>`, to make RPC calls based on the RPC enum
> value. A `call` helper function in SLRP is also added to intercept CSI
> calls and update the corresponding metrics.
>
>
> Diffs
> -----
>
> src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
> src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
> src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
> src/tests/csi_client_tests.cpp d5993d617056e86ae5a1224258cc6e0741466166
>
>
> Diff: https://reviews.apache.org/r/67255/diff/8/
>
>
> Testing
> -------
>
> sudo make check
>
> A unit test for the metrics will be introduced in the next patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 31, 2018, 11:06 p.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Jie's comments.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/cancelled`
To add these per-CSI-call metrics, each method in `csi::v0::Client`,
e.g., `csi::v0::Client::Probe`, is changed to
`csi::v0::Client::call<PROBE>`, to make RPC calls based on the RPC enum
value. A `call` helper function in SLRP is also added to intercept CSI
calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
src/resource_provider/storage/provider.cpp 2c7dd8d96915d68a7cdfcb870d5448bc25ea9011
src/tests/csi_client_tests.cpp d5993d617056e86ae5a1224258cc6e0741466166
Diff: https://reviews.apache.org/r/67255/diff/9/
Changes: https://reviews.apache.org/r/67255/diff/8-9/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 30, 2018, 3:01 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Refactored to use the `RPC` enum and have a simpler wrapper in SLRP.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description (updated)
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/cancelled`
To add these per-CSI-call metrics, each method in `csi::v0::Client`,
e.g., `csi::v0::Client::Probe`, is changed to
`csi::v0::Client::call<PROBE>`, to make RPC calls based on the RPC enum
value. A `call` helper function in SLRP is also added to intercept CSI
calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
src/tests/csi_client_tests.cpp d5993d617056e86ae5a1224258cc6e0741466166
Diff: https://reviews.apache.org/r/67255/diff/8/
Changes: https://reviews.apache.org/r/67255/diff/7-8/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 25, 2018, 10:39 p.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Renamed `discarded` metrics to `cancelled` as this makes more sense to the user.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description (updated)
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/discarded`
To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
Diff: https://reviews.apache.org/r/67255/diff/7/
Changes: https://reviews.apache.org/r/67255/diff/6-7/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 24, 2018, 8:20 p.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Fixed a typo.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/discarded`
To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
Diff: https://reviews.apache.org/r/67255/diff/6/
Changes: https://reviews.apache.org/r/67255/diff/5-6/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 24, 2018, 3:28 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Switch-case on a non-constant to make the sanity check effective.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/discarded`
To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
Diff: https://reviews.apache.org/r/67255/diff/5/
Changes: https://reviews.apache.org/r/67255/diff/4-5/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 24, 2018, 2:55 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Moved the helpers related to the `RPC` enum into `client.hpp`.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/discarded`
To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9
src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
Diff: https://reviews.apache.org/r/67255/diff/4/
Changes: https://reviews.apache.org/r/67255/diff/3-4/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 24, 2018, 12:49 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Used a switch statement to enable a compile-time sanity check for adding RPC metrics.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/discarded`
To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809
src/csi/utils.hpp 5ce318e52bc39555ca09bf68dca6dedea988e5a4
src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc
src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
Diff: https://reviews.apache.org/r/67255/diff/3/
Changes: https://reviews.apache.org/r/67255/diff/2-3/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
-----------------------------------------------------------
(Updated May 23, 2018, 12:27 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased on top of the upstream master.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/discarded`
To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.
Diffs (updated)
-----
src/csi/client.hpp 5d846740f72125efb3654e14d763bd24634367b9
src/csi/client.cpp 559e8057eccce5bf758918c24e5ca8c561af6592
src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180
Diff: https://reviews.apache.org/r/67255/diff/2/
Changes: https://reviews.apache.org/r/67255/diff/1-2/
Testing
-------
sudo make check
A unit test for the metrics will be introduced in the next patch.
Thanks,
Chun-Hung Hsiao