[GitHub] peedeeboy opened a new pull request #1093: [NETBEANS-1457] Fix for CSS text-align property value start is unsupported

[GitBox <gi...@apache.org>]

peedeeboy opened a new pull request #1093: [NETBEANS-1457] Fix for CSS text-align property value start is unsupported
URL: https://github.com/apache/incubator-netbeans/pull/1093
 
 
   Quick fix.  The NB CSS parser was configured for:
   [ [ start | !string ]? [ start | end | left | right | center | justify | match-parent ] ] | inherit | initial
   
   However, the most recent version of the W3C CSS3 Text Module spec (https://www.w3.org/TR/css-text-3/) states it should be:
   start | end | left | right | center | justify | match-parent | justify-all | inherit | initial
   
   Updated ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/text.properties which fixed code completion and parsing.
   
   Also updated Unit test for Text Module (https://github.com/apache/incubator-netbeans/compare/master...peedeeboy:NETBEANS-1457?expand=1#diff-2b438eeef85a95579613379ee38f574f) accordingly.
   
   To test
   ---------
   * Create a new NB10.0 HTML or PHP project
   * Create a new CSS file
   * Copy & paste the following code:
   .testclass1 {
       text-align: start;
   }
   
   .testclass2 {
       text-align: justify-all;
   }
   
   .testclass3 {
       text-align: start center;
   }
   * .testclass3 should show a parsing error, .testclass1 and .testclass2 should not (before this PR, the inverse would be true...)
   
   
   Hope this helps :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists