[GitHub] [incubator-pekko-samples] pjfanning commented on a diff in pull request #53: Fix main class and ports errors

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #53:
URL: https://github.com/apache/incubator-pekko-samples/pull/53#discussion_r1280269126


##########
pekko-sample-persistence-dc-scala/README.md:
##########
@@ -6,14 +6,14 @@ to run a replica per datacenter.
 
 ## How to run
 
-1. In terminal 1: `sbt "runMain sample.persistence.multidc.ThumbsUpApp cassandra"`
+1. In terminal 1: `sbt "runMain sample.persistence.res.MainApp cassandra"`
 
-1. In terminal 2: `sbt "runMain sample.persistence.multidc.ThumbsUpApp 7345 eu-west"`
+1. In terminal 2: `sbt "runMain sample.persistence.res.MainApp 7345 eu-west"`
 
-1. In terminal 3: `sbt "runMain sample.persistence.multidc.ThumbsUpApp 7355 eu-central"`
+1. In terminal 3: `sbt "runMain sample.persistence.res.MainApp 7355 eu-central"`
 
 1. In terminal 4:
-    * To add a thumbs-up for resource `pekko` from user `u1` in DC `eu-west`: `curl -X POST http://127.0.0.1:17356/thumbs-up/pekko/u1`
-    * To add a thumbs-up for resource `pekko` from user `u2` in DC `eu-west`: `curl -X POST http://127.0.0.1:17357/thumbs-up/pekko/u2`
-    * To get the users that gave thumbs-up for resource `pekko`: `curl http://127.0.0.1:17357/thumbs-up/pekko`
-    * Note the port numbers 17356 for eu-west and 17357 for eu-central
+   * To add a thumbs-up for resource `pekko` from user `u1` in DC `eu-west`: `curl -X POST http://127.0.0.1:27355/thumbs-up/pekko/u1`
+   * To add a thumbs-up for resource `pekko` from user `u2` in DC `eu-west`: `curl -X POST http://127.0.0.1:27345/thumbs-up/pekko/u2`
+   * To get the users that gave thumbs-up for resource `pekko`: `curl http://127.0.0.1:27355/thumbs-up/pekko`

Review Comment:
   * keep the 20000
   * the code is called with (both Scala and Java samples)
   
   ```
       startNode(2551, "eu-west")
       startNode(2552, "eu-central")
   ```
   
   Could you change 2552 to 7355 (Akka default port to Pekko default port)? Change 2551 to 7354.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org