You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lukecwik <gi...@git.apache.org> on 2016/09/08 16:42:10 UTC
[GitHub] incubator-beam pull request #934: Address comments during backport Dataflow ...
GitHub user lukecwik opened a pull request:
https://github.com/apache/incubator-beam/pull/934
Address comments during backport Dataflow PR/423 for Apache Beam PR/918
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam fixup-pr-918
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/934.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #934
----
commit fea99b0466646e553f773d1bfc0a6553c48b49b4
Author: Luke Cwik <lc...@google.com>
Date: 2016-09-08T16:34:43Z
Address comments during backport Dataflow PR/423 for Apache Beam PR/918
commit facabfca910cb215c7044b97becf58dcb4fd933b
Author: Luke Cwik <lc...@google.com>
Date: 2016-09-08T16:40:19Z
!fixup Fix changes done by IDE. new line -> newline
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #934: [BEAM-544] Address comments during backpor...
Posted by lukecwik <gi...@git.apache.org>.
Github user lukecwik closed the pull request at:
https://github.com/apache/incubator-beam/pull/934
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #934: [BEAM-544] Address comments during backpor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/934
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #934: [BEAM-544] Address comments during backpor...
Posted by lukecwik <gi...@git.apache.org>.
GitHub user lukecwik reopened a pull request:
https://github.com/apache/incubator-beam/pull/934
[BEAM-544] Address comments during backport Dataflow PR/423 for Apache Beam PR/918
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam fixup-pr-918
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/934.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #934
----
commit fea99b0466646e553f773d1bfc0a6553c48b49b4
Author: Luke Cwik <lc...@google.com>
Date: 2016-09-08T16:34:43Z
Address comments during backport Dataflow PR/423 for Apache Beam PR/918
commit facabfca910cb215c7044b97becf58dcb4fd933b
Author: Luke Cwik <lc...@google.com>
Date: 2016-09-08T16:40:19Z
!fixup Fix changes done by IDE. new line -> newline
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---