You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2011/05/18 22:28:39 UTC
Re: svn commit: r1124375 - in /subversion/trunk/subversion: libsvn_client/checkout.c
libsvn_wc/upgrade.c
On 05/18/2011 08:47 PM, steveking@apache.org wrote:
> Author: steveking
> Date: Wed May 18 18:47:42 2011
> New Revision: 1124375
>
> URL: http://svn.apache.org/viewvc?rev=1124375&view=rev
> Log:
> Resolve issue #3887, "Eliminate client-specific suggestions from shared
> libraries", by changing the error messages.
>
> * subversion/libsvn_client/checkout.c
> (svn_client__checkout_internal): remove reference to 'svn update'
> * subversion/libsvn_wc/upgrade.c
> (upgrade_to_wcng): remove reference to 'svn cleanup'
Hrm. I rather expected that this change would have two components:
1. Remove references to 'svn' subcommands from share lib error messages.
2. From the same places, return unique-enough error codes that the client
catches so *it* can give those same client-specific suggestions.
Looks like only step #1 was done here. Were you intending to take this further?
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svn commit: r1124375 - in /subversion/trunk/subversion: libsvn_client/checkout.c
libsvn_wc/upgrade.c
Posted by Stefan Küng <to...@gmail.com>.
On 19.05.2011 10:36, Julian Foad wrote:
> Stefan, please could you put those explanations in the log message?
Ok, done.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Re: svn commit: r1124375 - in /subversion/trunk/subversion:
libsvn_client/checkout.c libsvn_wc/upgrade.c
Posted by Julian Foad <ju...@wandisco.com>.
Stefan, please could you put those explanations in the log message?
- Julian
On Thu, 2011-05-19 at 08:35 +0200, C. Michael Pilato wrote:
> On 05/19/2011 08:11 AM, Stefan Küng wrote:
> >> Hrm. I rather expected that this change would have two components:
> >>
> >> 1. Remove references to 'svn' subcommands from share lib error messages.
> >> 2. From the same places, return unique-enough error codes that the client
> >> catches so *it* can give those same client-specific suggestions.
> >>
> >> Looks like only step #1 was done here. Were you intending to take this further?
> >
> > In checkout.c, I'm pretty sure an update doesn't help: why would an
> > update do anything good in case of a failed checkout because a folder
> > is already a working copy for a different url? IMHO that update hint
> > was wrong in the first place. --> an update does not change the fact
> > that there's a working copy from another repo in the way.
> >
> > In upgrade.c, a different error code won't help since the cleanup has
> > to be done with an 1.6 client (i.e., a client with an older version).
> > So a client simply can not act on this and do the cleanup itself.
>
> Thanks for the explanation of your reasoning. I concur.
>
Re: svn commit: r1124375 - in /subversion/trunk/subversion: libsvn_client/checkout.c
libsvn_wc/upgrade.c
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 05/19/2011 08:11 AM, Stefan Küng wrote:
>> Hrm. I rather expected that this change would have two components:
>>
>> 1. Remove references to 'svn' subcommands from share lib error messages.
>> 2. From the same places, return unique-enough error codes that the client
>> catches so *it* can give those same client-specific suggestions.
>>
>> Looks like only step #1 was done here. Were you intending to take this further?
>
> In checkout.c, I'm pretty sure an update doesn't help: why would an
> update do anything good in case of a failed checkout because a folder
> is already a working copy for a different url? IMHO that update hint
> was wrong in the first place. --> an update does not change the fact
> that there's a working copy from another repo in the way.
>
> In upgrade.c, a different error code won't help since the cleanup has
> to be done with an 1.6 client (i.e., a client with an older version).
> So a client simply can not act on this and do the cleanup itself.
Thanks for the explanation of your reasoning. I concur.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svn commit: r1124375 - in /subversion/trunk/subversion:
libsvn_client/checkout.c libsvn_wc/upgrade.c
Posted by Stefan Küng <to...@gmail.com>.
On Wed, May 18, 2011 at 22:28, C. Michael Pilato <cm...@collab.net> wrote:
> On 05/18/2011 08:47 PM, steveking@apache.org wrote:
>> Author: steveking
>> Date: Wed May 18 18:47:42 2011
>> New Revision: 1124375
>>
>> URL: http://svn.apache.org/viewvc?rev=1124375&view=rev
>> Log:
>> Resolve issue #3887, "Eliminate client-specific suggestions from shared
>> libraries", by changing the error messages.
>>
>> * subversion/libsvn_client/checkout.c
>> (svn_client__checkout_internal): remove reference to 'svn update'
>> * subversion/libsvn_wc/upgrade.c
>> (upgrade_to_wcng): remove reference to 'svn cleanup'
>
> Hrm. I rather expected that this change would have two components:
>
> 1. Remove references to 'svn' subcommands from share lib error messages.
> 2. From the same places, return unique-enough error codes that the client
> catches so *it* can give those same client-specific suggestions.
>
> Looks like only step #1 was done here. Were you intending to take this further?
In checkout.c, I'm pretty sure an update doesn't help: why would an
update do anything good in case of a failed checkout because a folder
is already a working copy for a different url? IMHO that update hint
was wrong in the first place. --> an update does not change the fact
that there's a working copy from another repo in the way.
In upgrade.c, a different error code won't help since the cleanup has
to be done with an 1.6 client (i.e., a client with an older version).
So a client simply can not act on this and do the cleanup itself.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net