You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "pilichoumao (via GitHub)" <gi...@apache.org> on 2026/10/12 04:10:03 UTC

[PR] fix(rmqctl): preserve mutation summary number precision [rocketmq-dashboard]

pilichoumao opened a new pull request, #6319:
URL: https://github.com/apache/rocketmq-dashboard/pull/6319

   Fixes #6318. Follow-up to #5262 and the mutation-summary boundary previously identified by @yyqdbngt in #5340 (closed by the stale bot, not merged). Credit to that prior contribution; this is a focused completion of the remaining boundary on current trunk.
   
   The REST client preserves JSON numbers, but `DecodeMutationOutput` decodes `plan` and `result` through `float64` again. Default `group reset-offset --dry-run` table summaries therefore display queue offset `9007199254740993` as `9007199254740992`, even though JSON/YAML output remains exact.
   
   Use `UseNumber` at that single decode site. Preserve plan/result numeric literals and existing status validation; document default summary behavior. No generic numeric normalization helper, REST client modification, dependency change or broker mutation is included.
   
   Validation on rocketmq-studio `5e4c39b053c35a5598cc79ff331b8a54e649d7b1`:
   - Actual App.Execute dry-run regression fails in table mode on baseline; JSON/YAML are passing controls. All three pass after the fix. The HTTP fixture asserts the reset-offset tool and `dry_run=true` request.
   - Nested plan/result round-trips cover both PLANNED and EXECUTED, int64 limits, values above 2^53, fractional/exponent numbers and ordinary JSON values. Metadata and invalid-value/status behavior are checked.
   - `go test -race -count=1 -parallel 1 -timeout 60s ./...` passes.
   - `make fmt vet build-all` passes, including catalog consistency and six target builds/license manifests.
   
   Checks ran sequentially with `GOMAXPROCS=1`, `GOMEMLIMIT=384MiB`, `GOFLAGS=-p=1`. No cluster/database required; no reset was applied. AI-assisted implementation; final diff and raw test evidence reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(rmqctl): preserve mutation summary number precision [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6319: fix(rmqctl): preserve mutation summary number precision
URL: https://github.com/apache/rocketmq-dashboard/pull/6319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(rmqctl): preserve mutation summary number precision [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6319:
URL: https://github.com/apache/rocketmq-dashboard/pull/6319#issuecomment-6305443948

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org