[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4736: Catch exception when checking lead controller resource is enabled

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4736: Catch exception when checking lead controller resource is enabled
URL: https://github.com/apache/incubator-pinot/pull/4736#discussion_r337779279
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/LeadControllerManager.java
 ##########
 @@ -216,8 +216,6 @@ synchronized void onResourceConfigChange() {
       leadControllerResourceEnabled = LeadControllerUtils.isLeadControllerResourceEnabled(_helixManager);
     } catch (Exception e) {
       LOGGER.error("Exception when checking whether lead controller resource is enabled or not.", e);
-      _isLeadControllerResourceEnabled = false;
 
 Review comment:
   Does this mean that when we get ResourceConfigChanged notification, if zookeeper is disconnected, we will miss the notification altogether? Or, when we get reconnected, we will re-read the resource configs (we should do this).
   
   Otherwise, if we throw the exception, does helix call us back with the resource config again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org