You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Erik Huelsmann <eh...@gmail.com> on 2007/11/02 17:50:04 UTC
misc/win32/rand.c needs to include apr.h *before* windows.h
I thought I'd forward the APR bugreport in the PS in the message below
to the APR list (as the Subversion list won't be able to address the
issue).
Bye,
Erik.
---------- Forwarded message ----------
From: Stefan Küng <to...@gmail.com>
Date: Nov 2, 2007 4:53 PM
Subject: [PATCH] fix build with IPv6 support on Windows
To: dev@subversion.tigris.org
Hi,
On Windows, building Subversion with IPv6 support enabled currently
fails because two windows specific files don't include winsock2.h before
windows.h. The attached patch fixes this.
Stefan
P.S. There's also one change needed to the apr libraries (the file
misc/win32/rand.c needs to include "apr.h" *before* windows.h) to get
the build running. But once that include line is moved two lines up, it
works.
Re: misc/win32/rand.c needs to include apr.h *before* windows.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Stefan Küng wrote:
>
> Just checked: it's in fact fixed in trunk, but not in the latest release.
> But that still means I (and all other who try the same) have to patch
> the latest released version to get IPv6 compiled in. At least until the
> next release is out. :)
"latest" is 1.2.11
Re: misc/win32/rand.c needs to include apr.h *before* windows.h
Posted by Stefan Küng <to...@gmail.com>.
William A. Rowe, Jr. wrote:
> I'm not touching 0.9 if not absolutely necessary... and a 0.9 release isn't
> on the radar right now. Anything more specific?
>
> ...this has been fixed for some time in 1.2.
Just checked: it's in fact fixed in trunk, but not in the latest release.
But that still means I (and all other who try the same) have to patch
the latest released version to get IPv6 compiled in. At least until the
next release is out. :)
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Re: misc/win32/rand.c needs to include apr.h *before* windows.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Stefan Küng wrote:
> William A. Rowe, Jr. wrote:
>> http://svn.apache.org/viewvc?view=rev&revision=543297
>>
>> http://svn.apache.org/viewvc/apr/apr/tags/
>>
>> Both .10 and .11 superceeded 1.2.9, so yes, I consider it fixed for some
>> time :)
>
> Arghh! Damn sorting in web browser!
> I only saw 1.2.9 at the bottom of the list and thought that was the latest.
LOL - perhaps apr_strnatcmp() would be a nice feature for both svn server as
well as viewvc ;-) In any case thanks for the patch; yes it was a mess before.
Bill
Re: misc/win32/rand.c needs to include apr.h *before* windows.h
Posted by Stefan Küng <to...@gmail.com>.
William A. Rowe, Jr. wrote:
> http://svn.apache.org/viewvc?view=rev&revision=543297
>
> http://svn.apache.org/viewvc/apr/apr/tags/
>
> Both .10 and .11 superceeded 1.2.9, so yes, I consider it fixed for some
> time :)
Arghh! Damn sorting in web browser!
I only saw 1.2.9 at the bottom of the list and thought that was the latest.
Sorry for the noise.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Re: misc/win32/rand.c needs to include apr.h *before* windows.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
http://svn.apache.org/viewvc?view=rev&revision=543297
http://svn.apache.org/viewvc/apr/apr/tags/
Both .10 and .11 superceeded 1.2.9, so yes, I consider it fixed for some
time :)
Bill
Stefan Küng wrote:
> William A. Rowe, Jr. wrote:
>> I'm not touching 0.9 if not absolutely necessary... and a 0.9 release
>> isn't
>> on the radar right now. Anything more specific?
>>
>> ...this has been fixed for some time in 1.2.
>
> No, it hasn't. I'm using the 1.2.9 tag.
> It's just the file misc/win32/rand.c which doesn't compile with IPv6,
> all others are fine. Maybe it got lost when the other files were
> changed? Or maybe it's because the file is new in that version?
>
> Stefan
>
>>
>> Bill
>>
>> Erik Huelsmann wrote:
>>> I thought I'd forward the APR bugreport in the PS in the message below
>>> to the APR list (as the Subversion list won't be able to address the
>>> issue).
>>>
>>> Bye,
>>>
>>> Erik.
>>>
>>> ---------- Forwarded message ----------
>>> From: Stefan Küng <to...@gmail.com>
>>> Date: Nov 2, 2007 4:53 PM
>>> Subject: [PATCH] fix build with IPv6 support on Windows
>>> To: dev@subversion.tigris.org
>>>
>>>
>>> Hi,
>>>
>>> On Windows, building Subversion with IPv6 support enabled currently
>>> fails because two windows specific files don't include winsock2.h before
>>> windows.h. The attached patch fixes this.
>>>
>>> Stefan
>>>
>>> P.S. There's also one change needed to the apr libraries (the file
>>> misc/win32/rand.c needs to include "apr.h" *before* windows.h) to get
>>> the build running. But once that include line is moved two lines up, it
>>> works.
>>
>>
>
>
Re: misc/win32/rand.c needs to include apr.h *before* windows.h
Posted by Stefan Küng <to...@gmail.com>.
William A. Rowe, Jr. wrote:
> I'm not touching 0.9 if not absolutely necessary... and a 0.9 release isn't
> on the radar right now. Anything more specific?
>
> ...this has been fixed for some time in 1.2.
No, it hasn't. I'm using the 1.2.9 tag.
It's just the file misc/win32/rand.c which doesn't compile with IPv6,
all others are fine. Maybe it got lost when the other files were
changed? Or maybe it's because the file is new in that version?
Stefan
>
> Bill
>
> Erik Huelsmann wrote:
>> I thought I'd forward the APR bugreport in the PS in the message below
>> to the APR list (as the Subversion list won't be able to address the
>> issue).
>>
>> Bye,
>>
>> Erik.
>>
>> ---------- Forwarded message ----------
>> From: Stefan Küng <to...@gmail.com>
>> Date: Nov 2, 2007 4:53 PM
>> Subject: [PATCH] fix build with IPv6 support on Windows
>> To: dev@subversion.tigris.org
>>
>>
>> Hi,
>>
>> On Windows, building Subversion with IPv6 support enabled currently
>> fails because two windows specific files don't include winsock2.h before
>> windows.h. The attached patch fixes this.
>>
>> Stefan
>>
>> P.S. There's also one change needed to the apr libraries (the file
>> misc/win32/rand.c needs to include "apr.h" *before* windows.h) to get
>> the build running. But once that include line is moved two lines up, it
>> works.
>
>
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Re: misc/win32/rand.c needs to include apr.h *before* windows.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
I'm not touching 0.9 if not absolutely necessary... and a 0.9 release isn't
on the radar right now. Anything more specific?
...this has been fixed for some time in 1.2.
Bill
Erik Huelsmann wrote:
> I thought I'd forward the APR bugreport in the PS in the message below
> to the APR list (as the Subversion list won't be able to address the
> issue).
>
> Bye,
>
> Erik.
>
> ---------- Forwarded message ----------
> From: Stefan Küng <to...@gmail.com>
> Date: Nov 2, 2007 4:53 PM
> Subject: [PATCH] fix build with IPv6 support on Windows
> To: dev@subversion.tigris.org
>
>
> Hi,
>
> On Windows, building Subversion with IPv6 support enabled currently
> fails because two windows specific files don't include winsock2.h before
> windows.h. The attached patch fixes this.
>
> Stefan
>
> P.S. There's also one change needed to the apr libraries (the file
> misc/win32/rand.c needs to include "apr.h" *before* windows.h) to get
> the build running. But once that include line is moved two lines up, it
> works.