You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/14 18:15:40 UTC
[GitHub] [incubator-mxnet] samskalicky opened a new pull request #19668: Extensions naming macros fix
samskalicky opened a new pull request #19668:
URL: https://github.com/apache/incubator-mxnet/pull/19668
## Description ##
The macros used to define components in Extensions were not using the name given. This resulted in duplicate defined symbols when ops, partitioners, or graph passes are defined in separate files (ie. compilation units) since the counter is reset:
```
CMakeFiles/pass1.cc.o:(.bss+0x0): multiple definition of `MXNet_CustomPass_0'
CMakeFiles/pass2.cc.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
```
This PR fixes this by concatenating the given name of the component to the variable name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky merged pull request #19668: Extensions naming macros fix
Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19668:
URL: https://github.com/apache/incubator-mxnet/pull/19668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19668: Extensions naming macros fix
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19668:
URL: https://github.com/apache/incubator-mxnet/pull/19668#issuecomment-744619102
Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, website, edge, clang, centos-gpu, centos-cpu, miscellaneous, unix-cpu, sanity, windows-cpu, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org