You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/12/11 09:24:14 UTC
[PR] clean .rat-excludes [spark]
panbingkun opened a new pull request, #44293:
URL: https://github.com/apache/spark/pull/44293
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44293:
URL: https://github.com/apache/spark/pull/44293#discussion_r1436200013
##########
dev/.rat-excludes:
##########
@@ -4,8 +4,6 @@ cache
.gitattributes
.project
.classpath
-.mima-excludes
Review Comment:
After this PR https://github.com/apache/spark/commit/d17d221487fa7a3af6f4af2217f1d4889ceb084d#diff-4426a0b8653e706c81b0c25a5a71bc325114f86ed31e96097febe79ab0fadc33L108, the `.mima-excludes` file has become invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44293:
URL: https://github.com/apache/spark/pull/44293#discussion_r1436200250
##########
dev/.rat-excludes:
##########
@@ -4,8 +4,6 @@ cache
.gitattributes
.project
.classpath
-.mima-excludes
-.generated-mima-excludes
Review Comment:
After this PR https://github.com/apache/spark/commit/5b754b45f301a310e9232f3a5270201ebfc16076#diff-4426a0b8653e706c81b0c25a5a71bc325114f86ed31e96097febe79ab0fadc33L108, the `.generated-mima-excludes` file has become invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1851357727
Personally, I don't think it's unnecessary to clean them as they never bother me through development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1868387554
I agree with @yaooqinn .
To @panbingkun , could you elaborate a little more about this? I don't understand what you meant by this.
> To avoid misunderstandings caused by outdated items.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1869207055
> To @panbingkun , the above description should be in the PR description. Please add them into the PR description to be complete next time.
>
> In addition, this PR is wrong as @yaooqinn pointed out [#44293 (comment)](https://github.com/apache/spark/pull/44293#discussion_r1423455231) . Please recover the original file and remove the deleted items only like `SparkIMain.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44293:
URL: https://github.com/apache/spark/pull/44293#discussion_r1436200013
##########
dev/.rat-excludes:
##########
@@ -4,8 +4,6 @@ cache
.gitattributes
.project
.classpath
-.mima-excludes
Review Comment:
After this PR https://github.com/apache/spark/commit/d17d221487fa7a3af6f4af2217f1d4889ceb084d, the `.mima-excludes` file has become invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1869355931
Merged to master. Thank you, @panbingkun and @yaooqinn .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1869147941
To @panbingkun , the above description should be in the PR description. Please add them into the PR description to be complete next time.
In addition, this PR is wrong as @yaooqinn pointed out https://github.com/apache/spark/pull/44293#discussion_r1423455231 . Please recover the original file and remove the deleted items only like `SparkIMain.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1868643987
> I agree with @yaooqinn .
>
> To @panbingkun , could you elaborate a little more about this? I don't understand what you meant by this.
>
> > To avoid misunderstandings caused by outdated items.
1.Some items in the `.rat-excludes` file no longer exist in the Spark code repo, such as `SparkIMain.scala`. Perhaps one day in the future, we may add a file named `SparkIMain.scala` (a new file with the `same file name` as the old file, but with a different meaning) due to some requirements. However, we did not add the required "License" header for this file. According to the current mechanism, it should pass the `check-license`, but this check may not be our original intention.In addition.
2.The `.rat-excludes` file seems to be constantly `adding` entries without a mechanism for `removing` them, which is not healthy for the file itself.
The above is my personal opinion. If I understand it incorrectly, please correct me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1869178216
> To @panbingkun , the above description should be in the PR description. Please add them into the PR description to be complete next time.
>
> In addition, this PR is wrong as @yaooqinn pointed out [#44293 (comment)](https://github.com/apache/spark/pull/44293#discussion_r1423455231) . Please recover the original file and remove the deleted items only like `SparkIMain.scala`.
Okay, Let me update it 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #44293:
URL: https://github.com/apache/spark/pull/44293#discussion_r1423455231
##########
dev/.rat-excludes:
##########
@@ -48,32 +44,17 @@ jquery.mustache.js
pyspark-coverage-site/*
cloudpickle/*
join.py
-SparkExprTyper.scala
SparkILoop.scala
-SparkILoopInit.scala
-SparkIMain.scala
-SparkImports.scala
-SparkJLineCompletion.scala
-SparkJLineReader.scala
-SparkMemberHandlers.scala
-SparkReplReporter.scala
sbt
sbt-launch-lib.bash
plugins.sbt
-work
Review Comment:
This is for the Standalone worker daemon processes when we start a dev environment, we shall not clean it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44293: [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes`
URL: https://github.com/apache/spark/pull/44293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun closed pull request #44293: [SPARK-46371][BUILD] Clean up outdated items in `.rat-excludes`
URL: https://github.com/apache/spark/pull/44293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org