You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/04 06:57:38 UTC

[GitHub] [spark] wzhfy commented on a diff in pull request #37404: [SPARK-39866][SQL] Memory leak when closing a session of Spark ThriftServer

wzhfy commented on code in PR #37404:
URL: https://github.com/apache/spark/pull/37404#discussion_r937415355


##########
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala:
##########
@@ -169,6 +179,7 @@ class SessionResourceLoader(session: SparkSession) extends FunctionResourceLoade
    *
    * Note: this method seems not access any session state, but a Hive based `SessionState` needs
    * to add the jar to its hive client for the current session. Hence, it still needs to be in
+   * to add the jar to its hive client for the current session. Hence, it still needs to be in

Review Comment:
   duplicate comment, plz revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org