You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "SuzuyaXJZ (via GitHub)" <gi...@apache.org> on 2025/09/30 17:36:13 UTC
[PR] Update MSRV to 1.85 and bump edition to 2024 [opendal-reqsign]
SuzuyaXJZ opened a new pull request, #640:
URL: https://github.com/apache/opendal-reqsign/pull/640
This PR updates the project to use the Rust **2024** edition and sets the minimum supported Rust version (MSRV) to **1.85.**
No functional changes have been made.
**Changes:**
Update Rust edition to 2024 in Cargo.toml and rustfmt.toml.
Update MSRV to 1.85 in Cargo.toml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update MSRV to 1.85 and bump edition to 2024 [opendal-reqsign]
Posted by "SuzuyaXJZ (via GitHub)" <gi...@apache.org>.
SuzuyaXJZ commented on PR #640:
URL: https://github.com/apache/opendal-reqsign/pull/640#issuecomment-3356736293
> @SuzuyaXJZ Are you working on Windows? It looks like some automation changes all LF to CRLF.
>
> You may take a look at https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings.
Ah yes exactly, thank you for the tip !
I'll fix that later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update MSRV to 1.85 and bump edition to 2024 [opendal-reqsign]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #640:
URL: https://github.com/apache/opendal-reqsign/pull/640#issuecomment-3356601589
@SuzuyaXJZ Are you working on Windows? It looks like some automation changes all LF to CRLF.
You may take a look at https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update MSRV to 1.85 and bump edition to 2024 [opendal-reqsign]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #640:
URL: https://github.com/apache/opendal-reqsign/pull/640#discussion_r2394890464
##########
rust-toolchain.toml:
##########
@@ -16,5 +16,5 @@
# under the License.
[toolchain]
-channel = "stable"
+channel = "1.85.0"
Review Comment:
Please don't change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update MSRV to 1.85 and bump edition to 2024 [opendal-reqsign]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #640:
URL: https://github.com/apache/opendal-reqsign/pull/640#issuecomment-3353301088
Hi, it looks like you have changes every line of this project. Is there something wrong on your side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update MSRV to 1.85 and bump edition to 2024 [opendal-reqsign]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed pull request #640: Update MSRV to 1.85 and bump edition to 2024
URL: https://github.com/apache/opendal-reqsign/pull/640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update MSRV to 1.85 and bump edition to 2024 [opendal-reqsign]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #640:
URL: https://github.com/apache/opendal-reqsign/pull/640#issuecomment-3356822470
I'm handling the metadata issue now. So perhaps hold on this PR. I'll add @SuzuyaXJZ as a co-author if the changeset is overlapped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update MSRV to 1.85 and bump edition to 2024 [opendal-reqsign]
Posted by "SuzuyaXJZ (via GitHub)" <gi...@apache.org>.
SuzuyaXJZ commented on PR #640:
URL: https://github.com/apache/opendal-reqsign/pull/640#issuecomment-3353358821
> Hi, it looks like you have changes every line of this project. Is there something wrong on your side?
Hi, I didn't change anything besides the edition and the MSRV. I did put 2 unsafe functions in an unsafe block thought but I doubt that it has caused all those lines to change.
Maybe it's because I used cargo fmt (but I can't verify it for now...)
Sorry, that's my first contribution so I'm not very familiar with Github
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org