You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by ma...@apache.org on 2010/09/03 18:27:26 UTC

svn commit: r992359 - in /jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic: InstructionFactory.java Type.java

Author: markt
Date: Fri Sep  3 16:27:26 2010
New Revision: 992359

URL: http://svn.apache.org/viewvc?rev=992359&view=rev
Log:
Code clean-up. No functional change.
Remove unused code identified by Eclipse.

Modified:
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java?rev=992359&r1=992358&r2=992359&view=diff
==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java Fri Sep  3 16:27:26 2010
@@ -139,15 +139,13 @@ public class InstructionFactory implemen
         Type result_type;
         String class_name;
         String name;
-        int access;
 
 
-        MethodObject(String c, String n, Type r, Type[] a, int acc) {
+        MethodObject(String c, String n, Type r, Type[] a) {
             class_name = c;
             name = n;
             result_type = r;
             arg_types = a;
-            access = acc;
         }
     }
 
@@ -159,38 +157,38 @@ public class InstructionFactory implemen
     private static final MethodObject[] append_mos = {
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, new Type[] {
                 Type.STRING
-            }, Constants.ACC_PUBLIC),
+            }),
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, new Type[] {
                 Type.OBJECT
-            }, Constants.ACC_PUBLIC),
+            }),
             null,
             null, // indices 2, 3
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, new Type[] {
                 Type.BOOLEAN
-            }, Constants.ACC_PUBLIC),
+            }),
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, new Type[] {
                 Type.CHAR
-            }, Constants.ACC_PUBLIC),
+            }),
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, new Type[] {
                 Type.FLOAT
-            }, Constants.ACC_PUBLIC),
+            }),
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, new Type[] {
                 Type.DOUBLE
-            }, Constants.ACC_PUBLIC),
+            }),
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, new Type[] {
                 Type.INT
-            }, Constants.ACC_PUBLIC),
+            }),
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, // No append(byte)
                     new Type[] {
                         Type.INT
-                    }, Constants.ACC_PUBLIC),
+                    }),
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, // No append(short)
                     new Type[] {
                         Type.INT
-                    }, Constants.ACC_PUBLIC),
+                    }),
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, new Type[] {
                 Type.LONG
-            }, Constants.ACC_PUBLIC)
+            })
     };
 
 

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java?rev=992359&r1=992358&r2=992359&view=diff
==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java Fri Sep  3 16:27:26 2010
@@ -330,7 +330,6 @@ public abstract class Type implements ja
     static int getArgumentTypesSize( String signature ) {
         int res = 0;
         int index;
-        Type[] types;
         try { // Read all declarations between for `(' and `)'
             if (signature.charAt(0) != '(') {
                 throw new ClassFormatException("Invalid method signature: " + signature);



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org