You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/25 19:31:33 UTC

[GitHub] [pulsar] lhotari opened a new pull request #11778: [Tests] Fix BaseMetadataStoreTest retries

lhotari opened a new pull request #11778:
URL: https://github.com/apache/pulsar/pull/11778


   ### Motivation
   
   - A `Supplier<String>` must be used for the Zookeeper connection string parameters passed in a TestNG `DataProvider`.
   
   - The retried test run will use the same arguments as the failed attempt.  The Zookeeper test server gets restarted by TestRetrySupport before a retry. The new connection string won't be available to the test method unless a `Supplier<String>` lambda is used for providing the value.
   
   ### Modifications
   
   - Change String -> Supplier<String> for the `zks.getConnectionString()` argument (becomes `() -> zks.getConnectionString()`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat merged pull request #11778: [Tests] Fix BaseMetadataStoreTest retries

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #11778:
URL: https://github.com/apache/pulsar/pull/11778


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org