You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "cygnusdark (via GitHub)" <gi...@apache.org> on 2023/05/05 05:27:06 UTC
[GitHub] [incubator-streampark] cygnusdark opened a new pull request, #2725: [Bugfix]Upgrade commons cli version to resolve compati
cygnusdark opened a new pull request, #2725:
URL: https://github.com/apache/incubator-streampark/pull/2725
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (yes / no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2725: [Bugfix]Bump commons-cli version to resolve compatibility problem under flink 1.17
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2725:
URL: https://github.com/apache/incubator-streampark/pull/2725#issuecomment-1687405844
Recently, Some Streampark users have also encountered this issue. After my investigation, I found out that it is not simply caused by dependency conflicts. These few days, I will verify this issue and test current pull request. If it works ok, I am very willing to merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2725: [Bugfix]Upgrade commons cli version to resolve compatibility problem under flink 1.17
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2725:
URL: https://github.com/apache/incubator-streampark/pull/2725#issuecomment-1541350495
> Hi @cygnusdark , Thanks for your contribution. We tested what's you report and cannot reproduce this issue. Actually, StreamPark uses proxy classloader to submit flink job, whick means the classes are loaded from `$FLINK_HOME/lib`, It's highly possible that some dependency in your `$FLINK_HOME/lib` conflict with flink-dist.
>
> Though we cannot reproduce this problem, this pr that bumps commons-cli version to 1.5.0 looks good to me.
We can expand the scope of testing, for example from Flink 1.12 to 1.17, to further verify compatibility. If the tests pass, I would be happy to merge this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhoulii commented on pull request #2725: [Bugfix]Upgrade commons cli version to resolve compatibility problem under flink 1.17
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on PR #2725:
URL: https://github.com/apache/incubator-streampark/pull/2725#issuecomment-1539327009
Hi @cygnusdark , Thanks for your contribution. We tested what's you report and cannot reproduce this issue. Actually, StreamPark uses proxy classloader to submit flink job, whick means the classes are loaded from `$FLINK_HOME/lib`, It's highly possible that some dependency in your `$FLINK_HOME/lib` conflict with flink-dist.
Though we cannot reproduce this problem, this pr that bumps commons-cli version to 1.5.0 looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2725: [Bugfix]Bump commons-cli version to resolve compatibility problem under flink 1.17
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2725:
URL: https://github.com/apache/incubator-streampark/pull/2725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] cygnusdark commented on pull request #2725: [Bugfix]Bump commons-cli version to resolve compatibility problem under flink 1.17
Posted by "cygnusdark (via GitHub)" <gi...@apache.org>.
cygnusdark commented on PR #2725:
URL: https://github.com/apache/incubator-streampark/pull/2725#issuecomment-1542063731
@wolfboys Thank you for your support😊. I am still looking into the possible dependency conflict @zhoulii mentioned. The solution that bumping the commons-cli version has already fixed my problem. If I find the root cause later, I will share here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] cygnusdark commented on pull request #2725: [Bugfix]Bump commons-cli version to resolve compatibility problem under flink 1.17
Posted by "cygnusdark (via GitHub)" <gi...@apache.org>.
cygnusdark commented on PR #2725:
URL: https://github.com/apache/incubator-streampark/pull/2725#issuecomment-1687367031
Recently, another streampark user report same error：[Bug] NoSuchMethodError when starting job #2803.
I think this problem happens when users use hadoop 2.x jars, as this article mentioned: https://stackoverflow.com/questions/38654957/hadoop-nosuchmethoderror-apache-commons-cli
Compared with modifying hadoop jar, this pr is a easier way for some users. @wolfboys Could you help merge this pr？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org