[jira] [Commented] (OAK-3372) Collapsing external events in BackgroundObserver even before queue is full leads to JournalEntry not getting used

["Vikas Saurabh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988408#comment-14988408 ] 

Vikas Saurabh commented on OAK-3372:
------------------------------------

[~mduerig], I'd update this issue with a test from oak bundles after this fix - but that might take time. We had a test with the simplistic patch I mentioned earlier (the version with no config and hence some removed code) and that did work fine. I think it's fine to resolve this issue. I'd open a new one if something still remains amiss.

> Collapsing external events in BackgroundObserver even before queue is full leads to JournalEntry not getting used
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-3372
>                 URL: https://issues.apache.org/jira/browse/OAK-3372
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.5
>            Reporter: Vikas Saurabh
>            Assignee: Michael Dürig
>              Labels: resilience
>         Attachments: OAK-3372.patch
>
>
> BackgroundObserver currently merges external events if the last one in queue is also an external event. This leads to diff being done for a revision pair which is different from the ones pushed actively into cache during backgroud read (using JournalEntry) i.e. diff queries for {{diff("/a/b", rA, rC)}} while background read had pushed results of {{diff("/a/b", rA, rB)}} and {{diff("/a/b", rB, rC)}}.
> (cc [~mreutegg], [~egli], [~chetanm], [~mduerig])



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)