You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/30 10:48:41 UTC
[GitHub] [shardingsphere] taojintianxia opened a new pull request, #23203: Refactor agent shade plugin usage
taojintianxia opened a new pull request, #23203:
URL: https://github.com/apache/shardingsphere/pull/23203
Fixes #23178 .
Changes proposed in this pull request:
- refactor the agent shade plugin usage
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #23203: Refactor agent shade plugin usage
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #23203:
URL: https://github.com/apache/shardingsphere/pull/23203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23203: Refactor agent shade plugin usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23203:
URL: https://github.com/apache/shardingsphere/pull/23203#issuecomment-1367869329
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23203](https://codecov.io/gh/apache/shardingsphere/pull/23203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9abea1) into [master](https://codecov.io/gh/apache/shardingsphere/commit/cd9bbd1b79fe05b2a0c68627781817eda4edd854?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd9bbd1) will **decrease** coverage by `0.07%`.
> The diff coverage is `28.57%`.
```diff
@@ Coverage Diff @@
## master #23203 +/- ##
============================================
- Coverage 49.80% 49.73% -0.08%
+ Complexity 2442 2441 -1
============================================
Files 4013 4017 +4
Lines 57408 57461 +53
Branches 9111 9117 +6
============================================
- Hits 28592 28576 -16
- Misses 26273 26351 +78
+ Partials 2543 2534 -9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...shardingsphere/agent/core/ShardingSphereAgent.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9TaGFyZGluZ1NwaGVyZUFnZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...phere/agent/core/classloader/AgentClassLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jbGFzc2xvYWRlci9BZ2VudENsYXNzTG9hZGVyLmphdmE=) | `10.86% <ø> (ø)` | |
| [...ere/agent/core/classloader/ClassLoaderContext.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jbGFzc2xvYWRlci9DbGFzc0xvYWRlckNvbnRleHQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../core/config/loader/PluginConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvbG9hZGVyL1BsdWdpbkNvbmZpZ3VyYXRpb25Mb2FkZXIuamF2YQ==) | `88.88% <ø> (ø)` | |
| [...g/yaml/entity/YamlPluginCategoryConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbnRpdHkvWWFtbFBsdWdpbkNhdGVnb3J5Q29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [...re/config/yaml/entity/YamlPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbnRpdHkvWWFtbFBsdWdpbkNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | |
| [...e/config/yaml/entity/YamlPluginsConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbnRpdHkvWWFtbFBsdWdpbnNDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../yaml/swapper/YamlPluginsConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9zd2FwcGVyL1lhbWxQbHVnaW5zQ29uZmlndXJhdGlvblN3YXBwZXIuamF2YQ==) | `85.71% <ø> (ø)` | |
| [...ardingsphere/agent/core/logging/LoggerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9sb2dnaW5nL0xvZ2dlckZhY3RvcnkuamF2YQ==) | `47.50% <ø> (ø)` | |
| [...dingsphere/agent/core/logging/LoggingListener.java](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9sb2dnaW5nL0xvZ2dpbmdMaXN0ZW5lci5qYXZh) | `77.77% <ø> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/shardingsphere/pull/23203/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org