[GitHub] [incubator-doris] imay commented on a change in pull request #2658: [AlphaRowset] set num_segments field in rowset meta if missing

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2658: [AlphaRowset] set num_segments field in rowset meta if missing
URL: https://github.com/apache/incubator-doris/pull/2658#discussion_r363033949
 
 

 ##########
 File path: be/src/olap/rowset/rowset_meta.h
 ##########
 @@ -326,11 +326,12 @@ class RowsetMeta {
     //    so the segments in it are non overlapping.
     // 2. the segments_overlap() flag in rowset meta is set to NONOVERLAPPING, explicitly.
     bool is_segments_overlapping() const {
-        if (num_segments() == 0) {
-            // specially for delete version
+        if (end_version() > start_version() || segments_overlap() == NONOVERLAPPING) {
             return false;
         }
-        if (end_version() > start_version() || segments_overlap() == NONOVERLAPPING) {
+
+        // some of cumulative rowsets may have no segments.(no data, or a delete version)
 
 Review comment:
   I think the cumulative rowsets will hit above if clause. So this comment is some misleading.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org