[jira] [Commented] (HELIX-121) Possible race condition in ZkHelixManager.disconnect() during zk session expiry

["kishore gopalakrishna (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HELIX-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677211#comment-13677211 ] 

kishore gopalakrishna commented on HELIX-121:
---------------------------------------------

Hi Jason,

Was this the root cause for issues we encountered in seas cluster or was the order in which we can reset and cancel.


                
> Possible race condition in ZkHelixManager.disconnect() during zk session expiry
> -------------------------------------------------------------------------------
>
>                 Key: HELIX-121
>                 URL: https://issues.apache.org/jira/browse/HELIX-121
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: dafu
>
> There is race condition in ZkHelixManager.disconnect() during zk session expiry. If someone calls ZkHelixManager.disconnect() when zk session expiry happens, the real shutdown work may be skipped:
> public void disconnect()
>   {
>     if (!isConnected())
>     {
>       logger.error("ClusterManager " + _instanceName + " already disconnected");
>       return;
>     }
>     disconnectInternal();
>   }
> And when zk connection comes back again, the zk manager instance will come alive again even though the instance might be considered dead already.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira