You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by evancarter-iex <gi...@git.apache.org> on 2017/09/08 13:06:39 UTC

[GitHub] libcloud pull request #1108: BUGFIX GCE: Allow the setting of service accoun...

GitHub user evancarter-iex opened a pull request:

    https://github.com/apache/libcloud/pull/1108

    BUGFIX GCE: Allow the setting of service account in instance templates

    ## BUGFIX: GCE Allow the setting of service account in instance templates and instance properties
    
    ### Description
    Currently, there is no way for the service account for an instance template to be set, despite that information being passed in. This fixes that problem.
    
    ### Status
    
    Done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [X ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/evancarter-iex/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1108
    
----
commit 91ba2d0bedfb5e46f3713f144455b1579c5ffd8f
Author: Evan Carter <ev...@iextrading.com>
Date:   2017-09-08T12:54:18Z

    BUGFIX: GCE Allow the setting of service account in instance templates/instance properties

----


---

[GitHub] libcloud pull request #1108: BUGFIX GCE: Allow the setting of service accoun...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1108


---