You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/03/07 15:43:30 UTC
Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/
-----------------------------------------------------------
Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
Bugs: HIVE-4570
https://issues.apache.org/jira/browse/HIVE-4570
Repository: hive-git
Description
-------
Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
This issue is to give more information to the user such as progress and running job handles, if possible.
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 32531465cba95de6caa1bd292d489c1582efb942
ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e554cf3f7a61932195b9b840cf13f3594b
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
serde/if/serde.thrift 0b3804deadaa327ab22c9cffef762f1b862200e2
serde/src/gen/thrift/gen-cpp/serde_constants.h 6d859284296d108b0dbd6e9fb7bad53f3ce6c913
serde/src/gen/thrift/gen-cpp/serde_constants.cpp 75701e2a3db9394c13ef73fc48d3b2e8488d68b4
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java 04ed8f556be0cf28f89b0ccd005816a2fb01a555
serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 0bc6dd7e01280f27750a4ceaa37f8fb9ecfb914a
serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 7939791ed30d5035a84bbfd0af848de9a624926e
serde/src/gen/thrift/gen-rb/serde_constants.rb d09e3c238a747d9f5f81118f633968baa16589e7
service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
service/src/gen/thrift/gen-cpp/hive_service_constants.h PRE-CREATION
service/src/gen/thrift/gen-cpp/hive_service_constants.cpp PRE-CREATION
service/src/gen/thrift/gen-cpp/hive_service_types.h PRE-CREATION
service/src/gen/thrift/gen-cpp/hive_service_types.cpp PRE-CREATION
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java PRE-CREATION
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java PRE-CREATION
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/JobTrackerState.java PRE-CREATION
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java PRE-CREATION
service/src/gen/thrift/gen-php/ThriftHive.php PRE-CREATION
service/src/gen/thrift/gen-php/Types.php PRE-CREATION
service/src/gen/thrift/gen-py/__init__.py PRE-CREATION
service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote PRE-CREATION
service/src/gen/thrift/gen-py/hive_service/ThriftHive.py PRE-CREATION
service/src/gen/thrift/gen-py/hive_service/__init__.py PRE-CREATION
service/src/gen/thrift/gen-py/hive_service/constants.py PRE-CREATION
service/src/gen/thrift/gen-py/hive_service/ttypes.py PRE-CREATION
service/src/gen/thrift/gen-rb/hive_service_constants.rb PRE-CREATION
service/src/gen/thrift/gen-rb/hive_service_types.rb PRE-CREATION
service/src/gen/thrift/gen-rb/thrift_hive.rb PRE-CREATION
service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
Diff: https://reviews.apache.org/r/44453/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 8, 2016, 10:43 a.m., Amareshwari Sriramadasu wrote:
> > Seems there are merge issues, its showing unnecessary changes. Also, please avoid posting generated thrift files for review, as it becomes hard to review.
Yes, too much noise. Removed. Only keeping java generated class now.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122476
-----------------------------------------------------------
On March 8, 2016, 1:03 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 1:03 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 32531465cba95de6caa1bd292d489c1582efb942
> ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e554cf3f7a61932195b9b840cf13f3594b
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122476
-----------------------------------------------------------
Seems there are merge issues, its showing unnecessary changes. Also, please avoid posting generated thrift files for review, as it becomes hard to review.
- Amareshwari Sriramadasu
On March 7, 2016, 2:43 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 2:43 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 32531465cba95de6caa1bd292d489c1582efb942
> ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e554cf3f7a61932195b9b840cf13f3594b
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> serde/if/serde.thrift 0b3804deadaa327ab22c9cffef762f1b862200e2
> serde/src/gen/thrift/gen-cpp/serde_constants.h 6d859284296d108b0dbd6e9fb7bad53f3ce6c913
> serde/src/gen/thrift/gen-cpp/serde_constants.cpp 75701e2a3db9394c13ef73fc48d3b2e8488d68b4
> serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java 04ed8f556be0cf28f89b0ccd005816a2fb01a555
> serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 0bc6dd7e01280f27750a4ceaa37f8fb9ecfb914a
> serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 7939791ed30d5035a84bbfd0af848de9a624926e
> serde/src/gen/thrift/gen-rb/serde_constants.rb d09e3c238a747d9f5f81118f633968baa16589e7
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
> service/src/gen/thrift/gen-cpp/hive_service_constants.h PRE-CREATION
> service/src/gen/thrift/gen-cpp/hive_service_constants.cpp PRE-CREATION
> service/src/gen/thrift/gen-cpp/hive_service_types.h PRE-CREATION
> service/src/gen/thrift/gen-cpp/hive_service_types.cpp PRE-CREATION
> service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java PRE-CREATION
> service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java PRE-CREATION
> service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/JobTrackerState.java PRE-CREATION
> service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java PRE-CREATION
> service/src/gen/thrift/gen-php/ThriftHive.php PRE-CREATION
> service/src/gen/thrift/gen-php/Types.php PRE-CREATION
> service/src/gen/thrift/gen-py/__init__.py PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/ThriftHive.py PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/__init__.py PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/constants.py PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/ttypes.py PRE-CREATION
> service/src/gen/thrift/gen-rb/hive_service_constants.rb PRE-CREATION
> service/src/gen/thrift/gen-rb/hive_service_types.rb PRE-CREATION
> service/src/gen/thrift/gen-rb/thrift_hive.rb PRE-CREATION
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 8, 2016, 3:36 a.m., Szehon Ho wrote:
> > Thanks for fixing those earlier items.
> >
> > I am still worried that getOperationStatus will be called by another thrift thread at any time. Don't we need to synchronize/protect all the fields that it accesses, like the OperationStatus, TaskStatus, etc, and all their fields?
> >
> > But now one problem right is that driver will nullify the plan after it runs, and thus there will be periods of time when you can see the task and then afterwards you will get nothing. It seems like it will not be great behavior.
> >
> > Again, combining with QueryDisplay (enhancing Task class to hook up a TaskDisplay immediately on QueryDisplay, everytime Task.setXXX is called) will solve these issues. It can be worth considering, as I still believe the logic is similar and the problems (the two I mentioned above) are the same. Thanks.
I'm working on the TaskDisplay idea, but there will *not* be a period of time when you stop seeing the task after seeing it once. I'm caching the root tasks in the driver. So when plan is nulified, root tasks are picked from the plan and cached with the driver.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122382
-----------------------------------------------------------
On March 8, 2016, 1:03 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 1:03 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 32531465cba95de6caa1bd292d489c1582efb942
> ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e554cf3f7a61932195b9b840cf13f3594b
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 8, 2016, 3:36 a.m., Szehon Ho wrote:
> > serde/if/serde.thrift, line 33
> > <https://reviews.apache.org/r/44453/diff/1/?file=1282939#file1282939line33>
> >
> > Is this part of the change?
Refer https://issues.apache.org/jira/browse/HIVE-12994?focusedCommentId=15183059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15183059
Please ignore it in my review request, since it's already getting fixed elsewhere.
> On March 8, 2016, 3:36 a.m., Szehon Ho wrote:
> > service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java, line 1
> > <https://reviews.apache.org/r/44453/diff/1/?file=1282957#file1282957line1>
> >
> > I dont see where this thrift class is defined or used? Same for JobTrackerState, ThriftHive, etc..
I think in master thrift files have changes without corresponding changes reflecting in generated files. Removed for now.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122382
-----------------------------------------------------------
On March 8, 2016, 1:03 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 1:03 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 32531465cba95de6caa1bd292d489c1582efb942
> ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e554cf3f7a61932195b9b840cf13f3594b
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 8, 2016, 3:36 a.m., Szehon Ho wrote:
> > Thanks for fixing those earlier items.
> >
> > I am still worried that getOperationStatus will be called by another thrift thread at any time. Don't we need to synchronize/protect all the fields that it accesses, like the OperationStatus, TaskStatus, etc, and all their fields?
> >
> > But now one problem right is that driver will nullify the plan after it runs, and thus there will be periods of time when you can see the task and then afterwards you will get nothing. It seems like it will not be great behavior.
> >
> > Again, combining with QueryDisplay (enhancing Task class to hook up a TaskDisplay immediately on QueryDisplay, everytime Task.setXXX is called) will solve these issues. It can be worth considering, as I still believe the logic is similar and the problems (the two I mentioned above) are the same. Thanks.
>
> Rajat Khandelwal wrote:
> I'm working on the TaskDisplay idea, but there will *not* be a period of time when you stop seeing the task after seeing it once. I'm caching the root tasks in the driver. So when plan is nulified, root tasks are picked from the plan and cached with the driver.
Hi
As per your suggestion, I've enhanced the TaskInfo class (it's TaskDisplay now). And you were right, it does give extra info in the operation status :). Please look at the changes and review.
Getting the following in test cases:
task statuses: [{"taskId":"Stage-0","taskState":"INITIALIZED","taskType":"FETCH","name":"FETCH"},{"beginTime":1457533768220,"endTime":1457533771077,"taskId":"Stage-1","taskState":"FINISHED","taskType":"MAPRED","name":"MAPRED","elapsedTime":2857}]
Which seems to be good enough.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122382
-----------------------------------------------------------
On March 9, 2016, 8:33 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 8:33 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
> ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
> ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122382
-----------------------------------------------------------
Thanks for fixing those earlier items.
I am still worried that getOperationStatus will be called by another thrift thread at any time. Don't we need to synchronize/protect all the fields that it accesses, like the OperationStatus, TaskStatus, etc, and all their fields?
But now one problem right is that driver will nullify the plan after it runs, and thus there will be periods of time when you can see the task and then afterwards you will get nothing. It seems like it will not be great behavior.
Again, combining with QueryDisplay (enhancing Task class to hook up a TaskDisplay immediately on QueryDisplay, everytime Task.setXXX is called) will solve these issues. It can be worth considering, as I still believe the logic is similar and the problems (the two I mentioned above) are the same. Thanks.
serde/if/serde.thrift (line 33)
<https://reviews.apache.org/r/44453/#comment184347>
Is this part of the change?
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java (line 1)
<https://reviews.apache.org/r/44453/#comment184353>
I dont see where this thrift class is defined or used? Same for JobTrackerState, ThriftHive, etc..
- Szehon Ho
On March 7, 2016, 2:43 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 2:43 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 32531465cba95de6caa1bd292d489c1582efb942
> ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e554cf3f7a61932195b9b840cf13f3594b
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> serde/if/serde.thrift 0b3804deadaa327ab22c9cffef762f1b862200e2
> serde/src/gen/thrift/gen-cpp/serde_constants.h 6d859284296d108b0dbd6e9fb7bad53f3ce6c913
> serde/src/gen/thrift/gen-cpp/serde_constants.cpp 75701e2a3db9394c13ef73fc48d3b2e8488d68b4
> serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java 04ed8f556be0cf28f89b0ccd005816a2fb01a555
> serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 0bc6dd7e01280f27750a4ceaa37f8fb9ecfb914a
> serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 7939791ed30d5035a84bbfd0af848de9a624926e
> serde/src/gen/thrift/gen-rb/serde_constants.rb d09e3c238a747d9f5f81118f633968baa16589e7
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
> service/src/gen/thrift/gen-cpp/hive_service_constants.h PRE-CREATION
> service/src/gen/thrift/gen-cpp/hive_service_constants.cpp PRE-CREATION
> service/src/gen/thrift/gen-cpp/hive_service_types.h PRE-CREATION
> service/src/gen/thrift/gen-cpp/hive_service_types.cpp PRE-CREATION
> service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java PRE-CREATION
> service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java PRE-CREATION
> service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/JobTrackerState.java PRE-CREATION
> service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java PRE-CREATION
> service/src/gen/thrift/gen-php/ThriftHive.php PRE-CREATION
> service/src/gen/thrift/gen-php/Types.php PRE-CREATION
> service/src/gen/thrift/gen-py/__init__.py PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/ThriftHive.py PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/__init__.py PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/constants.py PRE-CREATION
> service/src/gen/thrift/gen-py/hive_service/ttypes.py PRE-CREATION
> service/src/gen/thrift/gen-rb/hive_service_constants.rb PRE-CREATION
> service/src/gen/thrift/gen-rb/hive_service_types.rb PRE-CREATION
> service/src/gen/thrift/gen-rb/thrift_hive.rb PRE-CREATION
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122853
-----------------------------------------------------------
Ship it!
Yes you were right that in the original patch, rootTasks was cached, so there wouldn't be a period of time of empty tasks, I missed seeing that.
Thanks a lot for considering the suggestion and reducing duplication in the code. Patch looks great to me.
- Szehon Ho
On March 9, 2016, 3:03 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 3:03 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
> ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
> ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review123095
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 10, 2016, 7:55 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 7:55 a.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
> ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
> ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
> service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/
-----------------------------------------------------------
(Updated March 13, 2016, 12:41 p.m.)
Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
Bugs: HIVE-4570
https://issues.apache.org/jira/browse/HIVE-4570
Repository: hive-git
Description
-------
Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
This issue is to give more information to the user such as progress and running job handles, if possible.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
Diff: https://reviews.apache.org/r/44453/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/
-----------------------------------------------------------
(Updated March 11, 2016, 11:47 a.m.)
Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
Bugs: HIVE-4570
https://issues.apache.org/jira/browse/HIVE-4570
Repository: hive-git
Description
-------
Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
This issue is to give more information to the user such as progress and running job handles, if possible.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
Diff: https://reviews.apache.org/r/44453/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/
-----------------------------------------------------------
(Updated March 11, 2016, 11:43 a.m.)
Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
Bugs: HIVE-4570
https://issues.apache.org/jira/browse/HIVE-4570
Repository: hive-git
Description
-------
Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
This issue is to give more information to the user such as progress and running job handles, if possible.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
Diff: https://reviews.apache.org/r/44453/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122877
-----------------------------------------------------------
- Amareshwari Sriramadasu
On March 10, 2016, 7:55 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 7:55 a.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
> ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
> ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
> service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/
-----------------------------------------------------------
(Updated March 10, 2016, 1:25 p.m.)
Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
Bugs: HIVE-4570
https://issues.apache.org/jira/browse/HIVE-4570
Repository: hive-git
Description
-------
Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
This issue is to give more information to the user such as progress and running job handles, if possible.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
Diff: https://reviews.apache.org/r/44453/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 10, 2016, 10:12 a.m., Amareshwari Sriramadasu wrote:
> > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java, line 682
> > <https://reviews.apache.org/r/44453/diff/3/?file=1293304#file1293304line682>
> >
> > Is set on start and completion times not required?
Seems missed. Will update.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122876
-----------------------------------------------------------
On March 10, 2016, 1:25 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 1:25 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
> ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
> ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
> service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122876
-----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java (line 682)
<https://reviews.apache.org/r/44453/#comment184963>
Is set on start and completion times not required?
- Amareshwari Sriramadasu
On March 9, 2016, 3:03 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 3:03 p.m.)
>
>
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
>
>
> Bugs: HIVE-4570
> https://issues.apache.org/jira/browse/HIVE-4570
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
>
> This issue is to give more information to the user such as progress and running job handles, if possible.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
> ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
> ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
> ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
> service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
> service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
> service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
> service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
>
> Diff: https://reviews.apache.org/r/44453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/
-----------------------------------------------------------
(Updated March 9, 2016, 8:33 p.m.)
Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
Bugs: HIVE-4570
https://issues.apache.org/jira/browse/HIVE-4570
Repository: hive-git
Description
-------
Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
This issue is to give more information to the user such as progress and running job handles, if possible.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
Diff: https://reviews.apache.org/r/44453/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44453: HIVE-4570: More information to user on
GetOperationStatus in Hive Server2 when query is still executing
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/
-----------------------------------------------------------
(Updated March 8, 2016, 1:03 p.m.)
Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
Changes
-------
Updated to remove changes in generated files
Bugs: HIVE-4570
https://issues.apache.org/jira/browse/HIVE-4570
Repository: hive-git
Description
-------
Currently in Hive Server2, when the query is still executing only the status is set as STILL_EXECUTING.
This issue is to give more information to the user such as progress and running job handles, if possible.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 32531465cba95de6caa1bd292d489c1582efb942
ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e554cf3f7a61932195b9b840cf13f3594b
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
Diff: https://reviews.apache.org/r/44453/diff/
Testing
-------
Thanks,
Rajat Khandelwal