You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Hzfengsy (via GitHub)" <gi...@apache.org> on 2023/03/07 08:14:27 UTC

[GitHub] [tvm] Hzfengsy commented on a diff in pull request #14221: [Unity][Transform] SimplifyNormInference

Hzfengsy commented on code in PR #14221:
URL: https://github.com/apache/tvm/pull/14221#discussion_r1127499017


##########
src/relax/transform/utils.h:
##########
@@ -116,6 +134,123 @@ IRModule MakeGroupedFunctions(
     const std::unordered_map<const Object*, relay::GraphPartitioner::Group*>& partition,
     bool lift_constants = true);
 
+/*!
+ * \brief Check if the given StructInfo is a scalar tensor. The sinfo should be an instance of
+ * TensorStructInfo; its shape must be ShapeExpr.
+ * \param sinfo The StructInfo to be checked.
+ * \return true if the given StructInfo is a scalar tensor.
+ */
+bool IsScalarTensor(const StructInfo& sinfo);

Review Comment:
   Looks like some functions are not used and no implemtation in cc files. Please remove them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org