RE: Attn: Windows Devs -- Need to add missing sqlite build options for Windows (issue #3364)

[Bert Huijben <rh...@sharpsvn.net>]

> -----Original Message-----
> From: chemodax@gmail.com [mailto:chemodax@gmail.com] On Behalf Of Ivan
Zhakov
> Sent: woensdag 18 februari 2009 14:43
> To: Paul Burba
> Cc: dev@subversion.tigris.org
> Subject: Re: Attn: Windows Devs -- Need to add missing sqlite build
options
> for Windows (issue #3364)
> 
> On Thu, Jan 29, 2009 at 7:19 AM, Paul Burba <pt...@gmail.com> wrote:
> > Right now when building trunk on Windows you have one option when it
> > comes to sqlite: Use the --with-sqlite option to gen-make.py to point
> > to a directory with this structure and contents:
> >
> >  inc/
> >  inc/sqlite3.h
> >  lib/
> >  lib/sqlite3.lib
> >
> > So basically, if you haven't built sqlite on your own already then
> > Subversion won't build.  It seems to me we should support sqlite build
> > options analogous to those on *nix, e.g. just drop the amalgamation
> > files in .\sqlite-amalgamation and it gets built.
> >
> Hi Paul,
> 
> Thanks for noting that. I've looked to current sqlite build stuff on
> Windows. It still does not support sqlite-amalgamation.
> 
> So I propose to implement only amalgamation option for sqlite, without
> supporting to use "installed" version of library. Since there is no
> term of installed libraries on Windows. I do not see benefits of using
> sqlite compiled out of source tree on Windows. It can be only source
> of problems if different compiler or compiler options will be used.
> 
> I volunteer to implement support for sqlite amalgamation on Windows,
> if no one object to drop other sqlite build option on Windows.

Is it a problem to just keep the current build option?
(+1 on making the amalgamation default on Windows)

The amalgamation build makes it impossible to re-use Sqlite from
applications that use both Subversion and Sqlite (Requiring them to link to
two separate copies).

The current method works for at least my automated build and TortoiseSVN's,
so why break it?

	Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186812