You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2025/03/15 04:06:15 UTC
[I] Factor out common CMake invocations into functions [arrow-nanoarrow]
paleolimbot opened a new issue, #726:
URL: https://github.com/apache/arrow-nanoarrow/issues/726
As pointed out in https://github.com/apache/arrow-nanoarrow/pull/719#pullrequestreview-2679508541 , in the changes leading up to our nice CMake build + install setup, we've accumulated quite a bit of repetition in CMakeLists.txt. If possible, we should extract out `add_nanoarrow_library()` and/or `add_nanoarrow_test()`.
I seem to remember the last time I tried this that the bundling and IPC dependencies made it hard to factor out but ADBC has nice versions of both of these that seem to allow quite a bit of flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Factor out common CMake invocations into functions [arrow-nanoarrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #726:
URL: https://github.com/apache/arrow-nanoarrow/issues/726#issuecomment-2726375357
I'm happy to help with this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Factor out common CMake invocations into functions [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #726:
URL: https://github.com/apache/arrow-nanoarrow/issues/726#issuecomment-2734814290
That's very kind of you! I've currently hit the stage in the CMake refactoring where I never want to write CMake ever again but I'll almost certainly recover if you don't have the chance to circle back:
Some other ideas from #719 that weren't implemented there:
For packaging the shared bit could be made a component that also changes which target gets the main alias. (again something gflags does find_package(gflags COMPONENTS shared)
nit: You should be able to create an INTERFACE target for the sources and use that instead of variables: https://cmake.org/cmake/help/latest/prop_tgt/INTERFACE_SOURCES.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org