[GitHub] tkb77 opened a new pull request #721: Parse authParamsString on plugin side

[gi...@git.apache.org]

tkb77 opened a new pull request #721: Parse authParamsString on plugin side
URL: https://github.com/apache/incubator-pulsar/pull/721
 
 
   ### Motivation
   fix [#671](https://github.com/apache/incubator-pulsar/issues/671)
   - authParamsString in which keys or values containing ":" or "," cannot be parsed correctly.
   
   ### Modifications
   
   1. Add `configure(String authParamsString)` to [Authentication](https://github.com/apache/incubator-pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/api/Authentication.java)  and move parsing logic from [AuthenticationFactory](https://github.com/apache/incubator-pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/api/AuthenticationFactory.java#L44-L53) to  [Authentication](https://github.com/apache/incubator-pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/api/Authentication.java) 
   
   2. If authParamsString is JSON, parse JSON.
       Otherwise, use current parsing logic(separated by ?:? and ?,?) for compatibility
   
   ### Result
   - We can parse authParamsString on plugins side by overriding `configure(String authParamsString)`.
   - We can use JSON format as well as current format.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services