You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/28 03:24:22 UTC
[GitHub] [shardingsphere] tain198127 opened a new pull request, #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
tain198127 opened a new pull request, #18645:
URL: https://github.com/apache/shardingsphere/pull/18645
Fixes #17472.
Changes proposed in this pull request:
- add unit test for SingleTableDropSchemaMetadataValidator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tain198127 commented on a diff in pull request #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
Posted by GitBox <gi...@apache.org>.
tain198127 commented on code in PR #18645:
URL: https://github.com/apache/shardingsphere/pull/18645#discussion_r908677810
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #18645:
URL: https://github.com/apache/shardingsphere/pull/18645#discussion_r908480023
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
Review Comment:
Please add final if class is not design for extension
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
Review Comment:
Please blank line between class and method definition
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateCascadeNotEmpty() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", false);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateSchemaNotMatch() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema1", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test
+ public void assertValidate() {
+ boolean isVerified = true;
+ try {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ } catch (ShardingSphereException ex) {
+ isVerified = false;
+ }
+ assertTrue(isVerified);
+ }
+
+ private ShardingSphereDatabase createMockDataBase(final String schemaName) {
+ ShardingSphereDatabase database = mock(ShardingSphereDatabase.class, RETURNS_DEEP_STUBS);
+ Map<String, ShardingSphereSchema> map = new HashMap<>();
+ ShardingSphereSchema shardingSphereSchema = new ShardingSphereSchema();
+ shardingSphereSchema.put("foo_table", new ShardingSphereTable());
+ map.put(schemaName, shardingSphereSchema);
+ when(database.getSchemas()).thenReturn(map);
+ return database;
+ }
+
+ private SQLStatementContext<DropSchemaStatement> createSQLStatementContext(final String schemaName, final boolean isCascade) {
+ PostgreSQLDropSchemaStatement dropDatabaseStatement = mock(PostgreSQLDropSchemaStatement.class, RETURNS_DEEP_STUBS);
+ when(dropDatabaseStatement.isContainsCascade()).thenReturn(isCascade);
+ Collection<IdentifierValue> collection = new ArrayList<>();
+ collection.add(new IdentifierValue(schemaName));
+ when(dropDatabaseStatement.getSchemaNames()).thenReturn(collection);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = new CommonSQLStatementContext(dropDatabaseStatement);
+ return sqlStatementContext;
Review Comment:
return value should name as `result`
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateCascadeNotEmpty() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", false);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateSchemaNotMatch() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema1", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test
+ public void assertValidate() {
+ boolean isVerified = true;
+ try {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ } catch (ShardingSphereException ex) {
+ isVerified = false;
+ }
+ assertTrue(isVerified);
+ }
+
+ private ShardingSphereDatabase createMockDataBase(final String schemaName) {
+ ShardingSphereDatabase database = mock(ShardingSphereDatabase.class, RETURNS_DEEP_STUBS);
+ Map<String, ShardingSphereSchema> map = new HashMap<>();
+ ShardingSphereSchema shardingSphereSchema = new ShardingSphereSchema();
+ shardingSphereSchema.put("foo_table", new ShardingSphereTable());
+ map.put(schemaName, shardingSphereSchema);
+ when(database.getSchemas()).thenReturn(map);
+ return database;
Review Comment:
return value should name as `result`
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateCascadeNotEmpty() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", false);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateSchemaNotMatch() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema1", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test
+ public void assertValidate() {
+ boolean isVerified = true;
+ try {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ } catch (ShardingSphereException ex) {
Review Comment:
Just throw it, junit can handle the exception
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateCascadeNotEmpty() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", false);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateSchemaNotMatch() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema1", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test
+ public void assertValidate() {
+ boolean isVerified = true;
+ try {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ } catch (ShardingSphereException ex) {
+ isVerified = false;
+ }
+ assertTrue(isVerified);
+ }
+
+ private ShardingSphereDatabase createMockDataBase(final String schemaName) {
Review Comment:
Database is one word, please do not use `DataBase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tain198127 commented on a diff in pull request #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
Posted by GitBox <gi...@apache.org>.
tain198127 commented on code in PR #18645:
URL: https://github.com/apache/shardingsphere/pull/18645#discussion_r908678959
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateCascadeNotEmpty() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", false);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateSchemaNotMatch() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema1", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test
+ public void assertValidate() {
+ boolean isVerified = true;
+ try {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ } catch (ShardingSphereException ex) {
+ isVerified = false;
+ }
+ assertTrue(isVerified);
+ }
+
+ private ShardingSphereDatabase createMockDataBase(final String schemaName) {
Review Comment:
typo error, had fixed
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateCascadeNotEmpty() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", false);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateSchemaNotMatch() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema1", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test
+ public void assertValidate() {
+ boolean isVerified = true;
+ try {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ } catch (ShardingSphereException ex) {
+ isVerified = false;
+ }
+ assertTrue(isVerified);
+ }
+
+ private ShardingSphereDatabase createMockDataBase(final String schemaName) {
+ ShardingSphereDatabase database = mock(ShardingSphereDatabase.class, RETURNS_DEEP_STUBS);
+ Map<String, ShardingSphereSchema> map = new HashMap<>();
+ ShardingSphereSchema shardingSphereSchema = new ShardingSphereSchema();
+ shardingSphereSchema.put("foo_table", new ShardingSphereTable());
+ map.put(schemaName, shardingSphereSchema);
+ when(database.getSchemas()).thenReturn(map);
+ return database;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tain198127 commented on a diff in pull request #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
Posted by GitBox <gi...@apache.org>.
tain198127 commented on code in PR #18645:
URL: https://github.com/apache/shardingsphere/pull/18645#discussion_r908679482
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateCascadeNotEmpty() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", false);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateSchemaNotMatch() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema1", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test
+ public void assertValidate() {
+ boolean isVerified = true;
+ try {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ } catch (ShardingSphereException ex) {
+ isVerified = false;
+ }
+ assertTrue(isVerified);
+ }
+
+ private ShardingSphereDatabase createMockDataBase(final String schemaName) {
+ ShardingSphereDatabase database = mock(ShardingSphereDatabase.class, RETURNS_DEEP_STUBS);
+ Map<String, ShardingSphereSchema> map = new HashMap<>();
+ ShardingSphereSchema shardingSphereSchema = new ShardingSphereSchema();
+ shardingSphereSchema.put("foo_table", new ShardingSphereTable());
+ map.put(schemaName, shardingSphereSchema);
+ when(database.getSchemas()).thenReturn(map);
+ return database;
+ }
+
+ private SQLStatementContext<DropSchemaStatement> createSQLStatementContext(final String schemaName, final boolean isCascade) {
+ PostgreSQLDropSchemaStatement dropDatabaseStatement = mock(PostgreSQLDropSchemaStatement.class, RETURNS_DEEP_STUBS);
+ when(dropDatabaseStatement.isContainsCascade()).thenReturn(isCascade);
+ Collection<IdentifierValue> collection = new ArrayList<>();
+ collection.add(new IdentifierValue(schemaName));
+ when(dropDatabaseStatement.getSchemaNames()).thenReturn(collection);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = new CommonSQLStatementContext(dropDatabaseStatement);
+ return sqlStatementContext;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tain198127 commented on pull request #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
Posted by GitBox <gi...@apache.org>.
tain198127 commented on PR #18645:
URL: https://github.com/apache/shardingsphere/pull/18645#issuecomment-1168821842
This is unit test coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tain198127 commented on a diff in pull request #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
Posted by GitBox <gi...@apache.org>.
tain198127 commented on code in PR #18645:
URL: https://github.com/apache/shardingsphere/pull/18645#discussion_r908678295
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateCascadeNotEmpty() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", false);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test(expected = ShardingSphereException.class)
+ public void assertValidateSchemaNotMatch() {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema1", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ }
+
+ @Test
+ public void assertValidate() {
+ boolean isVerified = true;
+ try {
+ SingleTableDropSchemaMetadataValidator singleTableDropSchemaMetadataValidator = new SingleTableDropSchemaMetadataValidator();
+ SingleTableRule singleTableRule = mock(SingleTableRule.class, RETURNS_DEEP_STUBS);
+ SQLStatementContext<DropSchemaStatement> sqlStatementContext = createSQLStatementContext("foo_schema", true);
+ ShardingSphereDatabase database = createMockDataBase("foo_schema");
+ singleTableDropSchemaMetadataValidator.validate(singleTableRule, sqlStatementContext, database);
+ } catch (ShardingSphereException ex) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tain198127 commented on a diff in pull request #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
Posted by GitBox <gi...@apache.org>.
tain198127 commented on code in PR #18645:
URL: https://github.com/apache/shardingsphere/pull/18645#discussion_r908676957
##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/validator/ddl/SingleTableDropSchemaMetadataValidatorTest.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.singletable.route.validator.ddl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.shardingsphere.infra.binder.statement.CommonSQLStatementContext;
+import org.apache.shardingsphere.infra.binder.statement.SQLStatementContext;
+import org.apache.shardingsphere.infra.exception.ShardingSphereException;
+import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereSchema;
+import org.apache.shardingsphere.infra.metadata.database.schema.decorator.model.ShardingSphereTable;
+import org.apache.shardingsphere.singletable.rule.SingleTableRule;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLDropSchemaStatement;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class SingleTableDropSchemaMetadataValidatorTest {
Review Comment:
done for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #18645: Fix issue 17472 add unit test for SingleTableDropSchemaMetadataValidator
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18645:
URL: https://github.com/apache/shardingsphere/pull/18645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org