You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@yetus.apache.org by "Jack Bearden (JIRA)" <ji...@apache.org> on 2018/07/20 21:45:00 UTC

[jira] [Commented] (YETUS-307) upgrade to middleman v4

    [ https://issues.apache.org/jira/browse/YETUS-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551332#comment-16551332 ] 

Jack Bearden commented on YETUS-307:
------------------------------------

Hey [~busbey]! I was hacking at this last night and was able to come up with a patch (#01). 

Quick list of changes:
 * The way Middleman v4 evaluates paths changed so I needed to fix the two instances that were not formatted properly anymore.
 * The after_configuration block is ran twice in v4 – once for global configuration options and second for normal execution. I added a guard so it doesn't build twice.
 * YAML files from the data folder need an app prefix now. I adjusted those variables accordingly.
 * With the v4 update came a bunch of dependency upgrades
 * Changes do not incur new rubocop offenses

I tested this on my local machine and from what I am able to tell, it works the same as master does. Please review and let me know if there's anything I missed. Thanks!

> upgrade to middleman v4
> -----------------------
>
>                 Key: YETUS-307
>                 URL: https://issues.apache.org/jira/browse/YETUS-307
>             Project: Yetus
>          Issue Type: Improvement
>          Components: website and documentation
>            Reporter: Sean Busbey
>            Priority: Major
>         Attachments: YETUS-307.01.patch
>
>
> Middleman v4+ is out now. It's supposed to add the ability to have multiple source locations, so we can remove our hacky use of symlinks.
> upgrade guide:
> https://middlemanapp.com/basics/upgrade-v4/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)