[GitHub] [incubator-iceberg] TGooch44 commented on a change in pull request #277: Moving/Renaming hadoop module to filesystem

[GitBox <gi...@apache.org>]

TGooch44 commented on a change in pull request #277: Moving/Renaming hadoop module to filesystem
URL: https://github.com/apache/incubator-iceberg/pull/277#discussion_r304624961
 
 

 ##########
 File path: python/iceberg/core/util/__init__.py
 ##########
 @@ -15,6 +15,11 @@
 # specific language governing permissions and limitations
 # under the License.
 
-__all__ = ["AtomicInteger"]
+__all__ = ["AtomicInteger", "PackingIterator", "str_as_bool"]
 
 from .atomic_integer import AtomicInteger
+from .bin_packing import PackingIterator
+
+
+def str_as_bool(str_var):
 
 Review comment:
   This is used in some classes that haven't been merged in yet.  Specifically, to get table properties, which have string values but are used as booleans. I can double check if it's needed but I believe the boolean strings are stored not in python format eg. "true" and "false"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org