[GitHub] [ignite-extensions] ashapkin commented on a change in pull request #94: IGNITE-16124 change signature in method deleteAllById in spring data 2.2

[GitBox <gi...@apache.org>]

ashapkin commented on a change in pull request #94:
URL: https://github.com/apache/ignite-extensions/pull/94#discussion_r784751024



##########
File path: modules/spring-data-2.2-ext/src/test/java/org/apache/ignite/springdata/IgniteSpringDataCompoundKeyTest.java
##########
@@ -19,7 +19,10 @@
 import java.sql.Connection;
 import java.sql.DriverManager;
 import java.sql.Statement;
+import java.util.HashSet;
 import java.util.Optional;
+import java.util.Set;

Review comment:
       unnecessary changes

##########
File path: modules/spring-data-2.2-ext/src/test/java/org/apache/ignite/springdata/compoundkey/CityKeyExt.java
##########
@@ -0,0 +1,41 @@
+package org.apache.ignite.springdata.compoundkey;

Review comment:
       License header is missing

##########
File path: modules/spring-data-2.2-ext/src/test/java/org/apache/ignite/springdata/compoundkey/CityKeyExt.java
##########
@@ -0,0 +1,41 @@
+package org.apache.ignite.springdata.compoundkey;
+
+import java.util.Objects;
+
+public class CityKeyExt extends CityKey {

Review comment:
       Javadoc is missing, please https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-JavadocComments 
   
   Please add them (might be blank though) for every method/field in this class. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org