You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by Anatole Tresch <at...@gmail.com> on 2015/02/11 09:34:17 UTC
findbugs annotations
Dear all
I am not sure where we stopped our discussions along removing
the¨dependency to
<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
</dependency>
Currently its only used at one single location and IMO I do not want have
any dependency on a tool in the code. So I would remove it, if nobody
complains...
Best
Anatole
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
Not sure if we do an "exclusive" or "inclusive" vote now, but for
substantial components like API or core I certainly say
+1 to avoid these dependencies (or -1 on using them;-)
Depending on particular modules or extensions, there could be a bit of
freedom, let's say a "reporting" or "analytics" module may use additional
artifacts like Asciidoc(tor) or similar while other modules don't require
it. If there's just a single user or class that requires it, I'd say that
never justifies the extra baggage. Should there be a wide-spread use by
some specific module, then maybe, but it should be applied with care.
Werner
On Wed, Feb 11, 2015 at 1:47 PM, Anatole Tresch <at...@gmail.com> wrote:
> Then you should ask users if they really use that tool. I really do not
> know one person (beside you obviously ;) ), that uses it in that way...
>
> 2015-02-11 13:44 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>
> > The advantage is the value you provide to your users. If your users use
> > FindBugs and similar tools they would be able to detect possible NPE
> before.
> >
> > Oliver
> >
> > Am 11.02.15 um 13:00 schrieb Anatole Tresch:
> >
> >> maybe that's ok for Google, but not for me. We should really minimize
> the
> >> deps, and as I said adding deps just of a tool, then the tool is broken
> >> IMO.
> >> And adding a production dependency is quite a harsh thing, it must be
> well
> >> legitimated IMO, which in our case I do not see it. We can use FindBugs
> >> plugin and the other quality tools (e.g. Sonar), from my experience this
> >> is
> >> far enough. Finally most of the checks can be covered by writing tests
> as
> >> well...
> >>
> >> 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o.b.fischer@swe-blog.net
> >:
> >>
> >> For Google Guava it works quite well... Why not for us?
> >>>
> >>> Am 11.02.15 um 12:15 schrieb Anatole Tresch:
> >>>
> >>> --
> >>> N Oliver B. Fischer
> >>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> >>> P +49 30 44793251
> >>> M +49 178 7903538
> >>> E o.b.fischer@swe-blog.net
> >>> S oliver.b.fischer
> >>> J oliver.b.fischer@jabber.org
> >>> X http://xing.to/obf
> >>>
> >>>
> >>>
> >>
> > --
> > N Oliver B. Fischer
> > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> > P +49 30 44793251
> > M +49 178 7903538
> > E o.b.fischer@swe-blog.net
> > S oliver.b.fischer
> > J oliver.b.fischer@jabber.org
> > X http://xing.to/obf
> >
> >
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79*
>
Re: findbugs annotations
Posted by Anatole Tresch <at...@gmail.com>.
Then you should ask users if they really use that tool. I really do not
know one person (beside you obviously ;) ), that uses it in that way...
2015-02-11 13:44 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
> The advantage is the value you provide to your users. If your users use
> FindBugs and similar tools they would be able to detect possible NPE before.
>
> Oliver
>
> Am 11.02.15 um 13:00 schrieb Anatole Tresch:
>
>> maybe that's ok for Google, but not for me. We should really minimize the
>> deps, and as I said adding deps just of a tool, then the tool is broken
>> IMO.
>> And adding a production dependency is quite a harsh thing, it must be well
>> legitimated IMO, which in our case I do not see it. We can use FindBugs
>> plugin and the other quality tools (e.g. Sonar), from my experience this
>> is
>> far enough. Finally most of the checks can be covered by writing tests as
>> well...
>>
>> 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>>
>> For Google Guava it works quite well... Why not for us?
>>>
>>> Am 11.02.15 um 12:15 schrieb Anatole Tresch:
>>>
>>> --
>>> N Oliver B. Fischer
>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>> P +49 30 44793251
>>> M +49 178 7903538
>>> E o.b.fischer@swe-blog.net
>>> S oliver.b.fischer
>>> J oliver.b.fischer@jabber.org
>>> X http://xing.to/obf
>>>
>>>
>>>
>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: findbugs annotations
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
The advantage is the value you provide to your users. If your users use
FindBugs and similar tools they would be able to detect possible NPE before.
Oliver
Am 11.02.15 um 13:00 schrieb Anatole Tresch:
> maybe that's ok for Google, but not for me. We should really minimize the
> deps, and as I said adding deps just of a tool, then the tool is broken IMO.
> And adding a production dependency is quite a harsh thing, it must be well
> legitimated IMO, which in our case I do not see it. We can use FindBugs
> plugin and the other quality tools (e.g. Sonar), from my experience this is
> far enough. Finally most of the checks can be covered by writing tests as
> well...
>
> 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>
>> For Google Guava it works quite well... Why not for us?
>>
>> Am 11.02.15 um 12:15 schrieb Anatole Tresch:
>>
>> --
>> N Oliver B. Fischer
>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>> P +49 30 44793251
>> M +49 178 7903538
>> E o.b.fischer@swe-blog.net
>> S oliver.b.fischer
>> J oliver.b.fischer@jabber.org
>> X http://xing.to/obf
>>
>>
>
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
Those +1 or -1 were already a sign of voting here I'd say, but ideally more
people than us 3 or 4 should cast their opinion (also to make it binding, a
minimum number of 3 PMC members is required to make such vote binding;-)
On Wed, Feb 11, 2015 at 1:27 PM, Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Let s vote no?
> Le 11 févr. 2015 13:01, "Anatole Tresch" <at...@gmail.com> a écrit :
>
> > maybe that's ok for Google, but not for me. We should really minimize the
> > deps, and as I said adding deps just of a tool, then the tool is broken
> > IMO.
> > And adding a production dependency is quite a harsh thing, it must be
> well
> > legitimated IMO, which in our case I do not see it. We can use FindBugs
> > plugin and the other quality tools (e.g. Sonar), from my experience this
> is
> > far enough. Finally most of the checks can be covered by writing tests as
> > well...
> >
> > 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
> >
> > > For Google Guava it works quite well... Why not for us?
> > >
> > > Am 11.02.15 um 12:15 schrieb Anatole Tresch:
> > >
> > >> And as I said you add an additional dependency to your production
> code,
> > >> which is not necessary. For me an absolute no-go...
> > >>
> > >>
> > >> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
> > >>
> > >> Well as Anatole said it seems just a single place.
> > >>> Why just there and is there significant value using it in many
> places?
> > >>>
> > >>> I've used the FindBugs plugin a lot without the annotations, it
> worked
> > >>> well
> > >>> there, too.
> > >>>
> > >>>
> > >>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
> > >>> o.b.fischer@swe-blog.net> wrote:
> > >>>
> > >>>
> > >>
> > >>
> > > --
> > > N Oliver B. Fischer
> > > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> > > P +49 30 44793251
> > > M +49 178 7903538
> > > E o.b.fischer@swe-blog.net
> > > S oliver.b.fischer
> > > J oliver.b.fischer@jabber.org
> > > X http://xing.to/obf
> > >
> > >
> >
> >
> > --
> > *Anatole Tresch*
> > Java Engineer & Architect, JSR Spec Lead
> > Glärnischweg 10
> > CH - 8620 Wetzikon
> >
> > *Switzerland, Europe Zurich, GMT+1*
> > *Twitter: @atsticks*
> > *Blogs: **http://javaremarkables.blogspot.ch/
> > <http://javaremarkables.blogspot.ch/>*
> >
> > *Google: atsticksMobile +41-76 344 62 79*
> >
>
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
The Apache Parent POM doesn't even offer the FindBugs plugin btw, so if it
was really so vital or widely used, such parent POMs would also contain it.
Nobody (except maybe Guava) uses it, not even JBoss. You'll find the Maven
plugin in its Parent POM but no sign of those annotations.
Werner
On Wed, Feb 11, 2015 at 2:34 PM, Oliver B. Fischer <o.b.fischer@swe-blog.net
> wrote:
> IMHO it is an mistake to remove them as we provide additional value to our
> uses by helping them to detect extensive programming errors as early as
> possible.
>
> Oliver
>
> Am 11.02.15 um 14:27 schrieb Reinhard Sandtner:
>
>> hey,
>>
>> +1 to remove it
>>
>> we do not need these annotation imo
>>
>> another option (but i'm also -1 for this) is to add
>> <optional>true</optional> because afaik if annotations are not there at
>> runtime, they will be ignored!
>>
>> lg
>> reini
>>
>> 2015-02-11 14:17 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>>
>> But why for extensions? Then we should prohibit all other dependencies.
>>>
>>> Am 11.02.15 um 13:48 schrieb Anatole Tresch:
>>>
>>> For me the same: -1 as well for extensions.
>>> --
>>> N Oliver B. Fischer
>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>> P +49 30 44793251
>>> M +49 178 7903538
>>> E o.b.fischer@swe-blog.net
>>> S oliver.b.fischer
>>> J oliver.b.fischer@jabber.org
>>> X http://xing.to/obf
>>>
>>>
>>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
Re: findbugs annotations
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
IMHO it is an mistake to remove them as we provide additional value to
our uses by helping them to detect extensive programming errors as early
as possible.
Oliver
Am 11.02.15 um 14:27 schrieb Reinhard Sandtner:
> hey,
>
> +1 to remove it
>
> we do not need these annotation imo
>
> another option (but i'm also -1 for this) is to add
> <optional>true</optional> because afaik if annotations are not there at
> runtime, they will be ignored!
>
> lg
> reini
>
> 2015-02-11 14:17 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>
>> But why for extensions? Then we should prohibit all other dependencies.
>>
>> Am 11.02.15 um 13:48 schrieb Anatole Tresch:
>>
>> For me the same: -1 as well for extensions.
>> --
>> N Oliver B. Fischer
>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>> P +49 30 44793251
>> M +49 178 7903538
>> E o.b.fischer@swe-blog.net
>> S oliver.b.fischer
>> J oliver.b.fischer@jabber.org
>> X http://xing.to/obf
>>
>>
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: findbugs annotations
Posted by Reinhard Sandtner <re...@gmail.com>.
hey,
+1 to remove it
we do not need these annotation imo
another option (but i'm also -1 for this) is to add
<optional>true</optional> because afaik if annotations are not there at
runtime, they will be ignored!
lg
reini
2015-02-11 14:17 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
> But why for extensions? Then we should prohibit all other dependencies.
>
> Am 11.02.15 um 13:48 schrieb Anatole Tresch:
>
> For me the same: -1 as well for extensions.
>>
>> 2015-02-11 13:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>>
>> Can we use it in the extension modules?
>>>
>>> Am 11.02.15 um 13:44 schrieb Anatole Tresch:
>>>
>>> Of course, still the same opinion: +1 for removing it...
>>>>
>>>> 2015-02-11 13:33 GMT+01:00 Werner Keil <we...@gmail.com>:
>>>>
>>>> @Anatole, though you started or restarted the conversation, the person
>>>>
>>>>> who
>>>>> starts a vote is also allowed and supposed to vote;-)
>>>>>
>>>>> On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil <we...@gmail.com>
>>>>> wrote:
>>>>>
>>>>> écrit
>>>>> minimize
>>>>> be
>>>>>
>>>>>
>>>>
>>>> --
>>> N Oliver B. Fischer
>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>> P +49 30 44793251
>>> M +49 178 7903538
>>> E o.b.fischer@swe-blog.net
>>> S oliver.b.fischer
>>> J oliver.b.fischer@jabber.org
>>> X http://xing.to/obf
>>>
>>>
>>>
>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
Re: findbugs annotations
Posted by Mark Struberg <st...@yahoo.de>.
> On Wednesday, 11 February 2015, 14:47, Romain Manni-Bucau <rm...@gmail.com> wrote:
> > +1 to not use them at all
+1
LieGrue,
strub
> On Wednesday, 11 February 2015, 14:47, Romain Manni-Bucau <rm...@gmail.com> wrote:
> > +1 to not use them at all (users are not numerous enough or please
> shout + it most of the time adds noise to a project and no real value
> - illusion of quality)
>
> No dependencies at all -> right that's what we MUST do IMO (ie for
> extensions just use the integration you do and not others)
>
>
> Romain Manni-Bucau
> @rmannibucau
> http://www.tomitribe.com
> http://rmannibucau.wordpress.com
> https://github.com/rmannibucau
>
>
>
> 2015-02-11 14:33 GMT+01:00 Werner Keil <we...@gmail.com>:
>> Well, it depends on what a module does.
>> It would be stupid to prohibit a module that writes the configuration to
>> PDF from using either Asciidoc or some other Apache project like FOP;-)
>>
>>
>>
>>
>>
>> On Wed, Feb 11, 2015 at 2:17 PM, Oliver B. Fischer
> <o.b.fischer@swe-blog.net
>>> wrote:
>>
>>> But why for extensions? Then we should prohibit all other dependencies.
>>>
>>> Am 11.02.15 um 13:48 schrieb Anatole Tresch:
>>>
>>> For me the same: -1 as well for extensions.
>>>>
>>>> 2015-02-11 13:47 GMT+01:00 Oliver B. Fischer
> <o....@swe-blog.net>:
>>>>
>>>> Can we use it in the extension modules?
>>>>>
>>>>> Am 11.02.15 um 13:44 schrieb Anatole Tresch:
>>>>>
>>>>> Of course, still the same opinion: +1 for removing it...
>>>>>>
>>>>>> 2015-02-11 13:33 GMT+01:00 Werner Keil
> <we...@gmail.com>:
>>>>>>
>>>>>> @Anatole, though you started or restarted the
> conversation, the person
>>>>>>
>>>>>>> who
>>>>>>> starts a vote is also allowed and supposed to vote;-)
>>>>>>>
>>>>>>> On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil
> <we...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> écrit
>>>>>>> minimize
>>>>>>> be
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> --
>>>>> N Oliver B. Fischer
>>>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>>>> P +49 30 44793251
>>>>> M +49 178 7903538
>>>>> E o.b.fischer@swe-blog.net
>>>>> S oliver.b.fischer
>>>>> J oliver.b.fischer@jabber.org
>>>>> X http://xing.to/obf
>>>>>
>>>>>
>>>>>
>>>>
>>> --
>>> N Oliver B. Fischer
>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>> P +49 30 44793251
>>> M +49 178 7903538
>>> E o.b.fischer@swe-blog.net
>>> S oliver.b.fischer
>>> J oliver.b.fischer@jabber.org
>>> X http://xing.to/obf
>>>
>>>
>
Re: findbugs annotations
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1 to not use them at all (users are not numerous enough or please
shout + it most of the time adds noise to a project and no real value
- illusion of quality)
No dependencies at all -> right that's what we MUST do IMO (ie for
extensions just use the integration you do and not others)
Romain Manni-Bucau
@rmannibucau
http://www.tomitribe.com
http://rmannibucau.wordpress.com
https://github.com/rmannibucau
2015-02-11 14:33 GMT+01:00 Werner Keil <we...@gmail.com>:
> Well, it depends on what a module does.
> It would be stupid to prohibit a module that writes the configuration to
> PDF from using either Asciidoc or some other Apache project like FOP;-)
>
>
>
>
>
> On Wed, Feb 11, 2015 at 2:17 PM, Oliver B. Fischer <o.b.fischer@swe-blog.net
>> wrote:
>
>> But why for extensions? Then we should prohibit all other dependencies.
>>
>> Am 11.02.15 um 13:48 schrieb Anatole Tresch:
>>
>> For me the same: -1 as well for extensions.
>>>
>>> 2015-02-11 13:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>>>
>>> Can we use it in the extension modules?
>>>>
>>>> Am 11.02.15 um 13:44 schrieb Anatole Tresch:
>>>>
>>>> Of course, still the same opinion: +1 for removing it...
>>>>>
>>>>> 2015-02-11 13:33 GMT+01:00 Werner Keil <we...@gmail.com>:
>>>>>
>>>>> @Anatole, though you started or restarted the conversation, the person
>>>>>
>>>>>> who
>>>>>> starts a vote is also allowed and supposed to vote;-)
>>>>>>
>>>>>> On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil <we...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>> écrit
>>>>>> minimize
>>>>>> be
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>> N Oliver B. Fischer
>>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>>> P +49 30 44793251
>>>> M +49 178 7903538
>>>> E o.b.fischer@swe-blog.net
>>>> S oliver.b.fischer
>>>> J oliver.b.fischer@jabber.org
>>>> X http://xing.to/obf
>>>>
>>>>
>>>>
>>>
>> --
>> N Oliver B. Fischer
>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>> P +49 30 44793251
>> M +49 178 7903538
>> E o.b.fischer@swe-blog.net
>> S oliver.b.fischer
>> J oliver.b.fischer@jabber.org
>> X http://xing.to/obf
>>
>>
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
Well, it depends on what a module does.
It would be stupid to prohibit a module that writes the configuration to
PDF from using either Asciidoc or some other Apache project like FOP;-)
On Wed, Feb 11, 2015 at 2:17 PM, Oliver B. Fischer <o.b.fischer@swe-blog.net
> wrote:
> But why for extensions? Then we should prohibit all other dependencies.
>
> Am 11.02.15 um 13:48 schrieb Anatole Tresch:
>
> For me the same: -1 as well for extensions.
>>
>> 2015-02-11 13:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>>
>> Can we use it in the extension modules?
>>>
>>> Am 11.02.15 um 13:44 schrieb Anatole Tresch:
>>>
>>> Of course, still the same opinion: +1 for removing it...
>>>>
>>>> 2015-02-11 13:33 GMT+01:00 Werner Keil <we...@gmail.com>:
>>>>
>>>> @Anatole, though you started or restarted the conversation, the person
>>>>
>>>>> who
>>>>> starts a vote is also allowed and supposed to vote;-)
>>>>>
>>>>> On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil <we...@gmail.com>
>>>>> wrote:
>>>>>
>>>>> écrit
>>>>> minimize
>>>>> be
>>>>>
>>>>>
>>>>
>>>> --
>>> N Oliver B. Fischer
>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>> P +49 30 44793251
>>> M +49 178 7903538
>>> E o.b.fischer@swe-blog.net
>>> S oliver.b.fischer
>>> J oliver.b.fischer@jabber.org
>>> X http://xing.to/obf
>>>
>>>
>>>
>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
Re: findbugs annotations
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
But why for extensions? Then we should prohibit all other dependencies.
Am 11.02.15 um 13:48 schrieb Anatole Tresch:
> For me the same: -1 as well for extensions.
>
> 2015-02-11 13:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>
>> Can we use it in the extension modules?
>>
>> Am 11.02.15 um 13:44 schrieb Anatole Tresch:
>>
>>> Of course, still the same opinion: +1 for removing it...
>>>
>>> 2015-02-11 13:33 GMT+01:00 Werner Keil <we...@gmail.com>:
>>>
>>> @Anatole, though you started or restarted the conversation, the person
>>>> who
>>>> starts a vote is also allowed and supposed to vote;-)
>>>>
>>>> On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil <we...@gmail.com>
>>>> wrote:
>>>>
>>>> écrit
>>>> minimize
>>>> be
>>>>
>>>
>>>
>> --
>> N Oliver B. Fischer
>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>> P +49 30 44793251
>> M +49 178 7903538
>> E o.b.fischer@swe-blog.net
>> S oliver.b.fischer
>> J oliver.b.fischer@jabber.org
>> X http://xing.to/obf
>>
>>
>
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: findbugs annotations
Posted by Anatole Tresch <at...@gmail.com>.
For me the same: -1 as well for extensions.
2015-02-11 13:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
> Can we use it in the extension modules?
>
> Am 11.02.15 um 13:44 schrieb Anatole Tresch:
>
>> Of course, still the same opinion: +1 for removing it...
>>
>> 2015-02-11 13:33 GMT+01:00 Werner Keil <we...@gmail.com>:
>>
>> @Anatole, though you started or restarted the conversation, the person
>>> who
>>> starts a vote is also allowed and supposed to vote;-)
>>>
>>> On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil <we...@gmail.com>
>>> wrote:
>>>
>>> écrit
>>> minimize
>>> be
>>>
>>
>>
>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: findbugs annotations
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
Can we use it in the extension modules?
Am 11.02.15 um 13:44 schrieb Anatole Tresch:
> Of course, still the same opinion: +1 for removing it...
>
> 2015-02-11 13:33 GMT+01:00 Werner Keil <we...@gmail.com>:
>
>> @Anatole, though you started or restarted the conversation, the person who
>> starts a vote is also allowed and supposed to vote;-)
>>
>> On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil <we...@gmail.com>
>> wrote:
>>
>> écrit
>> minimize
>> be
>
>
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: findbugs annotations
Posted by Anatole Tresch <at...@gmail.com>.
Of course, still the same opinion: +1 for removing it...
2015-02-11 13:33 GMT+01:00 Werner Keil <we...@gmail.com>:
> @Anatole, though you started or restarted the conversation, the person who
> starts a vote is also allowed and supposed to vote;-)
>
> On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil <we...@gmail.com>
> wrote:
>
> > Again?
> >
> >
> > On Wed, Feb 11, 2015 at 1:29 PM, Anatole Tresch <at...@gmail.com>
> > wrote:
> >
> >> Yep...
> >>
> >> 2015-02-11 13:27 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> >>
> >> > Let s vote no?
> >> > Le 11 févr. 2015 13:01, "Anatole Tresch" <at...@gmail.com> a
> écrit
> >> :
> >> >
> >> > > maybe that's ok for Google, but not for me. We should really
> minimize
> >> the
> >> > > deps, and as I said adding deps just of a tool, then the tool is
> >> broken
> >> > > IMO.
> >> > > And adding a production dependency is quite a harsh thing, it must
> be
> >> > well
> >> > > legitimated IMO, which in our case I do not see it. We can use
> >> FindBugs
> >> > > plugin and the other quality tools (e.g. Sonar), from my experience
> >> this
> >> > is
> >> > > far enough. Finally most of the checks can be covered by writing
> >> tests as
> >> > > well...
> >> > >
> >> > > 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <
> >> o.b.fischer@swe-blog.net>:
> >> > >
> >> > > > For Google Guava it works quite well... Why not for us?
> >> > > >
> >> > > > Am 11.02.15 um 12:15 schrieb Anatole Tresch:
> >> > > >
> >> > > >> And as I said you add an additional dependency to your production
> >> > code,
> >> > > >> which is not necessary. For me an absolute no-go...
> >> > > >>
> >> > > >>
> >> > > >> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
> >> > > >>
> >> > > >> Well as Anatole said it seems just a single place.
> >> > > >>> Why just there and is there significant value using it in many
> >> > places?
> >> > > >>>
> >> > > >>> I've used the FindBugs plugin a lot without the annotations, it
> >> > worked
> >> > > >>> well
> >> > > >>> there, too.
> >> > > >>>
> >> > > >>>
> >> > > >>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
> >> > > >>> o.b.fischer@swe-blog.net> wrote:
> >> > > >>>
> >> > > >>>
> >> > > >>
> >> > > >>
> >> > > > --
> >> > > > N Oliver B. Fischer
> >> > > > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> >> > > > P +49 30 44793251
> >> > > > M +49 178 7903538
> >> > > > E o.b.fischer@swe-blog.net
> >> > > > S oliver.b.fischer
> >> > > > J oliver.b.fischer@jabber.org
> >> > > > X http://xing.to/obf
> >> > > >
> >> > > >
> >> > >
> >> > >
> >> > > --
> >> > > *Anatole Tresch*
> >> > > Java Engineer & Architect, JSR Spec Lead
> >> > > Glärnischweg 10
> >> > > CH - 8620 Wetzikon
> >> > >
> >> > > *Switzerland, Europe Zurich, GMT+1*
> >> > > *Twitter: @atsticks*
> >> > > *Blogs: **http://javaremarkables.blogspot.ch/
> >> > > <http://javaremarkables.blogspot.ch/>*
> >> > >
> >> > > *Google: atsticksMobile +41-76 344 62 79*
> >> > >
> >> >
> >>
> >>
> >>
> >> --
> >> *Anatole Tresch*
> >> Java Engineer & Architect, JSR Spec Lead
> >> Glärnischweg 10
> >> CH - 8620 Wetzikon
> >>
> >> *Switzerland, Europe Zurich, GMT+1*
> >> *Twitter: @atsticks*
> >> *Blogs: **http://javaremarkables.blogspot.ch/
> >> <http://javaremarkables.blogspot.ch/>*
> >>
> >> *Google: atsticksMobile +41-76 344 62 79*
> >>
> >
> >
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
@Anatole, though you started or restarted the conversation, the person who
starts a vote is also allowed and supposed to vote;-)
On Wed, Feb 11, 2015 at 1:32 PM, Werner Keil <we...@gmail.com> wrote:
> Again?
>
>
> On Wed, Feb 11, 2015 at 1:29 PM, Anatole Tresch <at...@gmail.com>
> wrote:
>
>> Yep...
>>
>> 2015-02-11 13:27 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
>>
>> > Let s vote no?
>> > Le 11 févr. 2015 13:01, "Anatole Tresch" <at...@gmail.com> a écrit
>> :
>> >
>> > > maybe that's ok for Google, but not for me. We should really minimize
>> the
>> > > deps, and as I said adding deps just of a tool, then the tool is
>> broken
>> > > IMO.
>> > > And adding a production dependency is quite a harsh thing, it must be
>> > well
>> > > legitimated IMO, which in our case I do not see it. We can use
>> FindBugs
>> > > plugin and the other quality tools (e.g. Sonar), from my experience
>> this
>> > is
>> > > far enough. Finally most of the checks can be covered by writing
>> tests as
>> > > well...
>> > >
>> > > 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <
>> o.b.fischer@swe-blog.net>:
>> > >
>> > > > For Google Guava it works quite well... Why not for us?
>> > > >
>> > > > Am 11.02.15 um 12:15 schrieb Anatole Tresch:
>> > > >
>> > > >> And as I said you add an additional dependency to your production
>> > code,
>> > > >> which is not necessary. For me an absolute no-go...
>> > > >>
>> > > >>
>> > > >> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
>> > > >>
>> > > >> Well as Anatole said it seems just a single place.
>> > > >>> Why just there and is there significant value using it in many
>> > places?
>> > > >>>
>> > > >>> I've used the FindBugs plugin a lot without the annotations, it
>> > worked
>> > > >>> well
>> > > >>> there, too.
>> > > >>>
>> > > >>>
>> > > >>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
>> > > >>> o.b.fischer@swe-blog.net> wrote:
>> > > >>>
>> > > >>>
>> > > >>
>> > > >>
>> > > > --
>> > > > N Oliver B. Fischer
>> > > > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>> > > > P +49 30 44793251
>> > > > M +49 178 7903538
>> > > > E o.b.fischer@swe-blog.net
>> > > > S oliver.b.fischer
>> > > > J oliver.b.fischer@jabber.org
>> > > > X http://xing.to/obf
>> > > >
>> > > >
>> > >
>> > >
>> > > --
>> > > *Anatole Tresch*
>> > > Java Engineer & Architect, JSR Spec Lead
>> > > Glärnischweg 10
>> > > CH - 8620 Wetzikon
>> > >
>> > > *Switzerland, Europe Zurich, GMT+1*
>> > > *Twitter: @atsticks*
>> > > *Blogs: **http://javaremarkables.blogspot.ch/
>> > > <http://javaremarkables.blogspot.ch/>*
>> > >
>> > > *Google: atsticksMobile +41-76 344 62 79*
>> > >
>> >
>>
>>
>>
>> --
>> *Anatole Tresch*
>> Java Engineer & Architect, JSR Spec Lead
>> Glärnischweg 10
>> CH - 8620 Wetzikon
>>
>> *Switzerland, Europe Zurich, GMT+1*
>> *Twitter: @atsticks*
>> *Blogs: **http://javaremarkables.blogspot.ch/
>> <http://javaremarkables.blogspot.ch/>*
>>
>> *Google: atsticksMobile +41-76 344 62 79*
>>
>
>
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
Again?
On Wed, Feb 11, 2015 at 1:29 PM, Anatole Tresch <at...@gmail.com> wrote:
> Yep...
>
> 2015-02-11 13:27 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
>
> > Let s vote no?
> > Le 11 févr. 2015 13:01, "Anatole Tresch" <at...@gmail.com> a écrit :
> >
> > > maybe that's ok for Google, but not for me. We should really minimize
> the
> > > deps, and as I said adding deps just of a tool, then the tool is broken
> > > IMO.
> > > And adding a production dependency is quite a harsh thing, it must be
> > well
> > > legitimated IMO, which in our case I do not see it. We can use FindBugs
> > > plugin and the other quality tools (e.g. Sonar), from my experience
> this
> > is
> > > far enough. Finally most of the checks can be covered by writing tests
> as
> > > well...
> > >
> > > 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o.b.fischer@swe-blog.net
> >:
> > >
> > > > For Google Guava it works quite well... Why not for us?
> > > >
> > > > Am 11.02.15 um 12:15 schrieb Anatole Tresch:
> > > >
> > > >> And as I said you add an additional dependency to your production
> > code,
> > > >> which is not necessary. For me an absolute no-go...
> > > >>
> > > >>
> > > >> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
> > > >>
> > > >> Well as Anatole said it seems just a single place.
> > > >>> Why just there and is there significant value using it in many
> > places?
> > > >>>
> > > >>> I've used the FindBugs plugin a lot without the annotations, it
> > worked
> > > >>> well
> > > >>> there, too.
> > > >>>
> > > >>>
> > > >>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
> > > >>> o.b.fischer@swe-blog.net> wrote:
> > > >>>
> > > >>>
> > > >>
> > > >>
> > > > --
> > > > N Oliver B. Fischer
> > > > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> > > > P +49 30 44793251
> > > > M +49 178 7903538
> > > > E o.b.fischer@swe-blog.net
> > > > S oliver.b.fischer
> > > > J oliver.b.fischer@jabber.org
> > > > X http://xing.to/obf
> > > >
> > > >
> > >
> > >
> > > --
> > > *Anatole Tresch*
> > > Java Engineer & Architect, JSR Spec Lead
> > > Glärnischweg 10
> > > CH - 8620 Wetzikon
> > >
> > > *Switzerland, Europe Zurich, GMT+1*
> > > *Twitter: @atsticks*
> > > *Blogs: **http://javaremarkables.blogspot.ch/
> > > <http://javaremarkables.blogspot.ch/>*
> > >
> > > *Google: atsticksMobile +41-76 344 62 79*
> > >
> >
>
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79*
>
Re: findbugs annotations
Posted by Anatole Tresch <at...@gmail.com>.
Yep...
2015-02-11 13:27 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> Let s vote no?
> Le 11 févr. 2015 13:01, "Anatole Tresch" <at...@gmail.com> a écrit :
>
> > maybe that's ok for Google, but not for me. We should really minimize the
> > deps, and as I said adding deps just of a tool, then the tool is broken
> > IMO.
> > And adding a production dependency is quite a harsh thing, it must be
> well
> > legitimated IMO, which in our case I do not see it. We can use FindBugs
> > plugin and the other quality tools (e.g. Sonar), from my experience this
> is
> > far enough. Finally most of the checks can be covered by writing tests as
> > well...
> >
> > 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
> >
> > > For Google Guava it works quite well... Why not for us?
> > >
> > > Am 11.02.15 um 12:15 schrieb Anatole Tresch:
> > >
> > >> And as I said you add an additional dependency to your production
> code,
> > >> which is not necessary. For me an absolute no-go...
> > >>
> > >>
> > >> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
> > >>
> > >> Well as Anatole said it seems just a single place.
> > >>> Why just there and is there significant value using it in many
> places?
> > >>>
> > >>> I've used the FindBugs plugin a lot without the annotations, it
> worked
> > >>> well
> > >>> there, too.
> > >>>
> > >>>
> > >>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
> > >>> o.b.fischer@swe-blog.net> wrote:
> > >>>
> > >>>
> > >>
> > >>
> > > --
> > > N Oliver B. Fischer
> > > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> > > P +49 30 44793251
> > > M +49 178 7903538
> > > E o.b.fischer@swe-blog.net
> > > S oliver.b.fischer
> > > J oliver.b.fischer@jabber.org
> > > X http://xing.to/obf
> > >
> > >
> >
> >
> > --
> > *Anatole Tresch*
> > Java Engineer & Architect, JSR Spec Lead
> > Glärnischweg 10
> > CH - 8620 Wetzikon
> >
> > *Switzerland, Europe Zurich, GMT+1*
> > *Twitter: @atsticks*
> > *Blogs: **http://javaremarkables.blogspot.ch/
> > <http://javaremarkables.blogspot.ch/>*
> >
> > *Google: atsticksMobile +41-76 344 62 79*
> >
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: findbugs annotations
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Let s vote no?
Le 11 févr. 2015 13:01, "Anatole Tresch" <at...@gmail.com> a écrit :
> maybe that's ok for Google, but not for me. We should really minimize the
> deps, and as I said adding deps just of a tool, then the tool is broken
> IMO.
> And adding a production dependency is quite a harsh thing, it must be well
> legitimated IMO, which in our case I do not see it. We can use FindBugs
> plugin and the other quality tools (e.g. Sonar), from my experience this is
> far enough. Finally most of the checks can be covered by writing tests as
> well...
>
> 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>
> > For Google Guava it works quite well... Why not for us?
> >
> > Am 11.02.15 um 12:15 schrieb Anatole Tresch:
> >
> >> And as I said you add an additional dependency to your production code,
> >> which is not necessary. For me an absolute no-go...
> >>
> >>
> >> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
> >>
> >> Well as Anatole said it seems just a single place.
> >>> Why just there and is there significant value using it in many places?
> >>>
> >>> I've used the FindBugs plugin a lot without the annotations, it worked
> >>> well
> >>> there, too.
> >>>
> >>>
> >>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
> >>> o.b.fischer@swe-blog.net> wrote:
> >>>
> >>>
> >>
> >>
> > --
> > N Oliver B. Fischer
> > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> > P +49 30 44793251
> > M +49 178 7903538
> > E o.b.fischer@swe-blog.net
> > S oliver.b.fischer
> > J oliver.b.fischer@jabber.org
> > X http://xing.to/obf
> >
> >
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79*
>
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
You have to see, JSR 308 (Type Annotations) is so far a blunt failure and
nobody uses them or tries to bring life back to 305 (where the same EG
members were involved that tinkered on 308) Even Oracle's own core Java
architects (I asked Brian Goetz at least once or twice about it in recent
years) said they have no plan to add default annotations to Java and given
the Modularity focus of Java 9 it doesn't seem like any of that comes to
Java 9 either. Nor does NetBeans support it, and Java 8 added a totally
different concept with Optional to help avoid nullness.
Except Guava I am not aware of any common project or framework that uses
it, so unless Java adds more support by reviving 305 or a new JSR for this,
it's dead and not worth carrying around.
Werner
On Wed, Feb 11, 2015 at 1:00 PM, Anatole Tresch <at...@gmail.com> wrote:
> maybe that's ok for Google, but not for me. We should really minimize the
> deps, and as I said adding deps just of a tool, then the tool is broken
> IMO.
> And adding a production dependency is quite a harsh thing, it must be well
> legitimated IMO, which in our case I do not see it. We can use FindBugs
> plugin and the other quality tools (e.g. Sonar), from my experience this is
> far enough. Finally most of the checks can be covered by writing tests as
> well...
>
> 2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>
> > For Google Guava it works quite well... Why not for us?
> >
> > Am 11.02.15 um 12:15 schrieb Anatole Tresch:
> >
> >> And as I said you add an additional dependency to your production code,
> >> which is not necessary. For me an absolute no-go...
> >>
> >>
> >> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
> >>
> >> Well as Anatole said it seems just a single place.
> >>> Why just there and is there significant value using it in many places?
> >>>
> >>> I've used the FindBugs plugin a lot without the annotations, it worked
> >>> well
> >>> there, too.
> >>>
> >>>
> >>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
> >>> o.b.fischer@swe-blog.net> wrote:
> >>>
> >>>
> >>
> >>
> > --
> > N Oliver B. Fischer
> > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> > P +49 30 44793251
> > M +49 178 7903538
> > E o.b.fischer@swe-blog.net
> > S oliver.b.fischer
> > J oliver.b.fischer@jabber.org
> > X http://xing.to/obf
> >
> >
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79*
>
Re: findbugs annotations
Posted by Anatole Tresch <at...@gmail.com>.
maybe that's ok for Google, but not for me. We should really minimize the
deps, and as I said adding deps just of a tool, then the tool is broken IMO.
And adding a production dependency is quite a harsh thing, it must be well
legitimated IMO, which in our case I do not see it. We can use FindBugs
plugin and the other quality tools (e.g. Sonar), from my experience this is
far enough. Finally most of the checks can be covered by writing tests as
well...
2015-02-11 12:47 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
> For Google Guava it works quite well... Why not for us?
>
> Am 11.02.15 um 12:15 schrieb Anatole Tresch:
>
>> And as I said you add an additional dependency to your production code,
>> which is not necessary. For me an absolute no-go...
>>
>>
>> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
>>
>> Well as Anatole said it seems just a single place.
>>> Why just there and is there significant value using it in many places?
>>>
>>> I've used the FindBugs plugin a lot without the annotations, it worked
>>> well
>>> there, too.
>>>
>>>
>>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
>>> o.b.fischer@swe-blog.net> wrote:
>>>
>>>
>>
>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: findbugs annotations
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
For Google Guava it works quite well... Why not for us?
Am 11.02.15 um 12:15 schrieb Anatole Tresch:
> And as I said you add an additional dependency to your production code,
> which is not necessary. For me an absolute no-go...
>
>
> 2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
>
>> Well as Anatole said it seems just a single place.
>> Why just there and is there significant value using it in many places?
>>
>> I've used the FindBugs plugin a lot without the annotations, it worked well
>> there, too.
>>
>>
>> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
>> o.b.fischer@swe-blog.net> wrote:
>>
>
>
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: findbugs annotations
Posted by Anatole Tresch <at...@gmail.com>.
And as I said you add an additional dependency to your production code,
which is not necessary. For me an absolute no-go...
2015-02-11 12:06 GMT+01:00 Werner Keil <we...@gmail.com>:
> Well as Anatole said it seems just a single place.
> Why just there and is there significant value using it in many places?
>
> I've used the FindBugs plugin a lot without the annotations, it worked well
> there, too.
>
>
> On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
> o.b.fischer@swe-blog.net> wrote:
>
> > We use it. The annotations help FindBugs to detect problems.
> >
> > Am 11.02.15 um 11:43 schrieb Werner Keil:
> >
> >> +1
> >> 305 is quite a dead JSR after all.
> >>
> >> If we need Findbugs, why not use the proper Maven FindBugs plugin
> >> http://mojo.codehaus.org/findbugs-maven-plugin/
> >>
> >> Werner
> >>
> >>
> >>
> >>
> >> On Wed, Feb 11, 2015 at 10:43 AM, Oliver B. Fischer <
> >> o.b.fischer@swe-blog.net> wrote:
> >>
> >> -1
> >>>
> >>> Am 11.02.15 um 09:38 schrieb Romain Manni-Bucau:
> >>>
> >>> +1
> >>> --
> >>> N Oliver B. Fischer
> >>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> >>> P +49 30 44793251
> >>> M +49 178 7903538
> >>> E o.b.fischer@swe-blog.net
> >>> S oliver.b.fischer
> >>> J oliver.b.fischer@jabber.org
> >>> X http://xing.to/obf
> >>>
> >>>
> >>>
> > --
> > N Oliver B. Fischer
> > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> > P +49 30 44793251
> > M +49 178 7903538
> > E o.b.fischer@swe-blog.net
> > S oliver.b.fischer
> > J oliver.b.fischer@jabber.org
> > X http://xing.to/obf
> >
> >
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
Well as Anatole said it seems just a single place.
Why just there and is there significant value using it in many places?
I've used the FindBugs plugin a lot without the annotations, it worked well
there, too.
On Wed, Feb 11, 2015 at 11:53 AM, Oliver B. Fischer <
o.b.fischer@swe-blog.net> wrote:
> We use it. The annotations help FindBugs to detect problems.
>
> Am 11.02.15 um 11:43 schrieb Werner Keil:
>
>> +1
>> 305 is quite a dead JSR after all.
>>
>> If we need Findbugs, why not use the proper Maven FindBugs plugin
>> http://mojo.codehaus.org/findbugs-maven-plugin/
>>
>> Werner
>>
>>
>>
>>
>> On Wed, Feb 11, 2015 at 10:43 AM, Oliver B. Fischer <
>> o.b.fischer@swe-blog.net> wrote:
>>
>> -1
>>>
>>> Am 11.02.15 um 09:38 schrieb Romain Manni-Bucau:
>>>
>>> +1
>>> --
>>> N Oliver B. Fischer
>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>> P +49 30 44793251
>>> M +49 178 7903538
>>> E o.b.fischer@swe-blog.net
>>> S oliver.b.fischer
>>> J oliver.b.fischer@jabber.org
>>> X http://xing.to/obf
>>>
>>>
>>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
Re: findbugs annotations
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
We use it. The annotations help FindBugs to detect problems.
Am 11.02.15 um 11:43 schrieb Werner Keil:
> +1
> 305 is quite a dead JSR after all.
>
> If we need Findbugs, why not use the proper Maven FindBugs plugin
> http://mojo.codehaus.org/findbugs-maven-plugin/
>
> Werner
>
>
>
>
> On Wed, Feb 11, 2015 at 10:43 AM, Oliver B. Fischer <
> o.b.fischer@swe-blog.net> wrote:
>
>> -1
>>
>> Am 11.02.15 um 09:38 schrieb Romain Manni-Bucau:
>>
>> +1
>> --
>> N Oliver B. Fischer
>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>> P +49 30 44793251
>> M +49 178 7903538
>> E o.b.fischer@swe-blog.net
>> S oliver.b.fischer
>> J oliver.b.fischer@jabber.org
>> X http://xing.to/obf
>>
>>
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: findbugs annotations
Posted by Werner Keil <we...@gmail.com>.
+1
305 is quite a dead JSR after all.
If we need Findbugs, why not use the proper Maven FindBugs plugin
http://mojo.codehaus.org/findbugs-maven-plugin/
Werner
On Wed, Feb 11, 2015 at 10:43 AM, Oliver B. Fischer <
o.b.fischer@swe-blog.net> wrote:
> -1
>
> Am 11.02.15 um 09:38 schrieb Romain Manni-Bucau:
>
> +1
>>
>>
>> Romain Manni-Bucau
>> @rmannibucau
>> http://www.tomitribe.com
>> http://rmannibucau.wordpress.com
>> https://github.com/rmannibucau
>>
>>
>> 2015-02-11 9:34 GMT+01:00 Anatole Tresch <at...@gmail.com>:
>>
>>> Dear all
>>>
>>> I am not sure where we stopped our discussions along removing
>>> the¨dependency to
>>>
>>> <dependency>
>>> <groupId>com.google.code.findbugs</groupId>
>>> <artifactId>jsr305</artifactId>
>>> </dependency>
>>>
>>> Currently its only used at one single location and IMO I do not want have
>>> any dependency on a tool in the code. So I would remove it, if nobody
>>> complains...
>>>
>>> Best
>>> Anatole
>>>
>>>
>>> --
>>> *Anatole Tresch*
>>> Java Engineer & Architect, JSR Spec Lead
>>> Glärnischweg 10
>>> CH - 8620 Wetzikon
>>>
>>> *Switzerland, Europe Zurich, GMT+1*
>>> *Twitter: @atsticks*
>>> *Blogs: **http://javaremarkables.blogspot.ch/
>>> <http://javaremarkables.blogspot.ch/>*
>>>
>>> *Google: atsticksMobile +41-76 344 62 79*
>>>
>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
Re: findbugs annotations
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
-1
Am 11.02.15 um 09:38 schrieb Romain Manni-Bucau:
> +1
>
>
> Romain Manni-Bucau
> @rmannibucau
> http://www.tomitribe.com
> http://rmannibucau.wordpress.com
> https://github.com/rmannibucau
>
>
> 2015-02-11 9:34 GMT+01:00 Anatole Tresch <at...@gmail.com>:
>> Dear all
>>
>> I am not sure where we stopped our discussions along removing
>> the¨dependency to
>>
>> <dependency>
>> <groupId>com.google.code.findbugs</groupId>
>> <artifactId>jsr305</artifactId>
>> </dependency>
>>
>> Currently its only used at one single location and IMO I do not want have
>> any dependency on a tool in the code. So I would remove it, if nobody
>> complains...
>>
>> Best
>> Anatole
>>
>>
>> --
>> *Anatole Tresch*
>> Java Engineer & Architect, JSR Spec Lead
>> Glärnischweg 10
>> CH - 8620 Wetzikon
>>
>> *Switzerland, Europe Zurich, GMT+1*
>> *Twitter: @atsticks*
>> *Blogs: **http://javaremarkables.blogspot.ch/
>> <http://javaremarkables.blogspot.ch/>*
>>
>> *Google: atsticksMobile +41-76 344 62 79*
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: findbugs annotations
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1
Romain Manni-Bucau
@rmannibucau
http://www.tomitribe.com
http://rmannibucau.wordpress.com
https://github.com/rmannibucau
2015-02-11 9:34 GMT+01:00 Anatole Tresch <at...@gmail.com>:
> Dear all
>
> I am not sure where we stopped our discussions along removing
> the¨dependency to
>
> <dependency>
> <groupId>com.google.code.findbugs</groupId>
> <artifactId>jsr305</artifactId>
> </dependency>
>
> Currently its only used at one single location and IMO I do not want have
> any dependency on a tool in the code. So I would remove it, if nobody
> complains...
>
> Best
> Anatole
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79*