[jira] [Commented] (KAFKA-1635) Java doc of makeLeaders in ReplicaManager is wrong

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135135#comment-14135135 ] 

ASF GitHub Bot commented on KAFKA-1635:
---------------------------------------

GitHub user LantaoJin opened a pull request:

    https://github.com/apache/kafka/pull/33

    KAFKA-1635: Fixed incorrect java doc of makeLeaders() in ReplicaManager

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LantaoJin/kafka KAFKA-1635

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #33
    
----
commit 6739a8e601331ad07d9856dc351785351755a5d5
Author: LantaoJin <la...@dianping.com>
Date:   2014-09-16T08:26:34Z

    KAFKA-1635: Fixed incorrect java doc of makeLeaders() in ReplicaManager

----


> Java doc of makeLeaders in ReplicaManager is wrong
> --------------------------------------------------
>
>                 Key: KAFKA-1635
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1635
>             Project: Kafka
>          Issue Type: Bug
>          Components: core, replication
>            Reporter: Lantao Jin
>            Assignee: Neha Narkhede
>            Priority: Minor
>              Labels: doc, server
>         Attachments: kafka-1635-1.patch
>
>
> ReplicaManager have an incorrect java doc. The overview of function  makeLeaders() is the same as makeFollowers().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)