[GitHub] sciabarracom commented on a change in pull request #1006: go-runtime

[GitBox <gi...@apache.org>]

sciabarracom commented on a change in pull request #1006: go-runtime
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1006#discussion_r230600700
 
 

 ##########
 File path: runtimes/runtimes_test.go
 ##########
 @@ -30,9 +31,12 @@ func TestParseOpenWhisk(t *testing.T) {
 	converted := ConvertToMap(openwhisk)
 	println(converted["nodejs"])
 	println(converted["python"])
+	//println(converted["go"])
 	assert.Equal(t, 2, len(converted["nodejs"]), "not expected length")
 	assert.Equal(t, 2, len(converted["php"]), "not expected length")
 	assert.Equal(t, 1, len(converted["java"]), "not expected length")
 	assert.Equal(t, 6, len(converted["python"]), "not expected length")
 	assert.Equal(t, 2, len(converted["swift"]), "not expected length")
+	// cannot pass this test until it is deployed in OpenWhisk
 
 Review comment:
   The test looks like it tries to parse BlueMix runtime.json, and it fails

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services