You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2013/01/17 08:46:14 UTC

[jira] [Resolved] (WICKET-4983) extra recursion on Wicket.DOM.get

     [ https://issues.apache.org/jira/browse/WICKET-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4983.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 6.5.0
         Assignee: Martin Grigorov

Those are actually the same.
Wicket.$ is just an alias to Wicket.DOM.get.
I've applied the change because it avoids one step in the stack.
Thanks!
                
> extra recursion on Wicket.DOM.get
> ---------------------------------
>
>                 Key: WICKET-4983
>                 URL: https://issues.apache.org/jira/browse/WICKET-4983
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 6.4.0
>            Reporter: Ernesto Reinaldo Barreiro
>            Assignee: Martin Grigorov
>            Priority: Trivial
>             Fix For: 6.5.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Any reason for DOM.get not being like
> get: function (arg) {
> 				if (isUndef(arg)) {
> 					return null;
> 				}
> 				if (arguments.length > 1) {
> 					var e = [];
> 					for (var i = 0; i < arguments.length; i++) {
> 						e.push(get(arguments[i]));
> 					}
> 					return e;
> 				} else if (typeof arg === 'string') {
> 					return document.getElementById(arg);
> 				} else {
> 					return arg;
> 				}
> instead of
>        
> get: function (arg) {
> 				if (isUndef(arg)) {
> 					return null;
> 				}
> 				if (arguments.length > 1) {
> 					var e = [];
> 					for (var i = 0; i < arguments.length; i++) {
> 						e.push(Wicket.$(arguments[i]));
> 					}
> 					return e;
> 				} else if (typeof arg === 'string') {
> 					return document.getElementById(arg);
> 				} else {
> 					return arg;
> 				}
> ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira