You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by arunmahadevan <gi...@git.apache.org> on 2016/03/28 10:59:04 UTC
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1269
[STORM-1544] Document Debug/Sampling of Topologies
Added documentation for logging/sampling events in a topology.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm STORM-1544
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1269
----
commit 9dfe488a4dfaeadcd55cd7e5715eb8782ea036b2
Author: Arun Mahadevan <ai...@hortonworks.com>
Date: 2016-03-28T08:49:31Z
[STORM-1544] Document Debug/Sampling of Topologies
Added documentation for logging/sampling events in a topology.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202525621
@revans2 we should add redirection from downloads.html to release.html.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202512108
@revans2 Okay. I didn't realize that had changed, I'm okay with either approach.
One thing I did notice is that the documentation dropdown is missing from the home page, and the downloads page is now a 404.
(sorry for hijacking this pull request)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202422084
+1
I think we can add a note about performance issue regarding #1217 when we're sure it does have performance hit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-204244154
@ptgoetz updated the doc to reflect the new (disabled by default) behavior. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202531899
@revans2 It was a caching issue. Sorry for the noise.
I agree with @harshach, we may want to consider a redirect from downloads.html to release.html to keep from breaking external links and bookmarks.
I think we need to add a link to the KEYS file for releases, and it might help to add maven information like we did in the old downloads page.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202505790
@ptgoetz Not for the release specific docs. At least I didn't end up setting it up that way, and so if I missed something, then I am happy to go back and try and fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202469629
It looks good can we add a link to this in docs/index.md as well? Otherwise it will not be easy to find in the UI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202522582
@ptgoetz I didn't realize that we were generating an index using the docs tag. I am happy to go back and add something in again for it.
Also everything is working fine for me. what browser are you using? is there something in your cache that is messed up? Just FYI I renamed the download.html to releases.html, because it includes more then just download links, but the download button points to the proper place. I am happy to revert that change too if you had other stuff pointing to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202704798
@revans2 @ptgoetz added a link in docs/index.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-203605038
@arunmahadevan That's likely a typo or formatting error in the markdown file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-204250943
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202503186
@revans2 The yaml front matter `documentation: true` should take care of that.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202728833
+1 again.
I think we can grep issues on website and raise an issue to follow up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1544] Document Debug/Sampling of Topolo...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202733505
Appears that some html pages are broken. E.g. http://storm.apache.org/releases/1.0.0-SNAPSHOT/State-checkpointing.html beyond the section "IStateful bolt hooks", the formatting and sections headings are lost. Do we need to fix something in the scripts that generate the html files ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---