You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "nddipiazza (via GitHub)" <gi...@apache.org> on 2026/05/12 20:23:11 UTC
[PR] TIKA-4723 follow-up: fix sqlite3 shade filter and correct docs [tika]
nddipiazza opened a new pull request, #2810:
URL: https://github.com/apache/tika/pull/2810
## Summary
Follow-up fixes for [TIKA-4723](https://issues.apache.org/jira/browse/TIKA-4723) (merged via #2809).
## Changes
### 1. `tika-parser-sqlite3-package/pom.xml` — align shade filter with sister packages
The `maven-shade-plugin` filter in `tika-parser-sqlite3-package` was missing three exclusions present in both `tika-parser-scientific-package` and `tika-parser-nlp-package`:
- `module-info.class` — without this exclusion, shading multiple deps that each carry a `module-info.class` causes a duplicate-entry error in the shaded jar on Java 9+.
- `META-INF/LICENSE.md` — duplicate clutter; the `ApacheLicenseResourceTransformer` already handles the text-format `LICENSE`.
- `META-INF/NOTICE.md` — same rationale as `LICENSE.md`.
### 2. `docs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adoc` — fix incorrect TikaConfigException claim
The doc said:
> _tika-grpc requires at least one pf4j plugin to be loaded at startup; an empty `plugins/` directory triggers a `TikaConfigException` with a download URL pointing at Apache dist._
This is factually wrong. `TikaGrpcServerImpl` (line 133) logs a `LOG.warn` when `pluginManager.getPlugins().isEmpty()` — it does **not** throw a `TikaConfigException`. The server continues to start; fetcher-dependent RPC calls simply fail at runtime. Corrected the description to match the actual code path.
## Review Focus Areas
- `tika-parser-sqlite3-package/pom.xml` shade `<filters>` block — confirm the three new exclusions are correct and complete.
- `release-artifacts.adoc` paragraph about empty plugins — confirm the new wording accurately reflects startup behaviour.
## Critical Files
- `tika-parsers/tika-parsers-extended/tika-parser-sqlite3-package/pom.xml`
- `docs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adoc`
## Testing Instructions
```bash
# Verify the sqlite3 shaded jar builds without duplicate module-info errors
mvn package -pl tika-parsers/tika-parsers-extended/tika-parser-sqlite3-package -am -DskipTests
# Confirm shaded jar exists and no module-info duplication
jar tf tika-parsers/tika-parsers-extended/tika-parser-sqlite3-package/target/tika-parser-sqlite3-package-*-shaded.jar \
| grep -c module-info # should be 0
```
## Review Checklist
- [ ] sqlite3 shade filter exclusions match scientific and nlp packages
- [ ] Docs accurately describe tika-grpc startup behaviour when no plugins loaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4723 follow-up: fix sqlite3 shade filter and correct docs [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #2810:
URL: https://github.com/apache/tika/pull/2810#issuecomment-4434894489
Looks good. Will take a look early tomorrow. Thank you!
This doesn't break anything for grpc, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4723 follow-up: fix sqlite3 shade filter and correct docs [tika]
Posted by "nddipiazza (via GitHub)" <gi...@apache.org>.
nddipiazza commented on PR #2810:
URL: https://github.com/apache/tika/pull/2810#issuecomment-4435132901
we have e2e tests @tballison i'll check to see how they are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4723 follow-up: fix sqlite3 shade filter and correct docs [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison merged PR #2810:
URL: https://github.com/apache/tika/pull/2810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4723 follow-up: fix sqlite3 shade filter and correct docs [tika]
Posted by "nddipiazza (via GitHub)" <gi...@apache.org>.
nddipiazza commented on PR #2810:
URL: https://github.com/apache/tika/pull/2810#issuecomment-4434488246
@tballison i reviewed your changes. found no issues. claude recommended this tiny stuff but i think we can close this pr unless you find value in that stuff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4723 follow-up: fix sqlite3 shade filter and correct docs [tika]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2810:
URL: https://github.com/apache/tika/pull/2810#discussion_r3230106518
##########
docs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adoc:
##########
@@ -170,9 +170,9 @@ plugins) locally; that build output is the build context for the
`apache/tika-grpc` image and isn't published as a release artifact in its
own right.
-tika-grpc requires at least one pf4j plugin to be loaded at startup; an
-empty `plugins/` directory triggers a `TikaConfigException` with a
-download URL pointing at Apache dist.
+tika-grpc requires at least one pf4j plugin to be loaded at startup; starting
+without plugins logs a `LOG.warn` with a download URL pointing at Apache dist.
+Fetcher-dependent RPC calls will fail at runtime if no plugins are present.
Review Comment:
The updated wording still says "tika-grpc requires at least one pf4j plugin to be loaded at startup", but `TikaGrpcServerImpl` explicitly allows an empty plugin set and only logs a warning when `pluginManager.getPlugins().isEmpty()` (server continues to start). Consider rephrasing to something like "tika-grpc expects plugins for full functionality" / "most RPC calls require plugins" and describe that it "logs a warning" (rather than referring to the `LOG.warn` call) to avoid implying startup will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org