You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "vasily.v.levchenko@gmail.com (JIRA)" <ji...@apache.org> on 2007/08/03 14:39:53 UTC
[jira] Created: (HARMONY-4599) Jitrino dublicates segment override
prefix in TLS helper for Win/x86
Jitrino dublicates segment override prefix in TLS helper for Win/x86
---------------------------------------------------------------------
Key: HARMONY-4599
URL: https://issues.apache.org/jira/browse/HARMONY-4599
Project: Harmony
Issue Type: Bug
Components: DRLVM
Environment: x86/Windows Server 2003
Harmony VM:r559723
Reporter: vasily.v.levchenko@gmail.com
Priority: Trivial
Hi folks,
I've noticed that Jitrino duplicate the segment override prefix in TLS related templates:
0x00000000237f0f7d 81ea02000000 sub edx,2
0x00000000237f0f83 89542458 mov dword ptr [esp+58h],edx
0x00000000237f0f87 64 ???
0x00000000237f0f88 648b1514000000 mov edx,dword ptr fs:[14h]
0x00000000237f0f8f 81c204000000 add edx,4
Harmony build: r559723
Should be:
81ea02000000 sub edx,2
89542458 mov dword ptr [esp+58h],edx
648b1514000000 mov edx,dword ptr fs:[14h]
81c204000000 add edx,4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4599) [drlvm][jit][opt]Jitrino dublicates
segment override prefix in TLS helper for Win/x86
Posted by "vasily.v.levchenko@gmail.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
vasily.v.levchenko@gmail.com resolved HARMONY-4599.
---------------------------------------------------
Resolution: Fixed
Seems ok, some questions to the patch see previous comment
> [drlvm][jit][opt]Jitrino dublicates segment override prefix in TLS helper for Win/x86
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-4599
> URL: https://issues.apache.org/jira/browse/HARMONY-4599
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: x86/Windows Server 2003
> Harmony VM:r559723
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
> Attachments: double_tls_access.patch
>
>
> Hi folks,
> I've noticed that Jitrino duplicate the segment override prefix in TLS related templates:
> 0x00000000237f0f7d 81ea02000000 sub edx,2
> 0x00000000237f0f83 89542458 mov dword ptr [esp+58h],edx
> 0x00000000237f0f87 64 ???
> 0x00000000237f0f88 648b1514000000 mov edx,dword ptr fs:[14h]
> 0x00000000237f0f8f 81c204000000 add edx,4
> Harmony build: r559723
> Should be:
> 81ea02000000 sub edx,2
> 89542458 mov dword ptr [esp+58h],edx
> 648b1514000000 mov edx,dword ptr fs:[14h]
> 81c204000000 add edx,4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4599) Jitrino dublicates segment override
prefix in TLS helper for Win/x86
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov reassigned HARMONY-4599:
---------------------------------------
Assignee: Mikhail Fursov
> Jitrino dublicates segment override prefix in TLS helper for Win/x86
> ---------------------------------------------------------------------
>
> Key: HARMONY-4599
> URL: https://issues.apache.org/jira/browse/HARMONY-4599
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: x86/Windows Server 2003
> Harmony VM:r559723
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
>
> Hi folks,
> I've noticed that Jitrino duplicate the segment override prefix in TLS related templates:
> 0x00000000237f0f7d 81ea02000000 sub edx,2
> 0x00000000237f0f83 89542458 mov dword ptr [esp+58h],edx
> 0x00000000237f0f87 64 ???
> 0x00000000237f0f88 648b1514000000 mov edx,dword ptr fs:[14h]
> 0x00000000237f0f8f 81c204000000 add edx,4
> Harmony build: r559723
> Should be:
> 81ea02000000 sub edx,2
> 89542458 mov dword ptr [esp+58h],edx
> 648b1514000000 mov edx,dword ptr fs:[14h]
> 81c204000000 add edx,4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4599) [drlvm][jit][opt]Jitrino dublicates
segment override prefix in TLS helper for Win/x86
Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgueni Brevnov updated HARMONY-4599:
-------------------------------------
Attachment: double_tls_access.patch
Attached patch has been tested on Win2003. Smoke tests & SpecJBB2005 passed successfully. Emitter doesn't duplicate prefix for segment registers access any more.
> [drlvm][jit][opt]Jitrino dublicates segment override prefix in TLS helper for Win/x86
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-4599
> URL: https://issues.apache.org/jira/browse/HARMONY-4599
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: x86/Windows Server 2003
> Harmony VM:r559723
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
> Attachments: double_tls_access.patch
>
>
> Hi folks,
> I've noticed that Jitrino duplicate the segment override prefix in TLS related templates:
> 0x00000000237f0f7d 81ea02000000 sub edx,2
> 0x00000000237f0f83 89542458 mov dword ptr [esp+58h],edx
> 0x00000000237f0f87 64 ???
> 0x00000000237f0f88 648b1514000000 mov edx,dword ptr fs:[14h]
> 0x00000000237f0f8f 81c204000000 add edx,4
> Harmony build: r559723
> Should be:
> 81ea02000000 sub edx,2
> 89542458 mov dword ptr [esp+58h],edx
> 648b1514000000 mov edx,dword ptr fs:[14h]
> 81c204000000 add edx,4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4599) [drlvm][jit][opt]Jitrino dublicates
segment override prefix in TLS helper for Win/x86
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov updated HARMONY-4599:
------------------------------------
Summary: [drlvm][jit][opt]Jitrino dublicates segment override prefix in TLS helper for Win/x86 (was: Jitrino dublicates segment override prefix in TLS helper for Win/x86 )
> [drlvm][jit][opt]Jitrino dublicates segment override prefix in TLS helper for Win/x86
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-4599
> URL: https://issues.apache.org/jira/browse/HARMONY-4599
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: x86/Windows Server 2003
> Harmony VM:r559723
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
>
> Hi folks,
> I've noticed that Jitrino duplicate the segment override prefix in TLS related templates:
> 0x00000000237f0f7d 81ea02000000 sub edx,2
> 0x00000000237f0f83 89542458 mov dword ptr [esp+58h],edx
> 0x00000000237f0f87 64 ???
> 0x00000000237f0f88 648b1514000000 mov edx,dword ptr fs:[14h]
> 0x00000000237f0f8f 81c204000000 add edx,4
> Harmony build: r559723
> Should be:
> 81ea02000000 sub edx,2
> 89542458 mov dword ptr [esp+58h],edx
> 648b1514000000 mov edx,dword ptr fs:[14h]
> 81c204000000 add edx,4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4599) [drlvm][jit][opt]Jitrino
dublicates segment override prefix in TLS helper for Win/x86
Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519378 ]
Evgueni Brevnov commented on HARMONY-4599:
------------------------------------------
I agree style fixes would better be separated. In this particular case I don't think one line style fix complicates patch review a lot.
Thank you. Evgueni
> [drlvm][jit][opt]Jitrino dublicates segment override prefix in TLS helper for Win/x86
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-4599
> URL: https://issues.apache.org/jira/browse/HARMONY-4599
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: x86/Windows Server 2003
> Harmony VM:r559723
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
> Attachments: double_tls_access.patch
>
>
> Hi folks,
> I've noticed that Jitrino duplicate the segment override prefix in TLS related templates:
> 0x00000000237f0f7d 81ea02000000 sub edx,2
> 0x00000000237f0f83 89542458 mov dword ptr [esp+58h],edx
> 0x00000000237f0f87 64 ???
> 0x00000000237f0f88 648b1514000000 mov edx,dword ptr fs:[14h]
> 0x00000000237f0f8f 81c204000000 add edx,4
> Harmony build: r559723
> Should be:
> 81ea02000000 sub edx,2
> 89542458 mov dword ptr [esp+58h],edx
> 648b1514000000 mov edx,dword ptr fs:[14h]
> 81c204000000 add edx,4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4599) [drlvm][jit][opt]Jitrino
dublicates segment override prefix in TLS helper for Win/x86
Posted by "vasily.v.levchenko@gmail.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518231 ]
vasily.v.levchenko@gmail.com commented on HARMONY-4599:
-------------------------------------------------------
Hello Evgueni,
It's seams ok.
Some comments to patch
-227,11 +227,13 @@
break;
case OpndKind_Mem:
{
Possibly it's better to remove the code, then coment it
+ /*
RegName segReg = p->getSegReg();
if (segReg == RegName_FS) {
stream = (uint8*)EncoderBase::prefix((char*)stream,
InstPrefix_FS);
}
+ */
....
@@ -287,7 +290,7 @@
}
Possibly it's better to separate syntax patches from bug fixing?
//emit inst prefix
- if (inst->getPrefix()!=InstPrefix_Null) {
+ if (inst->getPrefix() != InstPrefix_Null) {
stream = (uint8*)EncoderBase::prefix((char*)stream, inst->getPrefix());
}
return (uint8*)EncoderBase::encode((char*)stream, mnemonic, args);
> [drlvm][jit][opt]Jitrino dublicates segment override prefix in TLS helper for Win/x86
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-4599
> URL: https://issues.apache.org/jira/browse/HARMONY-4599
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: x86/Windows Server 2003
> Harmony VM:r559723
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
> Attachments: double_tls_access.patch
>
>
> Hi folks,
> I've noticed that Jitrino duplicate the segment override prefix in TLS related templates:
> 0x00000000237f0f7d 81ea02000000 sub edx,2
> 0x00000000237f0f83 89542458 mov dword ptr [esp+58h],edx
> 0x00000000237f0f87 64 ???
> 0x00000000237f0f88 648b1514000000 mov edx,dword ptr fs:[14h]
> 0x00000000237f0f8f 81c204000000 add edx,4
> Harmony build: r559723
> Should be:
> 81ea02000000 sub edx,2
> 89542458 mov dword ptr [esp+58h],edx
> 648b1514000000 mov edx,dword ptr fs:[14h]
> 81c204000000 add edx,4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.