You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Sean Schofield <se...@gmail.com> on 2006/06/01 19:48:00 UTC
Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
I set up a new branch[1] for performing the maven reorg for shale as
we discussed in the other thread. For now lets reorg everything as if
we are using a single "trunk" for all of the shale modules. It will
be easier to reorg this way for now and if we decide to break them out
we can do that after we have a working maven build.
The next step is to replicate all of the changes Wendy made using her
script. I need to leave the office for a few hours but if nobody does
this while I'm gone I will see what I can do. We'll also need to copy
over the poms from the test repo since these are our only copies.
Just remember to commit any shale fixes to the branch instead of the
trunk. If its an urgent fix, commit them to both. Do all of the
reorg stuff here in this branch and don't worry about updating scripts
from here on out. This will be the real source code once we're done.
I think this captures the plan we all agreed to. Let me know if I'm
missing something.
Sean
[1] http://svn.apache.org/repos/asf/struts/shale/branches/mvn_reorg/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
I would venture a guess that you've copied your keys to ~/svn/
authorized_keys on minotaur. I do the same (usually).
--
James Mitchell
On Jun 2, 2006, at 12:48 AM, Wendy Smoak wrote:
> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>> In fact, here's my config (passwords not included ;)
>>
>> <settings>
>> <servers>
>> <server>
>> <id>apache-maven-releases</id>
>> <username>jmitchell</username>
>> <privateKey>/home/jmitchell/.ssh/id_dsa</privateKey>
>> <password>(password for my apache acct)</password>
> ...
>
> We also have suggested settings here:
> http://wiki.apache.org/struts/StrutsMaintenanceMaven
> (I think, the page won't load just now.)
>
> FWIW, mine works fine (deploying the site and artifacts) with just the
> private key, no <password>.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, James Mitchell <jm...@apache.org> wrote:
> In fact, here's my config (passwords not included ;)
>
> <settings>
> <servers>
> <server>
> <id>apache-maven-releases</id>
> <username>jmitchell</username>
> <privateKey>/home/jmitchell/.ssh/id_dsa</privateKey>
> <password>(password for my apache acct)</password>
...
We also have suggested settings here:
http://wiki.apache.org/struts/StrutsMaintenanceMaven
(I think, the page won't load just now.)
FWIW, mine works fine (deploying the site and artifacts) with just the
private key, no <password>.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
In fact, here's my config (passwords not included ;)
<settings>
<servers>
<server>
<id>apache-maven-releases</id>
<username>jmitchell</username>
<privateKey>/home/jmitchell/.ssh/id_dsa</privateKey>
<password>(password for my apache acct)</password>
</server>
<server>
<id>apache-maven-snapshots</id>
<username>jmitchell</username>
<privateKey>/home/jmitchell/.ssh/id_dsa</privateKey>
<password>(password for my apache acct)</password>
</server>
<server>
<id>apache-maven-test-builds</id>
<username>jmitchell</username>
<privateKey>/home/jmitchell/.ssh/id_dsa</privateKey>
<password>(password for my apache acct)</password>
</server>
<server>
<id>apache-site</id>
<username>jmitchell</username>
<privateKey>/home/jmitchell/.ssh/id_dsa</privateKey>
<password>(password for my apache acct)</password>
</server>
<server>
<id>sf-net</id>
<username>james-mitchell</username>
<privateKey>/home/jmitchell/.ssh/id_dsa</privateKey>
<password>(password for my sf.net acct)</password>
</server>
</servers>
<profiles>
<profile>
<id>cargo-config</id>
<properties>
<cargo.tomcat5x.home>/home/jmitchell/apache_home/apache-
tomcat-5.5.16</cargo.tomcat5x.home>
<cargo.tomcat4x.home>/home/jmitchell/apache_home/jakarta-
tomcat-4.1.31</cargo.tomcat4x.home>
</properties>
</profile>
</profiles>
<activeProfiles>
<activeProfile>cargo-config</activeProfile>
</activeProfiles>
</settings>
--
James Mitchell
On Jun 2, 2006, at 12:39 AM, James Mitchell wrote:
> I keep mine here:
>
> ~/.m2/settings.xml
>
>
> --
> James Mitchell
>
>
>
>
> On Jun 2, 2006, at 12:38 AM, Craig McClanahan wrote:
>
>> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>>>
>>> Is this what you need?
>>>
>>> http://maven.apache.org/guides/mini/guide-proxies.html
>>
>>
>> Yes! Thanks ... but it leads to a stupid newbie question ...
>> where's the
>> user settings file go? :-)
>>
>> --
>>> James Mitchell
>>
>>
>> Craig
>>
>> On Jun 2, 2006, at 12:31 AM, Craig McClanahan wrote:
>>>
>>> > On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>>> >>
>>> >> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>>> >>
>>> >> > I ran all but the tiger script. There are a ton of errors
>>> still in
>>> >> > the core tests but we're making progress.
>>> >> >
>>> >> > One problem seems to be with AbstractJsfTestCase and a null
>>> pointer
>>> >> > when referencing the servletContext variable from a
>>> subclass. My
>>> >> > guess is that there is a missing configuration resource.
>>> >> >
>>> >> > @Craig: Any ideas? Try running mvn -Pmyfaces test and then
>>> >> examine
>>> >> > the output in target. All of the necessary resource files
>>> >> shoudl be
>>> >> > in the classes or test-classes dirs. If not, then we missed
>>> >> > something.
>>> >>
>>> >>
>>> >> I'll pull the mvn_reorg stuff and check this out.
>>> >>
>>> >
>>> > @Sean/@Wendy:
>>> >
>>> > Is there any way to teach Maven to use an HTTP proxy when it
>>> does it's
>>> > dependency downloads, like you can tell Subversion to? I spend
>>> > most of my
>>> > time connected to Sun's VPN network, and right now I have to
>>> > disconnect from
>>> > that to do the Maven stuff -- not fatal, but it's sure a pain.
>>> >
>>> > Sean
>>> >>
>>> >>
>>> > Craig
>>> >
>>> > Craig
>>> >>
>>> >> On 6/1/06, Wendy Smoak < wsmoak@gmail.com> wrote:
>>> >> > > On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>>> >> > >
>>> >> > > > So I can run svn move foo/bar foo/buzz locally and then
>>> >> commit foo?
>>> >> > > > This is the same as svn move https://foo.com/foo/bar
>>> >> > > > https://foo.com/foo/buzz?
>>> >> > >
>>> >> > > Yes, exactly the same. The advantage is that you can do
>>> multiple
>>> >> > > commands locally, preview the results, and then commit all
>>> the
>>> >> changes
>>> >> > > at once.
>>> >> > >
>>> >> > > There are some limits, occasionally Subversion will complain
>>> >> that you
>>> >> > > need to commit before executing some command that you're
>>> >> trying to do.
>>> >> >
>>> >> > > (Which is why that first script is separate.)
>>> >> > >
>>> >> > > Whatever is easier for you, though, it ends up being the same
>>> >> when
>>> >> > you're done.
>>> >> > >
>>> >> > > --
>>> >> > > Wendy
>>> >> > >
>>> >> > >
>>> >>
>>> --------------------------------------------------------------------
>>> -
>>> >> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> > > For additional commands, e-mail: dev-help@struts.apache.org
>>> >> > >
>>> >> > >
>>> >> >
>>> >> >
>>> >>
>>> --------------------------------------------------------------------
>>> -
>>> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> > For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >
>>> >> >
>>> >>
>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>
> I keep mine here:
>
> ~/.m2/settings.xml
That did the trick ... thanks James!
--
> James Mitchell
Craig
On Jun 2, 2006, at 12:38 AM, Craig McClanahan wrote:
>
> > On 6/1/06, James Mitchell <jm...@apache.org> wrote:
> >>
> >> Is this what you need?
> >>
> >> http://maven.apache.org/guides/mini/guide-proxies.html
> >
> >
> > Yes! Thanks ... but it leads to a stupid newbie question ...
> > where's the
> > user settings file go? :-)
> >
> > --
> >> James Mitchell
> >
> >
> > Craig
> >
> > On Jun 2, 2006, at 12:31 AM, Craig McClanahan wrote:
> >>
> >> > On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> >> >>
> >> >> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> >> >>
> >> >> > I ran all but the tiger script. There are a ton of errors
> >> still in
> >> >> > the core tests but we're making progress.
> >> >> >
> >> >> > One problem seems to be with AbstractJsfTestCase and a null
> >> pointer
> >> >> > when referencing the servletContext variable from a
> >> subclass. My
> >> >> > guess is that there is a missing configuration resource.
> >> >> >
> >> >> > @Craig: Any ideas? Try running mvn -Pmyfaces test and then
> >> >> examine
> >> >> > the output in target. All of the necessary resource files
> >> >> shoudl be
> >> >> > in the classes or test-classes dirs. If not, then we missed
> >> >> > something.
> >> >>
> >> >>
> >> >> I'll pull the mvn_reorg stuff and check this out.
> >> >>
> >> >
> >> > @Sean/@Wendy:
> >> >
> >> > Is there any way to teach Maven to use an HTTP proxy when it
> >> does it's
> >> > dependency downloads, like you can tell Subversion to? I spend
> >> > most of my
> >> > time connected to Sun's VPN network, and right now I have to
> >> > disconnect from
> >> > that to do the Maven stuff -- not fatal, but it's sure a pain.
> >> >
> >> > Sean
> >> >>
> >> >>
> >> > Craig
> >> >
> >> > Craig
> >> >>
> >> >> On 6/1/06, Wendy Smoak < wsmoak@gmail.com> wrote:
> >> >> > > On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> >> >> > >
> >> >> > > > So I can run svn move foo/bar foo/buzz locally and then
> >> >> commit foo?
> >> >> > > > This is the same as svn move https://foo.com/foo/bar
> >> >> > > > https://foo.com/foo/buzz?
> >> >> > >
> >> >> > > Yes, exactly the same. The advantage is that you can do
> >> multiple
> >> >> > > commands locally, preview the results, and then commit all the
> >> >> changes
> >> >> > > at once.
> >> >> > >
> >> >> > > There are some limits, occasionally Subversion will complain
> >> >> that you
> >> >> > > need to commit before executing some command that you're
> >> >> trying to do.
> >> >> >
> >> >> > > (Which is why that first script is separate.)
> >> >> > >
> >> >> > > Whatever is easier for you, though, it ends up being the same
> >> >> when
> >> >> > you're done.
> >> >> > >
> >> >> > > --
> >> >> > > Wendy
> >> >> > >
> >> >> > >
> >> >>
> >> ---------------------------------------------------------------------
> >> >> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >> > > For additional commands, e-mail: dev-help@struts.apache.org
> >> >> > >
> >> >> > >
> >> >> >
> >> >> >
> >> >>
> >> ---------------------------------------------------------------------
> >> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >> > For additional commands, e-mail: dev-help@struts.apache.org
> >> >> >
> >> >> >
> >> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
I keep mine here:
~/.m2/settings.xml
--
James Mitchell
On Jun 2, 2006, at 12:38 AM, Craig McClanahan wrote:
> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>>
>> Is this what you need?
>>
>> http://maven.apache.org/guides/mini/guide-proxies.html
>
>
> Yes! Thanks ... but it leads to a stupid newbie question ...
> where's the
> user settings file go? :-)
>
> --
>> James Mitchell
>
>
> Craig
>
> On Jun 2, 2006, at 12:31 AM, Craig McClanahan wrote:
>>
>> > On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>> >>
>> >> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>> >>
>> >> > I ran all but the tiger script. There are a ton of errors
>> still in
>> >> > the core tests but we're making progress.
>> >> >
>> >> > One problem seems to be with AbstractJsfTestCase and a null
>> pointer
>> >> > when referencing the servletContext variable from a
>> subclass. My
>> >> > guess is that there is a missing configuration resource.
>> >> >
>> >> > @Craig: Any ideas? Try running mvn -Pmyfaces test and then
>> >> examine
>> >> > the output in target. All of the necessary resource files
>> >> shoudl be
>> >> > in the classes or test-classes dirs. If not, then we missed
>> >> > something.
>> >>
>> >>
>> >> I'll pull the mvn_reorg stuff and check this out.
>> >>
>> >
>> > @Sean/@Wendy:
>> >
>> > Is there any way to teach Maven to use an HTTP proxy when it
>> does it's
>> > dependency downloads, like you can tell Subversion to? I spend
>> > most of my
>> > time connected to Sun's VPN network, and right now I have to
>> > disconnect from
>> > that to do the Maven stuff -- not fatal, but it's sure a pain.
>> >
>> > Sean
>> >>
>> >>
>> > Craig
>> >
>> > Craig
>> >>
>> >> On 6/1/06, Wendy Smoak < wsmoak@gmail.com> wrote:
>> >> > > On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>> >> > >
>> >> > > > So I can run svn move foo/bar foo/buzz locally and then
>> >> commit foo?
>> >> > > > This is the same as svn move https://foo.com/foo/bar
>> >> > > > https://foo.com/foo/buzz?
>> >> > >
>> >> > > Yes, exactly the same. The advantage is that you can do
>> multiple
>> >> > > commands locally, preview the results, and then commit all the
>> >> changes
>> >> > > at once.
>> >> > >
>> >> > > There are some limits, occasionally Subversion will complain
>> >> that you
>> >> > > need to commit before executing some command that you're
>> >> trying to do.
>> >> >
>> >> > > (Which is why that first script is separate.)
>> >> > >
>> >> > > Whatever is easier for you, though, it ends up being the same
>> >> when
>> >> > you're done.
>> >> > >
>> >> > > --
>> >> > > Wendy
>> >> > >
>> >> > >
>> >>
>> ---------------------------------------------------------------------
>> >> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> > > For additional commands, e-mail: dev-help@struts.apache.org
>> >> > >
>> >> > >
>> >> >
>> >> >
>> >>
>> ---------------------------------------------------------------------
>> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> > For additional commands, e-mail: dev-help@struts.apache.org
>> >> >
>> >> >
>> >>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>
> Is this what you need?
>
> http://maven.apache.org/guides/mini/guide-proxies.html
Yes! Thanks ... but it leads to a stupid newbie question ... where's the
user settings file go? :-)
--
> James Mitchell
Craig
On Jun 2, 2006, at 12:31 AM, Craig McClanahan wrote:
>
> > On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> >>
> >> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> >>
> >> > I ran all but the tiger script. There are a ton of errors still in
> >> > the core tests but we're making progress.
> >> >
> >> > One problem seems to be with AbstractJsfTestCase and a null pointer
> >> > when referencing the servletContext variable from a subclass. My
> >> > guess is that there is a missing configuration resource.
> >> >
> >> > @Craig: Any ideas? Try running mvn -Pmyfaces test and then
> >> examine
> >> > the output in target. All of the necessary resource files
> >> shoudl be
> >> > in the classes or test-classes dirs. If not, then we missed
> >> > something.
> >>
> >>
> >> I'll pull the mvn_reorg stuff and check this out.
> >>
> >
> > @Sean/@Wendy:
> >
> > Is there any way to teach Maven to use an HTTP proxy when it does it's
> > dependency downloads, like you can tell Subversion to? I spend
> > most of my
> > time connected to Sun's VPN network, and right now I have to
> > disconnect from
> > that to do the Maven stuff -- not fatal, but it's sure a pain.
> >
> > Sean
> >>
> >>
> > Craig
> >
> > Craig
> >>
> >> On 6/1/06, Wendy Smoak < wsmoak@gmail.com> wrote:
> >> > > On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> >> > >
> >> > > > So I can run svn move foo/bar foo/buzz locally and then
> >> commit foo?
> >> > > > This is the same as svn move https://foo.com/foo/bar
> >> > > > https://foo.com/foo/buzz?
> >> > >
> >> > > Yes, exactly the same. The advantage is that you can do multiple
> >> > > commands locally, preview the results, and then commit all the
> >> changes
> >> > > at once.
> >> > >
> >> > > There are some limits, occasionally Subversion will complain
> >> that you
> >> > > need to commit before executing some command that you're
> >> trying to do.
> >> >
> >> > > (Which is why that first script is separate.)
> >> > >
> >> > > Whatever is easier for you, though, it ends up being the same
> >> when
> >> > you're done.
> >> > >
> >> > > --
> >> > > Wendy
> >> > >
> >> > >
> >> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> > > For additional commands, e-mail: dev-help@struts.apache.org
> >> > >
> >> > >
> >> >
> >> >
> >> ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> > For additional commands, e-mail: dev-help@struts.apache.org
> >> >
> >> >
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
Is this what you need?
http://maven.apache.org/guides/mini/guide-proxies.html
--
James Mitchell
On Jun 2, 2006, at 12:31 AM, Craig McClanahan wrote:
> On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>>
>> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>>
>> > I ran all but the tiger script. There are a ton of errors still in
>> > the core tests but we're making progress.
>> >
>> > One problem seems to be with AbstractJsfTestCase and a null pointer
>> > when referencing the servletContext variable from a subclass. My
>> > guess is that there is a missing configuration resource.
>> >
>> > @Craig: Any ideas? Try running mvn -Pmyfaces test and then
>> examine
>> > the output in target. All of the necessary resource files
>> shoudl be
>> > in the classes or test-classes dirs. If not, then we missed
>> > something.
>>
>>
>> I'll pull the mvn_reorg stuff and check this out.
>>
>
> @Sean/@Wendy:
>
> Is there any way to teach Maven to use an HTTP proxy when it does it's
> dependency downloads, like you can tell Subversion to? I spend
> most of my
> time connected to Sun's VPN network, and right now I have to
> disconnect from
> that to do the Maven stuff -- not fatal, but it's sure a pain.
>
> Sean
>>
>>
> Craig
>
> Craig
>>
>> On 6/1/06, Wendy Smoak < wsmoak@gmail.com> wrote:
>> > > On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>> > >
>> > > > So I can run svn move foo/bar foo/buzz locally and then
>> commit foo?
>> > > > This is the same as svn move https://foo.com/foo/bar
>> > > > https://foo.com/foo/buzz?
>> > >
>> > > Yes, exactly the same. The advantage is that you can do multiple
>> > > commands locally, preview the results, and then commit all the
>> changes
>> > > at once.
>> > >
>> > > There are some limits, occasionally Subversion will complain
>> that you
>> > > need to commit before executing some command that you're
>> trying to do.
>> >
>> > > (Which is why that first script is separate.)
>> > >
>> > > Whatever is easier for you, though, it ends up being the same
>> when
>> > you're done.
>> > >
>> > > --
>> > > Wendy
>> > >
>> > >
>> ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> > > For additional commands, e-mail: dev-help@struts.apache.org
>> > >
>> > >
>> >
>> >
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> > For additional commands, e-mail: dev-help@struts.apache.org
>> >
>> >
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>
> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>
> > I ran all but the tiger script. There are a ton of errors still in
> > the core tests but we're making progress.
> >
> > One problem seems to be with AbstractJsfTestCase and a null pointer
> > when referencing the servletContext variable from a subclass. My
> > guess is that there is a missing configuration resource.
> >
> > @Craig: Any ideas? Try running mvn -Pmyfaces test and then examine
> > the output in target. All of the necessary resource files shoudl be
> > in the classes or test-classes dirs. If not, then we missed
> > something.
>
>
> I'll pull the mvn_reorg stuff and check this out.
>
@Sean/@Wendy:
Is there any way to teach Maven to use an HTTP proxy when it does it's
dependency downloads, like you can tell Subversion to? I spend most of my
time connected to Sun's VPN network, and right now I have to disconnect from
that to do the Maven stuff -- not fatal, but it's sure a pain.
Sean
>
>
Craig
Craig
>
> On 6/1/06, Wendy Smoak < wsmoak@gmail.com> wrote:
> > > On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> > >
> > > > So I can run svn move foo/bar foo/buzz locally and then commit foo?
> > > > This is the same as svn move https://foo.com/foo/bar
> > > > https://foo.com/foo/buzz?
> > >
> > > Yes, exactly the same. The advantage is that you can do multiple
> > > commands locally, preview the results, and then commit all the changes
> > > at once.
> > >
> > > There are some limits, occasionally Subversion will complain that you
> > > need to commit before executing some command that you're trying to do.
> >
> > > (Which is why that first script is separate.)
> > >
> > > Whatever is easier for you, though, it ends up being the same when
> > you're done.
> > >
> > > --
> > > Wendy
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > For additional commands, e-mail: dev-help@struts.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>
> I ran all but the tiger script. There are a ton of errors still in
> the core tests but we're making progress.
>
> One problem seems to be with AbstractJsfTestCase and a null pointer
> when referencing the servletContext variable from a subclass. My
> guess is that there is a missing configuration resource.
>
> @Craig: Any ideas? Try running mvn -Pmyfaces test and then examine
> the output in target. All of the necessary resource files shoudl be
> in the classes or test-classes dirs. If not, then we missed
> something.
I'll pull the mvn_reorg stuff and check this out.
Sean
Craig
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
> > On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> >
> > > So I can run svn move foo/bar foo/buzz locally and then commit foo?
> > > This is the same as svn move https://foo.com/foo/bar
> > > https://foo.com/foo/buzz?
> >
> > Yes, exactly the same. The advantage is that you can do multiple
> > commands locally, preview the results, and then commit all the changes
> > at once.
> >
> > There are some limits, occasionally Subversion will complain that you
> > need to commit before executing some command that you're trying to do.
> > (Which is why that first script is separate.)
> >
> > Whatever is easier for you, though, it ends up being the same when
> you're done.
> >
> > --
> > Wendy
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>
> > Works for me now as well, with your latest patches. But shouldn't it
> also
> > work without the "-Pmyfaces" because it's got <activeByDefault> set?
>
> I think so, too. :/ In addition there was some strangeness (discussed
> on users@maven) with being able to deacivate an active-by-default
> profile. So I'm not yet sure how that part is going to work.
I would hope they end up with a reasonable policy like "if there is a -P
option on the command line, activate only the profiles specified there;
otherwise activate the active by default profile(s)".
Craig
> By the way (if you beat me to it), the sql-browser example app also
> requires
> > JDK 1.5 (an the tiger library).
>
> Shale Tiger isn't building just yet, working on that now...
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> Works for me now as well, with your latest patches. But shouldn't it also
> work without the "-Pmyfaces" because it's got <activeByDefault> set?
I think so, too. :/ In addition there was some strangeness (discussed
on users@maven) with being able to deacivate an active-by-default
profile. So I'm not yet sure how that part is going to work.
> By the way (if you beat me to it), the sql-browser example app also requires
> JDK 1.5 (an the tiger library).
Shale Tiger isn't building just yet, working on that now...
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
>
> And with that, I think I'm done for the night. Thanks for all the help!
Likewise ... and thanks to James as well.
--
> Wendy
Craig
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Sean Schofield <se...@gmail.com>.
> * I presume we don't have to list the individual applications themseves in
> the
> "shale-parent-pom" file, because things get processed hierarchically?
Not sure what you mean by this. If you mean shale/pom.xml and including:
<modules>
<module>shale-clay</module>
<module>shale-core</module>
<module>shale-designtime</module>
<module>shale-spring</module>
<module>shale-test</module>
<module>shale-tiger</module>
<module>shale-tiles</module>
<module>apps</module>
</modules>
(as you have already done) then, yes, we need this. Its just a
convenience pom that allows you to build (and release) all of the
modules at once. Of course, its nice to be able to checkout any one
module (say shale-test) and build that from source without the others
(more on that in my next response.)
> * When I try a build (like "mvn test intall -Pmyfaces") from within one
> of the subdirectories (like "shale-core"), it tries to download
> struts-shale-parent-1.0.3-SNAPSHOT.pom (i.e. the file I'm modifying)
> from ibiblio. Shouldn't we be installing the local copy of the
> parent POM so it'll pick up all the most recent changes?
Yes, you should always run mvn install on the dependencies in order to
get the latest changes. If we are doing our job with good unit tests
we will notice when we fail to do this ;-)
In MyFaces we also publish nightly SNAPSHOTS to the ASF server and
have that listed as a snapshot repo in our master pom. This way its
possible to checkout any one of the modules and build only that
module. Pretty sweet huh? In theory this lowers the barrier to entry
for potential new bug fixers out there who don't want to spend a lot
of time setting up the source and dependencies.
> Craig
Sean
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/2/06, Sean Schofield <se...@gmail.com> wrote:
> > +1 for shale-core, shale-test, shale-clay, etc., as directory names
> > matching the artifactIds.
>
> Done
>
> > For the apps, I see a really long artifactId for the sql browser app,
> > and would rather have it match the name of the war file:
> > shale-sql-browser.
>
> Are you suggesting changing the artifact id and then the name of the
> module to match it? If so +1 from me.
>
> > Thanks,
> > --
> > Wendy
>
> Sean
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/2/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> Oops... wrong button!
>
> On 6/2/06, Sean Schofield <se...@gmail.com> wrote:
> > > +1 for shale-core, shale-test, shale-clay, etc., as directory names
> > > matching the artifactIds.
> >
> > Done
>
> The list of modules in the parent pom needs to be changed to match.
I'm working on this one ... but it raises two questions.
* I presume we don't have to list the individual applications themseves in
the
"shale-parent-pom" file, because things get processed hierarchically?
* When I try a build (like "mvn test intall -Pmyfaces") from within one
of the subdirectories (like "shale-core"), it tries to download
struts-shale-parent-1.0.3-SNAPSHOT.pom (i.e. the file I'm modifying)
from ibiblio. Shouldn't we be installing the local copy of the
parent POM so it'll pick up all the most recent changes?
Craig
> Are you suggesting changing the artifact id and then the name of the
> > module to match it? If so +1 from me.
>
> Yes, for all the apps. I'll do it later (or tomorrow) if no one beats me
> to it.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
Oops... wrong button!
On 6/2/06, Sean Schofield <se...@gmail.com> wrote:
> > +1 for shale-core, shale-test, shale-clay, etc., as directory names
> > matching the artifactIds.
>
> Done
The list of modules in the parent pom needs to be changed to match.
> Are you suggesting changing the artifact id and then the name of the
> module to match it? If so +1 from me.
Yes, for all the apps. I'll do it later (or tomorrow) if no one beats me to it.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/2/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 6/2/06, Sean Schofield <se...@gmail.com> wrote:
>
> > We should rename core-library to shale-core. It saves a lot on
> > maven/continuum headaches if the name of the dir matches the name of
> > the artifact. We did not do this in MyFaces (for some valid reasons)
> > but its a definite inconvenience. I haven't checked the other
> > artifacts but that suggestion holds for those as well.
>
> +1 for shale-core, shale-test, shale-clay, etc., as directory names
> matching the artifactIds.
+1 as well (convention over configuration strikes again :-).
For the apps, I see a really long artifactId for the sql browser app,
> and would rather have it match the name of the war file:
> shale-sql-browser.
That makes sense. And the name is also the default for the context path,
right?
Thanks,
> --
> Wendy
Craig
---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Sean Schofield <se...@gmail.com>.
> +1 for shale-core, shale-test, shale-clay, etc., as directory names
> matching the artifactIds.
Done
> For the apps, I see a really long artifactId for the sql browser app,
> and would rather have it match the name of the war file:
> shale-sql-browser.
Are you suggesting changing the artifact id and then the name of the
module to match it? If so +1 from me.
> Thanks,
> --
> Wendy
Sean
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Sean Schofield <se...@gmail.com>.
Core tests are now working on this end. Nice job everyone.
Sean
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/2/06, Sean Schofield <se...@gmail.com> wrote:
> We should rename core-library to shale-core. It saves a lot on
> maven/continuum headaches if the name of the dir matches the name of
> the artifact. We did not do this in MyFaces (for some valid reasons)
> but its a definite inconvenience. I haven't checked the other
> artifacts but that suggestion holds for those as well.
+1 for shale-core, shale-test, shale-clay, etc., as directory names
matching the artifactIds.
For the apps, I see a really long artifactId for the sql browser app,
and would rather have it match the name of the war file:
shale-sql-browser.
Thanks,
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Sean Schofield <se...@gmail.com>.
Suggestion:
We should rename core-library to shale-core. It saves a lot on
maven/continuum headaches if the name of the dir matches the name of
the artifact. We did not do this in MyFaces (for some valid reasons)
but its a definite inconvenience. I haven't checked the other
artifacts but that suggestion holds for those as well.
Sean
On 6/2/06, Wendy Smoak <ws...@gmail.com> wrote:
> On 6/2/06, Greg Reddin <gr...@apache.org> wrote:
>
> > Wendy, correct me if I'm wrong, but I think this is done because the
> > base group id for Struts is org.apache.struts and as long as Tiles is
> > still part of Struts it will need to retain the struts part of the
> > group id.
>
> Yes, as long as the Struts PMC is reponsible for Tiles, it needs to
> stay under the org.apache.struts.* groupId.
>
> See:
> <http://mail-archives.apache.org/mod_mbox/www-repository/200603.mbox/%3c9e3862d80603131615p23ba210dvb5a24be0b9b1fba1@mail.gmail.com%3e>
>
> Thanks,
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/2/06, Greg Reddin <gr...@apache.org> wrote:
> Wendy, correct me if I'm wrong, but I think this is done because the
> base group id for Struts is org.apache.struts and as long as Tiles is
> still part of Struts it will need to retain the struts part of the
> group id.
Yes, as long as the Struts PMC is reponsible for Tiles, it needs to
stay under the org.apache.struts.* groupId.
See:
<http://mail-archives.apache.org/mod_mbox/www-repository/200603.mbox/%3c9e3862d80603131615p23ba210dvb5a24be0b9b1fba1@mail.gmail.com%3e>
Thanks,
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Greg Reddin <gr...@apache.org>.
On Jun 2, 2006, at 2:20 AM, James Mitchell wrote:
> The group id for Standalone Tiles (sandbox/tiles) says
> 'org.apache.struts.tiles'. Are we waiting till Tiles moves out of
> sandbox before we change that to 'org.apache.tiles'? I'd like to
> change it now. Your thoughts?
Wendy, correct me if I'm wrong, but I think this is done because the
base group id for Struts is org.apache.struts and as long as Tiles is
still part of Struts it will need to retain the struts part of the
group id.
> /**
> * This view handler strips the suffix off of the view ID and looks
> @@ -263,7 +265,7 @@
> ServletRequest servletRequest = (ServletRequest) request;
> ServletContext servletContext = (ServletContext) context;
> try {
> - tile = TilesUtil.getDefinition(name, servletRequest,
> servletContext);
> + tile = TilesUtil.getDefinition(name, new
> ServletTilesContext(servletContext, (HttpServletRequest)
> servletRequest));
This is part of my lack of knowledge of JSF. But is the view handler
already married to the servlet API or is it possible to get here and
be in the portlet API? You should probably be using the
TilesContextFactory here to be more generic.
> Index: tiles-core/src/main/java/org/apache/tiles/ComponentContext.java
> ===================================================================
> --- tiles-core/src/main/java/org/apache/tiles/
> ComponentContext.java (revision 411013)
> +++ tiles-core/src/main/java/org/apache/tiles/
> ComponentContext.java (working copy)
> @@ -25,6 +25,7 @@
> import java.util.Map;
> import java.util.Set;
> +import javax.servlet.ServletRequest;
> import javax.servlet.jsp.PageContext;
> import org.apache.tiles.taglib.ComponentConstants;
> @@ -186,6 +187,14 @@
> } return (ComponentContext)
> tilesContext.getRequestScope().get(
> ComponentConstants.COMPONENT_CONTEXT);
> }
> +
> + static public ComponentContext getContext(ServletRequest
> request) {
> + if (request.getAttribute("javax.servlet.jsp.jspException") !
> = null) {
> + return null;
> + }
We can't put Servlet API dependencies on the Tiles API. One of the
core objectives for Standalone Tiles is to factor out dependencies on
the Servlet API. The above method should be using TilesContext.
> + static public void setContext(
> + ComponentContext context, ServletRequest request) {
> +
> + request.setAttribute(ComponentConstants.COMPONENT_CONTEXT,
> context);
> + }
Again, use TilesContext here instead of ServletRequest.
Thanks for doing this. My *real* job is killing me this week :-)
Greg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
I'm also done, but I wanted to leave you guys with a couple of
questions.
The group id for Standalone Tiles (sandbox/tiles) says
'org.apache.struts.tiles'. Are we waiting till Tiles moves out of
sandbox before we change that to 'org.apache.tiles'? I'd like to
change it now. Your thoughts?
shale/tiles was using 0.2-SNAPSHOT of Standalone tiles, so (locally) I:
- made the above change to the group id
- brought shale/tiles up to 0.3-SNAPSHOT compatibility
Below is what I still have locally (yet to be committed). If no one
objects, I'll commit this after work tomorrow.
((( mvn_reorg )))
Index: tiles/src/main/java/org/apache/shale/tiles/TilesViewHandler.java
===================================================================
--- tiles/src/main/java/org/apache/shale/tiles/
TilesViewHandler.java (revision 411049)
+++ tiles/src/main/java/org/apache/shale/tiles/
TilesViewHandler.java (working copy)
@@ -29,6 +29,7 @@
import javax.faces.context.FacesContext;
import javax.servlet.ServletContext;
import javax.servlet.ServletRequest;
+import javax.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -37,6 +38,7 @@
import org.apache.tiles.DefinitionsFactoryException;
import org.apache.tiles.NoSuchDefinitionException;
import org.apache.tiles.TilesUtil;
+import org.apache.tiles.context.servlet.ServletTilesContext;
/**
* This view handler strips the suffix off of the view ID and looks
@@ -263,7 +265,7 @@
ServletRequest servletRequest = (ServletRequest) request;
ServletContext servletContext = (ServletContext) context;
try {
- tile = TilesUtil.getDefinition(name, servletRequest,
servletContext);
+ tile = TilesUtil.getDefinition(name, new
ServletTilesContext(servletContext, (HttpServletRequest)
servletRequest));
} catch (NoSuchDefinitionException nsex) {
/* not here */
} catch (DefinitionsFactoryException dex) {
Index: tiles/pom.xml
===================================================================
--- tiles/pom.xml (revision 411049)
+++ tiles/pom.xml (working copy)
@@ -43,9 +43,9 @@
<version>${pom.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.struts.tiles</groupId>
+ <groupId>org.apache.tiles</groupId>
<artifactId>tiles-core</artifactId>
- <version>0.2-SNAPSHOT</version>
+ <version>0.3-SNAPSHOT</version>
</dependency>
</dependencies>
((( struts/sandbox/tiles )))
Index: tiles-core/src/main/java/org/apache/tiles/ComponentContext.java
===================================================================
--- tiles-core/src/main/java/org/apache/tiles/
ComponentContext.java (revision 411013)
+++ tiles-core/src/main/java/org/apache/tiles/
ComponentContext.java (working copy)
@@ -25,6 +25,7 @@
import java.util.Map;
import java.util.Set;
+import javax.servlet.ServletRequest;
import javax.servlet.jsp.PageContext;
import org.apache.tiles.taglib.ComponentConstants;
@@ -186,6 +187,14 @@
} return (ComponentContext)
tilesContext.getRequestScope().get(
ComponentConstants.COMPONENT_CONTEXT);
}
+
+ static public ComponentContext getContext(ServletRequest request) {
+ if (request.getAttribute("javax.servlet.jsp.jspException") !=
null) {
+ return null;
+ }
+ return (ComponentContext) request.getAttribute(
+ ComponentConstants.COMPONENT_CONTEXT);
+ }
/**
* Store component context into request.
@@ -198,4 +207,9 @@
tilesContext.getRequestScope().put
(ComponentConstants.COMPONENT_CONTEXT, context);
}
+ static public void setContext(
+ ComponentContext context, ServletRequest request) {
+
+ request.setAttribute(ComponentConstants.COMPONENT_CONTEXT,
context);
+ }
}
Index: tiles-core/src/main/java/org/apache/tiles/TilesUtil.java
===================================================================
--- tiles-core/src/main/java/org/apache/tiles/TilesUtil.java
(revision 411013)
+++ tiles-core/src/main/java/org/apache/tiles/TilesUtil.java
(working copy)
@@ -20,6 +20,8 @@
import java.io.IOException;
+import javax.servlet.ServletContext;
+import javax.servlet.ServletRequest;
import javax.servlet.jsp.PageContext;
import org.apache.commons.logging.Log;
@@ -182,7 +184,7 @@
return tilesUtilImpl.getDefinition(definitionName,
tilesContext);
}
-
+
/**
* Reset internal state.
* This method is used by test suites to reset the class to its
original state.
Index: tiles-core/pom.xml
===================================================================
--- tiles-core/pom.xml (revision 411013)
+++ tiles-core/pom.xml (working copy)
@@ -22,7 +22,7 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://
maven.apache.org/maven-v4_0_0.xsd">
<parent>
- <groupId>org.apache.struts.tiles</groupId>
+ <groupId>org.apache.tiles</groupId>
<artifactId>tiles-parent</artifactId>
<version>0.3-SNAPSHOT</version>
</parent>
Index: tiles-documentation/src/java/org/apache/struts/webapp/tiles/
channel/ChannelFactorySet.java
===================================================================
--- tiles-documentation/src/java/org/apache/struts/webapp/tiles/
channel/ChannelFactorySet.java (revision 411013)
+++ tiles-documentation/src/java/org/apache/struts/webapp/tiles/
channel/ChannelFactorySet.java (working copy)
@@ -29,12 +29,12 @@
import javax.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.struts.tiles.DefinitionsFactoryException;
-import org.apache.struts.tiles.FactoryNotFoundException;
-import org.apache.struts.tiles.xmlDefinition.DefinitionsFactory;
-import org.apache.struts.tiles.xmlDefinition.FactorySet;
-import org.apache.struts.tiles.xmlDefinition.XmlDefinitionsSet;
-import org.apache.struts.tiles.xmlDefinition.XmlParser;
+import org.apache.tiles.DefinitionsFactoryException;
+import org.apache.tiles.FactoryNotFoundException;
+import org.apache.tiles.DefinitionsFactory;
+import org.apache.tiles.xmlDefinition.FactorySet;
+import org.apache.tiles.xmlDefinition.XmlDefinitionsSet;
+import org.apache.tiles.xmlDefinition.XmlParser;
import org.xml.sax.SAXException;
/**
Index: pom.xml
===================================================================
--- pom.xml (revision 411013)
+++ pom.xml (working copy)
@@ -30,7 +30,7 @@
</parent>
<modelVersion>4.0.0</modelVersion>
- <groupId>org.apache.struts.tiles</groupId>
+ <groupId>org.apache.tiles</groupId>
<artifactId>tiles-parent</artifactId>
<version>0.3-SNAPSHOT</version>
<packaging>pom</packaging>
Index: tiles-test/pom.xml
===================================================================
--- tiles-test/pom.xml (revision 411013)
+++ tiles-test/pom.xml (working copy)
@@ -23,7 +23,7 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://
maven.apache.org/maven-v4_0_0.xsd">
<parent>
- <groupId>org.apache.struts.tiles</groupId>
+ <groupId>org.apache.tiles</groupId>
<artifactId>tiles-parent</artifactId>
<version>0.3-SNAPSHOT</version>
</parent>
--
James Mitchell
On Jun 2, 2006, at 2:55 AM, Wendy Smoak wrote:
> On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>
>> * "src/systest" in the original repository contains JUnit tests,
>> but they (a) presume that the webapp has been deployed,
>> and (b) use HtmlUnit to exercise the actual application and
>> examine the returned HTML pages for correct output. I think
>> of these as system integration tests rather than unit tests,
>> but vastly prefer HtmlUnit based tests like this to something
>> built with Cactus. Much simpler.
>>
>> We don't necessarily have to solve the systest issues tonight, but
>> that'll
>> probably bear some thought since the same principle would apply to
>> any
>> webapp in the repository (and, ideally, any user-defined webapp
>> created via
>> the archetype mechanisms).
>
> Testing the webapps in that way is doable, Cargo can be used in a
> JUnit TestSetup class to start container(s) and deploy the apps, then
> the tests run as usual.
>
> For the Tiger tests, if you just need the directory structure (and not
> a deployed webapp) then it's not a problem. There's an example of
> setting a property ('documentRoot') in core-library/pom.xml.
>
> And with that, I think I'm done for the night. Thanks for all the
> help!
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> * "src/systest" in the original repository contains JUnit tests,
> but they (a) presume that the webapp has been deployed,
> and (b) use HtmlUnit to exercise the actual application and
> examine the returned HTML pages for correct output. I think
> of these as system integration tests rather than unit tests,
> but vastly prefer HtmlUnit based tests like this to something
> built with Cactus. Much simpler.
>
> We don't necessarily have to solve the systest issues tonight, but that'll
> probably bear some thought since the same principle would apply to any
> webapp in the repository (and, ideally, any user-defined webapp created via
> the archetype mechanisms).
Testing the webapps in that way is doable, Cargo can be used in a
JUnit TestSetup class to start container(s) and deploy the apps, then
the tests run as usual.
For the Tiger tests, if you just need the directory structure (and not
a deployed webapp) then it's not a problem. There's an example of
setting a property ('documentRoot') in core-library/pom.xml.
And with that, I think I'm done for the night. Thanks for all the help!
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>
>
>
> On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> > On 6/1/06, James Mitchell <jm...@apache.org> wrote:
> >
> > > Are you able to run the tiger tests?
> >
> > No. I got to the part in build.xml where it says "Set up 'web
> > application' for unit tests" and decided that maven.test.skip=true
> > would do for now. :)
> >
> > Craig, can you explain the testing strategy for shale-tiger?
>
>
> It's supposed to be similar to core-lbrary, in that the src/test directory
> will contain a bunch of JUnit tests. Since the module requires 1.5, the
> tests will as well, but other than that it should not be anything special.
>
OK, that's only half the story ... and the same thing will apply to
"use-cases" (and potentially all of the other webapps when we get there).
There are potentially two sets of tests.
* "src/test" in the original repository contains JUnit unit tests
that run standalone on the classes in the webapp's src/java
directory.
* "src/systest" in the original repository contains JUnit tests,
but they (a) presume that the webapp has been deployed,
and (b) use HtmlUnit to exercise the actual application and
examine the returned HTML pages for correct output. I think
of these as system integration tests rather than unit tests,
but vastly prefer HtmlUnit based tests like this to something
built with Cactus. Much simpler.
We don't necessarily have to solve the systest issues tonight, but that'll
probably bear some thought since the same principle would apply to any
webapp in the repository (and, ideally, any user-defined webapp created via
the archetype mechanisms).
Craig
>
Craig
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>
> > Are you able to run the tiger tests?
>
> No. I got to the part in build.xml where it says "Set up 'web
> application' for unit tests" and decided that maven.test.skip=true
> would do for now. :)
>
> Craig, can you explain the testing strategy for shale-tiger?
It's supposed to be similar to core-lbrary, in that the src/test directory
will contain a bunch of JUnit tests. Since the module requires 1.5, the
tests will as well, but other than that it should not be anything special.
Craig
--
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>
> > Sorry, I meant with Maven 2. I get a few test failures, even after
> > correcting the missing .xml files from test.
>
> So did I. The tests fail with Maven2, so I looked at tiger/build.xml
> to see what might be missing.
>
> In build,xml, the 'test' target depends on 'test:webapp' which
> constructs a web application directory structure that I assume the
> tests depend on.
Yes, they do ... Tiger needs to be able to parse the faces-config.xml files
defined by the webapp just like the JSF runtime does, so I needed to be able
to simulate a webapp directory structure for that in the unit tests.
Note that the Ant scripts pass a "basedir" system property pointing at where
the deployed webapp directory structure is -- we'll need to do something
equivalent or change the tests to presume where the resources actually end
up.
Craig
It might be as simple as arranging that into src/test/resources so it
> will be available for the m2 tests.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, James Mitchell <jm...@apache.org> wrote:
> Sorry, I meant with Maven 2. I get a few test failures, even after
> correcting the missing .xml files from test.
So did I. The tests fail with Maven2, so I looked at tiger/build.xml
to see what might be missing.
In build,xml, the 'test' target depends on 'test:webapp' which
constructs a web application directory structure that I assume the
tests depend on.
It might be as simple as arranging that into src/test/resources so it
will be available for the m2 tests.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
Sorry, I meant with Maven 2. I get a few test failures, even after
correcting the missing .xml files from test.
--
James Mitchell
On Jun 2, 2006, at 2:06 AM, Wendy Smoak wrote:
> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>
>> Are you able to run the tiger tests?
>
> No. I got to the part in build.xml where it says "Set up 'web
> application' for unit tests" and decided that maven.test.skip=true
> would do for now. :)
>
> Craig, can you explain the testing strategy for shale-tiger?
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
Ok, and if no one beats me to it, I'll convert that to a block of
text on the wiki that people can copy and use locally.
http://maven.apache.org/guides/mini/guide-installing-3rd-party-jars.html
--
James Mitchell
On Jun 2, 2006, at 2:28 AM, Craig McClanahan wrote:
> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>>
>> Also, what's the deal with designtime? I briefly remember some
>> discussion on it in this thread and was just wondering what the final
>> result was.
>>
>> Will the binaries be made available via Maven repo? Or do we have to
>> download creator and manually install the jars locally?
>
>
> I'm working on the public avaiability of this (we announced at
> JavaOne that
> Creator will be open sourced ... finalizing the planning now, but
> it's more
> likely to be months than weeks or days). In the mean time, I'll
> create a
> cheat sheet for how to copy the necessary JARs out of a downloaded
> Creator 2
> (or Creator 2 Update 1) install and put them locally into your
> repository.
>
> --
>> James Mitchell
>
>
> Craig
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>
> Also, what's the deal with designtime? I briefly remember some
> discussion on it in this thread and was just wondering what the final
> result was.
>
> Will the binaries be made available via Maven repo? Or do we have to
> download creator and manually install the jars locally?
I'm working on the public avaiability of this (we announced at JavaOne that
Creator will be open sourced ... finalizing the planning now, but it's more
likely to be months than weeks or days). In the mean time, I'll create a
cheat sheet for how to copy the necessary JARs out of a downloaded Creator 2
(or Creator 2 Update 1) install and put them locally into your repository.
--
> James Mitchell
Craig
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
Also, what's the deal with designtime? I briefly remember some
discussion on it in this thread and was just wondering what the final
result was.
Will the binaries be made available via Maven repo? Or do we have to
download creator and manually install the jars locally?
--
James Mitchell
On Jun 2, 2006, at 2:06 AM, Wendy Smoak wrote:
> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>
>> Are you able to run the tiger tests?
>
> No. I got to the part in build.xml where it says "Set up 'web
> application' for unit tests" and decided that maven.test.skip=true
> would do for now. :)
>
> Craig, can you explain the testing strategy for shale-tiger?
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, James Mitchell <jm...@apache.org> wrote:
> Are you able to run the tiger tests?
No. I got to the part in build.xml where it says "Set up 'web
application' for unit tests" and decided that maven.test.skip=true
would do for now. :)
Craig, can you explain the testing strategy for shale-tiger?
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
Are you able to run the tiger tests?
--
James Mitchell
On Jun 2, 2006, at 1:59 AM, Wendy Smoak wrote:
> On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>> Found the one on the Maven website[1] and added the appropriate
>> entries.
>> But now, when I try to run "mvn clean test -Pjsfri" the following
>> bad things
>> happen:
>>
>> * There's an obsolete jsf-api artifact on ibiblio --
>> can we specify a priority ordering somehow?
>
> Not that I'm aware of. But ibiblio only has a pom for 1.1, so it
> shouldn't cause a problem if we're using version 1.1_02. If you mean
> the 'invalid pom' warnings, that's because java.net is a Maven 1 repo.
>
>> * It fails to download the jsf-impl (but that could
>> be my proxy not liking https -- investigating.
>
> After I added the <repository> and changed the version number, 'mvn
> clean install -Pjsfri' in core-library ran with no problems here.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> > Found the one on the Maven website[1] and added the appropriate entries.
> > But now, when I try to run "mvn clean test -Pjsfri" the following bad
> things
> > happen:
> >
> > * There's an obsolete jsf-api artifact on ibiblio --
> > can we specify a priority ordering somehow?
>
> Not that I'm aware of. But ibiblio only has a pom for 1.1, so it
> shouldn't cause a problem if we're using version 1.1_02. If you mean
> the 'invalid pom' warnings, that's because java.net is a Maven 1 repo.
>
> > * It fails to download the jsf-impl (but that could
> > be my proxy not liking https -- investigating.
>
> After I added the <repository> and changed the version number, 'mvn
> clean install -Pjsfri' in core-library ran with no problems here.
Me too when I disconnected from my VPN network (and commented out the
appropriate proxy stuff). I've used https proxies for other things
(including SVN commits to Apache), so it's likely to still be something with
Maven ... but that's an issue that can wait for a night's sleep.
--
> Wendy
Craig
---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> Found the one on the Maven website[1] and added the appropriate entries.
> But now, when I try to run "mvn clean test -Pjsfri" the following bad things
> happen:
>
> * There's an obsolete jsf-api artifact on ibiblio --
> can we specify a priority ordering somehow?
Not that I'm aware of. But ibiblio only has a pom for 1.1, so it
shouldn't cause a problem if we're using version 1.1_02. If you mean
the 'invalid pom' warnings, that's because java.net is a Maven 1 repo.
> * It fails to download the jsf-impl (but that could
> be my proxy not liking https -- investigating.
After I added the <repository> and changed the version number, 'mvn
clean install -Pjsfri' in core-library ran with no problems here.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>
> > Thanks ... I've gotta get my feet wet with this stuff sometime, so now
> seems
> > like a good opportunity :-).
>
> Here's the 'maven model', the documentation for pom.xml:
> http://maven.apache.org/ref/2.0.3-SNAPSHOT/maven-model/maven.html
>
> There's probably a newer version somewhere, that's the one Google finds.
Found the one on the Maven website[1] and added the appropriate entries.
But now, when I try to run "mvn clean test -Pjsfri" the following bad things
happen:
* There's an obsolete jsf-api artifact on ibiblio --
can we specify a priority ordering somehow?
* It fails to download the jsf-impl (but that could
be my proxy not liking https -- investigating.
By the way, the version number we want for both api and impl is 1.1_02
--
> Wendy
Craig
Craig
[1] http://maven.apache.org/ref/current/maven-model/maven.html
---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> Thanks ... I've gotta get my feet wet with this stuff sometime, so now seems
> like a good opportunity :-).
Here's the 'maven model', the documentation for pom.xml:
http://maven.apache.org/ref/2.0.3-SNAPSHOT/maven-model/maven.html
There's probably a newer version somewhere, that's the one Google finds.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> > In addition, I wanted to try this using the JSF RI too, because (in
> theory)
> > everything should still work. So I tried
> >
> > mvn clean install -Pjsfri
> >
> > It looks like Maven is trying to download the RI stuff from ibiblio,
> which
> > isn't correct ... the necessary files are on the java.net repository (
> > https://maven-repository.dev.java.net/nonav/repository/)
> >
> > How does one go about telling Maven to get the "javax.faces" artifacts
> from
> > here instead?
>
> Put this in the shale parent pom, then adjust the version numbers on
> the RI dependencies.
>
> <repositories>
> <repository>
> <id>java.net</id>
> <name>java.net Maven 1 Repository</name>
> <url>https://maven-repository.dev.java.net/nonav/repository/
> </url>
> <layout>legacy</layout>
> </repository>
> </repositories>
Thanks ... I've gotta get my feet wet with this stuff sometime, so now seems
like a good opportunity :-).
Although, it might ultimately make sense to do this in the Struts parent POM
since SAF2 is using JSF as well. Did we set up profiles the same way
there? (I'm gonna go ahead and do the Shale parent now, and worry about
that later.)
--
> Wendy
Craig
---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
> In addition, I wanted to try this using the JSF RI too, because (in theory)
> everything should still work. So I tried
>
> mvn clean install -Pjsfri
>
> It looks like Maven is trying to download the RI stuff from ibiblio, which
> isn't correct ... the necessary files are on the java.net repository (
> https://maven-repository.dev.java.net/nonav/repository/)
>
> How does one go about telling Maven to get the "javax.faces" artifacts from
> here instead?
Put this in the shale parent pom, then adjust the version numbers on
the RI dependencies.
<repositories>
<repository>
<id>java.net</id>
<name>java.net Maven 1 Repository</name>
<url>https://maven-repository.dev.java.net/nonav/repository/</url>
<layout>legacy</layout>
</repository>
</repositories>
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Craig McClanahan <cr...@apache.org> wrote:
>
>
>
> On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> > On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> > > I ran all but the tiger script. There are a ton of errors still in
> > > the core tests but we're making progress.
> >
> > Core library builds and all the tests pass:
> >
> > mvn clean install -Pmyfaces
>
>
> Works for me now as well, with your latest patches. But shouldn't it also
> work without the "-Pmyfaces" because it's got <activeByDefault> set?
>
In addition, I wanted to try this using the JSF RI too, because (in theory)
everything should still work. So I tried
mvn clean install -Pjsfri
It looks like Maven is trying to download the RI stuff from ibiblio, which
isn't correct ... the necessary files are on the java.net repository (
https://maven-repository.dev.java.net/nonav/repository/)
How does one go about telling Maven to get the "javax.faces" artifacts from
here instead?
Craig
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Craig McClanahan <cr...@apache.org>.
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> > I ran all but the tiger script. There are a ton of errors still in
> > the core tests but we're making progress.
>
> Core library builds and all the tests pass:
>
> mvn clean install -Pmyfaces
Works for me now as well, with your latest patches. But shouldn't it also
work without the "-Pmyfaces" because it's got <activeByDefault> set?
By the way (if you beat me to it), the sql-browser example app also requires
JDK 1.5 (an the tiger library).
Craig
It was a combination of a missing 'documentRoot' system property, and
> not having all of the non-Java resources in the right place in the jar
> file.
>
> The Ant build also copies messages.properties ->
> message_en.properties, which isn't in the Maven build yet.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
Darn, I was hoping to have an excuse to play with Maven plugins
again :D They're just so cute and fuzzy and ....(clearing
throat)...ok, back to shale.
--
James Mitchell
On Jun 2, 2006, at 12:54 AM, Wendy Smoak wrote:
> On 6/1/06, James Mitchell <jm...@apache.org> wrote:
>
>> > The Ant build also copies messages.properties ->
>> > message_en.properties, which isn't in the Maven build yet.
>
>> Would you like a mojo for that?
>
> For copying the file? I was just going to use the antrun plugin. (Or
> just duplicate the file in the repository, which would be much
> easier.)
>
> I do think there's a market for a 'maven-copier-plugin' if you can get
> it accepted at Codehaus Mojo or Maven. It might be a bit too freeform
> for the Maven philosophy, though. :)
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, James Mitchell <jm...@apache.org> wrote:
> > The Ant build also copies messages.properties ->
> > message_en.properties, which isn't in the Maven build yet.
> Would you like a mojo for that?
For copying the file? I was just going to use the antrun plugin. (Or
just duplicate the file in the repository, which would be much
easier.)
I do think there's a market for a 'maven-copier-plugin' if you can get
it accepted at Codehaus Mojo or Maven. It might be a bit too freeform
for the Maven philosophy, though. :)
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by James Mitchell <jm...@apache.org>.
Would you like a mojo for that?
--
James Mitchell
On Jun 2, 2006, at 12:40 AM, Wendy Smoak wrote:
> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>> I ran all but the tiger script. There are a ton of errors still in
>> the core tests but we're making progress.
>
> Core library builds and all the tests pass:
>
> mvn clean install -Pmyfaces
>
> It was a combination of a missing 'documentRoot' system property, and
> not having all of the non-Java resources in the right place in the jar
> file.
>
> The Ant build also copies messages.properties ->
> message_en.properties, which isn't in the Maven build yet.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> I ran all but the tiger script. There are a ton of errors still in
> the core tests but we're making progress.
Core library builds and all the tests pass:
mvn clean install -Pmyfaces
It was a combination of a missing 'documentRoot' system property, and
not having all of the non-Java resources in the right place in the jar
file.
The Ant build also copies messages.properties ->
message_en.properties, which isn't in the Maven build yet.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Sean Schofield <se...@gmail.com>.
I ran all but the tiger script. There are a ton of errors still in
the core tests but we're making progress.
One problem seems to be with AbstractJsfTestCase and a null pointer
when referencing the servletContext variable from a subclass. My
guess is that there is a missing configuration resource.
@Craig: Any ideas? Try running mvn -Pmyfaces test and then examine
the output in target. All of the necessary resource files shoudl be
in the classes or test-classes dirs. If not, then we missed
something.
Sean
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>
> > So I can run svn move foo/bar foo/buzz locally and then commit foo?
> > This is the same as svn move https://foo.com/foo/bar
> > https://foo.com/foo/buzz?
>
> Yes, exactly the same. The advantage is that you can do multiple
> commands locally, preview the results, and then commit all the changes
> at once.
>
> There are some limits, occasionally Subversion will complain that you
> need to commit before executing some command that you're trying to do.
> (Which is why that first script is separate.)
>
> Whatever is easier for you, though, it ends up being the same when you're done.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> So I can run svn move foo/bar foo/buzz locally and then commit foo?
> This is the same as svn move https://foo.com/foo/bar
> https://foo.com/foo/buzz?
Yes, exactly the same. The advantage is that you can do multiple
commands locally, preview the results, and then commit all the changes
at once.
There are some limits, occasionally Subversion will complain that you
need to commit before executing some command that you're trying to do.
(Which is why that first script is separate.)
Whatever is easier for you, though, it ends up being the same when you're done.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Sean Schofield <se...@gmail.com>.
So I can run svn move foo/bar foo/buzz locally and then commit foo?
This is the same as svn move https://foo.com/foo/bar
https://foo.com/foo/buzz? I won't have a chance to start until at
least 6:00 PM EST but I will start from the beginning the way you
suggested and maybe you can finish up if I don't.
Sean
On 6/1/06, Wendy Smoak <ws...@gmail.com> wrote:
> On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
>
> > The next step is to replicate all of the changes Wendy made using her
> > script. I need to leave the office for a few hours but if nobody does
> > this while I'm gone I will see what I can do. We'll also need to copy
> > over the poms from the test repo since these are our only copies.
>
> I won't get back to it until tonight, so go ahead if you have time.
> If you're going to use the scripts, remember to back out the changes
> you made to the 'core' script for designtime.
> They should work if run from their current location at the 'top' of
> Shale's project structure.
>
> This one has to go first, it creates the new directories for tiles,
> spring and designtime, and moves all the examples under an 'apps'
> directory. It also 'svn add's some of the poms, so put them in the
> right place locally first.
> http://svn.apache.org/repos/test/struts/struts-shale/trunk/shale-reorg-01.sh
>
> Review and commit those changes.
>
> Then the other scripts (one per module) such as
> http://svn.apache.org/repos/test/struts/struts-shale/trunk/shale-reorg-clay-01.sh
> just move things around to src/main/java, src/test/java, src/site/site.xml, etc.
>
> It's all happening locally, so you can review the changes and make
> sure it worked before touching the repository. There was a lot of
> 'svn revert' involved before I got them right. :)
>
> Thanks again,
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Maven Reorg (Was --> Re: [shale] Maven 2 build -- Help Wanted)
Posted by Wendy Smoak <ws...@gmail.com>.
On 6/1/06, Sean Schofield <se...@gmail.com> wrote:
> The next step is to replicate all of the changes Wendy made using her
> script. I need to leave the office for a few hours but if nobody does
> this while I'm gone I will see what I can do. We'll also need to copy
> over the poms from the test repo since these are our only copies.
I won't get back to it until tonight, so go ahead if you have time.
If you're going to use the scripts, remember to back out the changes
you made to the 'core' script for designtime.
They should work if run from their current location at the 'top' of
Shale's project structure.
This one has to go first, it creates the new directories for tiles,
spring and designtime, and moves all the examples under an 'apps'
directory. It also 'svn add's some of the poms, so put them in the
right place locally first.
http://svn.apache.org/repos/test/struts/struts-shale/trunk/shale-reorg-01.sh
Review and commit those changes.
Then the other scripts (one per module) such as
http://svn.apache.org/repos/test/struts/struts-shale/trunk/shale-reorg-clay-01.sh
just move things around to src/main/java, src/test/java, src/site/site.xml, etc.
It's all happening locally, so you can review the changes and make
sure it worked before touching the repository. There was a lot of
'svn revert' involved before I got them right. :)
Thanks again,
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org