You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2009/08/09 09:52:14 UTC

[jira] Created: (SOLR-1352) DIH: MultiThreaded

DIH: MultiThreaded
------------------

                 Key: SOLR-1352
                 URL: https://issues.apache.org/jira/browse/SOLR-1352
             Project: Solr
          Issue Type: Improvement
          Components: contrib - DataImportHandler
            Reporter: Noble Paul
            Assignee: Noble Paul
             Fix For: 1.5


It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows

{code:xml}
<entity name="foo" numThreads="4">
<!--more stuff goes here-->
</entity>
{code}

at the entity where the numThreads is specified it should fork into multiple threads. If the numThreads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-1352) DIH: MultiThreaded

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul resolved SOLR-1352.
------------------------------

    Resolution: Fixed

committed Revision: 898209

> DIH: MultiThreaded
> ------------------
>
>                 Key: SOLR-1352
>                 URL: https://issues.apache.org/jira/browse/SOLR-1352
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1352.patch, SOLR-1352.patch, SOLR-1352.patch
>
>
> It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows
> {code:xml}
> <entity name="foo" threads="4">
> <!--more stuff goes here-->
> </entity>
> {code}
> at the entity where the threads is specified it should fork into multiple threads. If the threads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1352) DIH: MultiThreaded

Posted by "Avlesh Singh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741047#action_12741047 ] 

Avlesh Singh commented on SOLR-1352:
------------------------------------

Thanks, once again :), for creating the ticket, Noble.
Here's the last discussion on the topic, "Support for batch processing of commands using parallel threads in DIH" - http://www.lucidimagination.com/search/document/a9b26ade46466ee/queries_regarding_a_paralleldataimporthandler

> DIH: MultiThreaded
> ------------------
>
>                 Key: SOLR-1352
>                 URL: https://issues.apache.org/jira/browse/SOLR-1352
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>
> It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows
> {code:xml}
> <entity name="foo" numThreads="4">
> <!--more stuff goes here-->
> </entity>
> {code}
> at the entity where the numThreads is specified it should fork into multiple threads. If the numThreads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1352) DIH: MultiThreaded

Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795939#action_12795939 ] 

Lance Norskog commented on SOLR-1352:
-------------------------------------

In the future, especially with multi-threaded operations, the DIH will benefit from converting to immutable objects wherever possible.
 I have used this technique on a few multithreaded projects and it has really helped:
http://codeidol.com/java/effective-java/Processing/Item-38-Favor-the-immutable,-for-it-needs-no-locks/

("Effective Enterprise Java" is one my favorite system architecture books.)



> DIH: MultiThreaded
> ------------------
>
>                 Key: SOLR-1352
>                 URL: https://issues.apache.org/jira/browse/SOLR-1352
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1352.patch, SOLR-1352.patch, SOLR-1352.patch
>
>
> It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows
> {code:xml}
> <entity name="foo" threads="4">
> <!--more stuff goes here-->
> </entity>
> {code}
> at the entity where the threads is specified it should fork into multiple threads. If the threads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1352) DIH: MultiThreaded

Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lance Norskog updated SOLR-1352:
--------------------------------

    Comment: was deleted

(was: In the future, especially with multi-threaded operations, the DIH will benefit from converting to immutable objects wherever possible.
 I have used this technique on a few multithreaded projects and it has really helped:
http://codeidol.com/java/effective-java/Processing/Item-38-Favor-the-immutable,-for-it-needs-no-locks/

("Effective Enterprise Java" is one my favorite system architecture books.)

)

> DIH: MultiThreaded
> ------------------
>
>                 Key: SOLR-1352
>                 URL: https://issues.apache.org/jira/browse/SOLR-1352
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1352.patch, SOLR-1352.patch, SOLR-1352.patch
>
>
> It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows
> {code:xml}
> <entity name="foo" threads="4">
> <!--more stuff goes here-->
> </entity>
> {code}
> at the entity where the threads is specified it should fork into multiple threads. If the threads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1352) DIH: MultiThreaded

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1352:
-----------------------------

    Attachment: SOLR-1352.patch

first cut an ugly patch. a lot of work left before putting it in

> DIH: MultiThreaded
> ------------------
>
>                 Key: SOLR-1352
>                 URL: https://issues.apache.org/jira/browse/SOLR-1352
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1352.patch
>
>
> It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows
> {code:xml}
> <entity name="foo" numThreads="4">
> <!--more stuff goes here-->
> </entity>
> {code}
> at the entity where the numThreads is specified it should fork into multiple threads. If the numThreads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1352) DIH: MultiThreaded

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1352:
-----------------------------

    Description: 
It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows

{code:xml}
<entity name="foo" threads="4">
<!--more stuff goes here-->
</entity>
{code}

at the entity where the threads is specified it should fork into multiple threads. If the threads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

  was:
It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows

{code:xml}
<entity name="foo" numThreads="4">
<!--more stuff goes here-->
</entity>
{code}

at the entity where the numThreads is specified it should fork into multiple threads. If the numThreads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.


'numThreads' becomes' threads'

> DIH: MultiThreaded
> ------------------
>
>                 Key: SOLR-1352
>                 URL: https://issues.apache.org/jira/browse/SOLR-1352
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1352.patch
>
>
> It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows
> {code:xml}
> <entity name="foo" threads="4">
> <!--more stuff goes here-->
> </entity>
> {code}
> at the entity where the threads is specified it should fork into multiple threads. If the threads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1352) DIH: MultiThreaded

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1352:
-----------------------------

    Attachment: SOLR-1352.patch

More or less final. I plan to commit this soon

> DIH: MultiThreaded
> ------------------
>
>                 Key: SOLR-1352
>                 URL: https://issues.apache.org/jira/browse/SOLR-1352
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1352.patch, SOLR-1352.patch, SOLR-1352.patch
>
>
> It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows
> {code:xml}
> <entity name="foo" threads="4">
> <!--more stuff goes here-->
> </entity>
> {code}
> at the entity where the threads is specified it should fork into multiple threads. If the threads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1352) DIH: MultiThreaded

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1352:
-----------------------------

    Attachment: SOLR-1352.patch

updated to trunk

> DIH: MultiThreaded
> ------------------
>
>                 Key: SOLR-1352
>                 URL: https://issues.apache.org/jira/browse/SOLR-1352
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1352.patch, SOLR-1352.patch
>
>
> It has been a long pending request to make DIH multithreaded. Now that we have implemented most of the features , the next best thing we can aim for is performance. DIH should be able to take advantage of multiple cores in a box .I expect the configuration to be as follows
> {code:xml}
> <entity name="foo" threads="4">
> <!--more stuff goes here-->
> </entity>
> {code}
> at the entity where the threads is specified it should fork into multiple threads. If the threads<2 it executes w/o forking. In debug mode it automatically becomes singlethreaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.