You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/01 07:59:58 UTC

[GitHub] [rocketmq] GenerousMan opened a new pull request, #4753: [ISSUE #4725] Optimize the CK/ACK 's invisibleTime in POP consumption mode.

GenerousMan opened a new pull request, #4753:
URL: https://github.com/apache/rocketmq/pull/4753

**Make sure set the target branch to `develop`**

## What is the purpose of the change
Replace scheduled message in POP with timer message.
In the current POP consumption mode, the InvisibleTime implementation of the CK/ACK message relies on the scheduled message. However, because of the precision limitation of the scheduled message, some CK/ACK messages may work not as expected. Since the completion of RIP-43, rocketmq can already support timing messages with arbitrary delay. Therefore, using this feature can optimize the POP consumption process.

## Brief changelog

1. Modify the function SetMessageDeliverTimer and getMessageDeliverTimer.
2. Supplement the unit tests of PopReviveService, make sure the pipeline works well.

## Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [√] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [√] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [√] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [√] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [√] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org