[jira] [Commented] (OFBIZ-13679) MacroFormRenderer: build check, radio, submit, reset, hidden and field title macro calls with RenderableFtlFormElementsBuilder

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18127741#comment-18127741 ] 

ASF subversion and git services commented on OFBIZ-13679:
---------------------------------------------------------

Commit 35d68ab0e80984dfbe9d90d967449c23e4aebb2c in ofbiz-framework's branch refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=35d68ab0e8 ]

Improved: MacroFormRenderer builds the check, radio, submit, reset, hidden and field title macro calls with RenderableFtlFormElementsBuilder (OFBIZ-13679)

MacroFormRenderer built the macro calls of the check, radio, submit, reset and hidden fields, of the field titles and of the sort field as text and compiled them. RenderableFtlFormElementsBuilder now creates these macro calls, so that FtlWriter passes their values as data: the options of the check and radio fields are lists of maps instead of hash literals, and the quotes that the form fields escaped for a FreeMarker string literal are no longer escaped. The macro signatures and the output are unchanged, except that values containing a quote, a backslash or an interpolation, which used to fail to render or to be evaluated, are now rendered as they are, and a missing value is rendered as an empty string instead of the text "null".


> MacroFormRenderer: build check, radio, submit, reset, hidden and field title macro calls with RenderableFtlFormElementsBuilder
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-13679
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13679
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework/widget
>    Affects Versions: Upcoming Branch
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Minor
>
> These form elements are still built as macro call text in {{MacroFormRenderer}}. Build them with {{RenderableFtlFormElementsBuilder}} like the elements already migrated, so the values are passed as data, and encode each value in one place only (either in Java or in the macro). This is the same work as OFBIZ-12128 to OFBIZ-12133 and also covers the sort field.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)