[GitHub] [incubator-superset] villebro opened a new pull request #8536: [WIP] Pass url parameters from dashboard to charts

[GitBox <gi...@apache.org>]

villebro opened a new pull request #8536: [WIP] Pass url parameters from dashboard to charts
URL: https://github.com/apache/incubator-superset/pull/8536
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Currently URL parameters are correctly handled in explore mode, but are not passed from the dashboard view to charts. However, current functionality is limited/broken in the following ways:
   - Any default values for `url_params` specified in charts are erased if the chart is opened via the Charts page.
   - query parameters passed to dashboards are not forwarded to chart requests, making them unusable in dashboards.
   
   This PR does the following:
   - Default values for query parameters are left unchanged when opening a chart via the Charts page.
   - URL parameters passed to a dashboard are updated to the chart defaults prior to rendering.
   
   TODO:
   - add tests
   - add documentation
   - do some more testing
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   To be added later
   
   ### TEST PLAN
   CI, Unit/integration tests, local testing
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: closes #6708 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @senturkayhan @rsdpyenugula - all help testing this would be appreciated (I will add committers to the review roster once WIP status is removed)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org