You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/03/04 01:25:03 UTC

svn commit: r1573827 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java

Author: sebb
Date: Tue Mar  4 00:25:03 2014
New Revision: 1573827

URL: http://svn.apache.org/r1573827
Log:
Simplify

Modified:
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java?rev=1573827&r1=1573826&r2=1573827&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntry.java Tue Mar  4 00:25:03 2014
@@ -337,17 +337,15 @@ public class CpioArchiveEntry implements
     public CpioArchiveEntry(final short format, File inputFile,
                             String entryName) {
         this(format, entryName, inputFile.isFile() ? inputFile.length() : 0);
-        long mode=0;
         if (inputFile.isDirectory()){
-            mode |= C_ISDIR;
+            setMode(C_ISDIR);
         } else if (inputFile.isFile()){
-            mode |= C_ISREG;
+            setMode(C_ISREG);
         } else {
             throw new IllegalArgumentException("Cannot determine type of file "
                                                + inputFile.getName());
         }
         // TODO set other fields as needed
-        setMode(mode);
         setTime(inputFile.lastModified() / 1000);
     }