[GitHub] [superset] eschutho commented on a change in pull request #13102: refactor: Query search into functional component

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #13102:
URL: https://github.com/apache/superset/pull/13102#discussion_r580715168



##########
File path: superset-frontend/src/SqlLab/components/QuerySearch.jsx
##########
@@ -35,7 +35,7 @@ import AsyncSelect from '../../components/AsyncSelect';
 
 const propTypes = {
   actions: PropTypes.object.isRequired,
-  height: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
+  // why is height required and then never used or invoked?

Review comment:
       remove?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org