[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4648: Fix DATA_TYPE in information_schema.columns is not compatible to mysql meta

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #4648:
URL: https://github.com/apache/incubator-doris/pull/4648#discussion_r493541513



##########
File path: be/src/exec/schema_scanner/schema_columns_scanner.cpp
##########
@@ -93,6 +93,41 @@ Status SchemaColumnsScanner::start(RuntimeState *state) {
     return Status::OK();
 }
 
+std::string SchemaColumnsScanner::data_type_to_string(TColumnDesc &desc) {
+    switch (desc.columnType) {
+        case TPrimitiveType::BOOLEAN:
+            return "tinyint";
+        case TPrimitiveType::TINYINT:
+            return "tinyint";
+        case TPrimitiveType::SMALLINT:
+            return "smallint";
+        case TPrimitiveType::INT:
+            return "int";
+        case TPrimitiveType::BIGINT:
+            return "bigint";
+        case TPrimitiveType::LARGEINT:
+            return "bigint unsinged";
+        case TPrimitiveType::FLOAT:
+            return "float";
+        case TPrimitiveType::DOUBLE:
+            return "double";
+        case TPrimitiveType::VARCHAR:

Review comment:
       How to display the length of varchar?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org