You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/20 08:58:44 UTC
[GitHub] [incubator-doris] adonis0147 opened a new pull request, #9708: [refactor][be] Optimize headers
adonis0147 opened a new pull request, #9708:
URL: https://github.com/apache/incubator-doris/pull/9708
# Proposed changes
Issue Number: close #9707
## Problem Summary:
Please refer to #9707
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No Need
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9708: [refactor][be] Optimize headers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9708:
URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1134284053
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9708: [refactor][be] Optimize headers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9708:
URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1134284011
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9708: [refactor][be] Optimize headers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9708:
URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1140603744
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9708: [refactor][be] Optimize headers
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9708:
URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1133597520
```cpp
[18:27:13]
[Step 1/1] FAILED: test/CMakeFiles/doris_be_test.dir/runtime/collection_value_test.cpp.o
[18:27:13]
[Step 1/1] ccache /var/local/ldb-toolchain/bin/g++ -DBE_TEST -DBOOST_ALL_NO_LIB -DBOOST_STACKTRACE_USE_BACKTRACE -DHAVE_INTTYPES_H -DHAVE_NETINET_IN_H -Ddoris_be_test_EXPORTS -I/root/doris/be/src -I/root/doris/be/test -isystem /root/doris/be/../gensrc/build -isystem /var/local/thirdparty/installed/include -isystem /var/local/thirdparty/installed/gperftools/include -isystem /var/local/thirdparty/installed/include/breakpad -Wall -Wno-sign-compare -pthread -Werror -fstrict-aliasing -fno-omit-frame-pointer -std=gnu++17 -D__STDC_FORMAT_MACROS -DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG -DBOOST_SYSTEM_NO_DEPRECATED -DBRPC_ENABLE_CPU_PROFILER -Wno-array-bounds -Wno-stringop-overread -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX=1 -msse4.2 -Wno-attributes -DS2_USE_GFLAGS -DS2_USE_GLOG -faligned-new -g -Wno-unused-local-typedefs -O0 -fsanitize=address -DADDRESS_SANITIZER -fprofile-arcs -ftest-coverage -DGTEST_USE_OWN_TR1_TUPLE=0 -D OS_LINUX -fno-access-control -Wno-stringop-overflow -fdiagnosti
cs-color=always -MD -MT test/CMakeFiles/doris_be_test.dir/runtime/collection_value_test.cpp.o -MF test/CMakeFiles/doris_be_test.dir/runtime/collection_value_test.cpp.o.d -o test/CMakeFiles/doris_be_test.dir/runtime/collection_value_test.cpp.o -c /root/doris/be/test/runtime/collection_value_test.cpp
[18:27:13]
[Step 1/1] /root/doris/be/test/runtime/collection_value_test.cpp: In member function 'virtual void doris::CollectionValueTest_init_Test::TestBody()':
[18:27:13]
[Step 1/1] /root/doris/be/test/runtime/collection_value_test.cpp:33:20: error: aggregate 'doris::ObjectPool pool' has incomplete type and cannot be defined
[18:27:13]
[Step 1/1] 33 | ObjectPool pool;
[18:27:13]
[Step 1/1] | ^~~~
[18:27:13]
[Step 1/1] /root/doris/be/test/runtime/collection_value_test.cpp:52:20: error: aggregate 'doris::ObjectPool pool' has incomplete type and cannot be defined
[18:27:13]
[Step 1/1] 52 | ObjectPool pool;
[18:27:13]
[Step 1/1] | ^~~~
[18:27:13]
[Step 1/1] /root/doris/be/test/runtime/collection_value_test.cpp: In member function 'virtual void doris::CollectionValueTest_set_Test::TestBody()':
[18:27:13]
[Step 1/1] /root/doris/be/test/runtime/collection_value_test.cpp:59:16: error: aggregate 'doris::ObjectPool pool' has incomplete type and cannot be defined
[18:27:13]
[Step 1/1] 59 | ObjectPool pool;
```
Hi, you should check ut build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9708: [refactor][be] Optimize headers
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9708:
URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1138019571
Hi @adonis0147 please rebase to solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 commented on pull request #9708: [refactor][be] Optimize headers
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #9708:
URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1133809871
Hi @BiteTheDDDDt , thank you for reminding me and I fixed the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9708: [refactor][be] Optimize headers
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9708:
URL: https://github.com/apache/incubator-doris/pull/9708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 commented on pull request #9708: [refactor][be] Optimize headers
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #9708:
URL: https://github.com/apache/incubator-doris/pull/9708#issuecomment-1138142482
Hi @morningman , I have resolved all conflicts. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org