You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/07 10:28:12 UTC

[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #12784: [Improvement-12782][UT] Add UT for the 13 implementations of ResourceAcquisitionAndPermissionCheck

github-code-scanning[bot] commented on code in PR #12784:
URL: https://github.com/apache/dolphinscheduler/pull/12784#discussion_r1015251861


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java:
##########
@@ -540,7 +541,7 @@
          * @param userId
          * @return
          */
-        Set<T> listAuthorizedResource(int userId, Logger logger);
+        Set<T> listAuthorizedResourceIds(int userId, Logger logger);

Review Comment:
   ## Useless parameter
   
   The parameter 'logger' is never used.
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2244)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org